diff --git a/.github/workflows/run-k8s-tests-on-garm.yaml b/.github/workflows/run-k8s-tests-on-garm.yaml index e52c819df0..520fe04fad 100644 --- a/.github/workflows/run-k8s-tests-on-garm.yaml +++ b/.github/workflows/run-k8s-tests-on-garm.yaml @@ -94,7 +94,6 @@ jobs: name: k8s-tests-garm-${{ matrix.vmm }} path: /tmp/artifacts retention-days: 1 - if-no-files-found: error - name: Delete kata-deploy if: always() diff --git a/tests/integration/kubernetes/gha-run.sh b/tests/integration/kubernetes/gha-run.sh index c8bdc4c35a..91b218ffb5 100755 --- a/tests/integration/kubernetes/gha-run.sh +++ b/tests/integration/kubernetes/gha-run.sh @@ -70,14 +70,14 @@ EOF case "${KUBERNETES}" in k3s) containerd_config_file="/var/lib/rancher/k3s/agent/etc/containerd/config.toml.tmpl" - sudo cp /var/lib/rancher/k3s/agent/etc/containerd/config.toml ${containerd_config_file} + sudo cp /var/lib/rancher/k3s/agent/etc/containerd/config.toml "${containerd_config_file}" ;; *) >&2 echo "${KUBERNETES} flavour is not supported"; exit 2 ;; esac # We're not using this with baremetal machines, so we're fine on cutting # corners here and just append this to the configuration file. - cat<&2 echo "${KUBERNETES} flavour is not supported"; exit 2 ;; esac sleep 60s - sudo cat ${containerd_config_file} + sudo cat "${containerd_config_file}" } function configure_snapshotter() { echo "::group::Configuring ${SNAPSHOTTER}" - case ${SNAPSHOTTER} in + case "${SNAPSHOTTER}" in devmapper) configure_devmapper ;; *) >&2 echo "${SNAPSHOTTER} flavour is not supported"; exit 2 ;; esac @@ -265,7 +265,7 @@ function cleanup() { get_nodes_and_pods_info if [ "${platform}" = "aks" ]; then - delete_cluster ${test_type} + delete_cluster "${test_type}" return fi @@ -336,8 +336,8 @@ function deploy_nydus_snapshotter() { echo "::endgroup::" echo "::group::nydus snapshotter logs" pods_name=$(kubectl get pods --selector=app=nydus-snapshotter -n nydus-system -o=jsonpath='{.items[*].metadata.name}') - kubectl logs ${pods_name} -n nydus-system - kubectl describe pod ${pods_name} -n nydus-system + kubectl logs "${pods_name}" -n nydus-system + kubectl describe pod "${pods_name}" -n nydus-system echo "::endgroup::" }