github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-05-01 13:14:33 +00:00
Code Issues Projects Releases Wiki Activity

virtcontainers: Add msg to existing utils unit tests

Browse Source 
Add message to existing unit tests that use arrays and loops for easier
debugging.

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
This commit is contained in:
Chelsea Mafrica 2020-08-12 05:35:54 +00:00
parent c3fc09b95b
commit fd13c93c6a
1 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/runtime/virtcontainers/utils/utils_test.go
View File

@ -6,6 +6,7 @@
package utils package utils
import ( import (
"fmt"
"io/ioutil" "io/ioutil"
"os" "os"
"path/filepath" "path/filepath"
@ -199,10 +200,11 @@ func TestGetVirtDriveName(t *testing.T) {
{18277, "vdzzz"}, {18277, "vdzzz"},
} }
for _, test := range tests { for i, test := range tests {
msg := fmt.Sprintf("test[%d]: %+v", i, test)
driveName, err := GetVirtDriveName(test.index) driveName, err := GetVirtDriveName(test.index)
assert.NoError(err) assert.NoError(err, msg)
assert.Equal(driveName, test.expectedDrive) assert.Equal(driveName, test.expectedDrive, msg)
} }
} }
@ -225,11 +227,12 @@ func TestGetSCSIIdLun(t *testing.T) {
{513, 2, 1}, {513, 2, 1},
} }
for _, test := range tests { for i, test := range tests {
msg := fmt.Sprintf("test[%d]: %+v", i, test)
scsiID, lun, err := GetSCSIIdLun(test.index) scsiID, lun, err := GetSCSIIdLun(test.index)
assert.NoError(err) assert.NoError(err, msg)
assert.Equal(scsiID, test.expectedScsiID) assert.Equal(scsiID, test.expectedScsiID, msg)
assert.Equal(lun, test.expectedLun) assert.Equal(lun, test.expectedLun, msg)
} }
_, _, err := GetSCSIIdLun(-1) _, _, err := GetSCSIIdLun(-1)
@ -251,10 +254,11 @@ func TestGetSCSIAddress(t *testing.T) {
{512, "2:0"}, {512, "2:0"},
} }
for _, test := range tests { for i, test := range tests {
msg := fmt.Sprintf("test[%d]: %+v", i, test)
scsiAddr, err := GetSCSIAddress(test.index) scsiAddr, err := GetSCSIAddress(test.index)
assert.NoError(err) assert.NoError(err, msg)
assert.Equal(scsiAddr, test.expectedSCSIAddress) assert.Equal(scsiAddr, test.expectedSCSIAddress, msg)
} }
_, err := GetSCSIAddress(-1) _, err := GetSCSIAddress(-1)
@ -299,15 +303,16 @@ func TestBuildSocketPath(t *testing.T) {
for i, d := range data { for i, d := range data {
result, err := BuildSocketPath(d.elems...) result, err := BuildSocketPath(d.elems...)
msg := fmt.Sprintf("test[%d]: %+v", i, d)
if d.valid { if d.valid {
assert.NoErrorf(err, "test %d, data %+v", i, d) assert.NoErrorf(err, "test %d, data %+v", i, d, msg)
} else { } else {
assert.Errorf(err, "test %d, data %+v", i, d) assert.Errorf(err, "test %d, data %+v", i, d, msg)
} }
assert.NotNil(result) assert.NotNil(result, msg)
assert.Equal(d.expected, result) assert.Equal(d.expected, result, msg)
} }
} }