From ff37f5c798210545b73a6cdf9c8c8e5e395377ac Mon Sep 17 00:00:00 2001 From: Binbin Zhang Date: Sat, 28 Aug 2021 04:15:59 +0800 Subject: [PATCH] runtime: Optimize the way slice created Initialize and assign a value, reducing one append operation Fixes: #2264 Signed-off-by: Binbin Zhang --- src/runtime/virtcontainers/clh.go | 6 +----- src/runtime/virtcontainers/qemu.go | 3 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/runtime/virtcontainers/clh.go b/src/runtime/virtcontainers/clh.go index e7afc097d..e98b02ece 100644 --- a/src/runtime/virtcontainers/clh.go +++ b/src/runtime/virtcontainers/clh.go @@ -742,11 +742,7 @@ func (clh *cloudHypervisor) check() error { } func (clh *cloudHypervisor) getPids() []int { - - var pids []int - pids = append(pids, clh.state.PID) - - return pids + return []int{clh.state.PID} } func (clh *cloudHypervisor) getVirtioFsPid() *int { diff --git a/src/runtime/virtcontainers/qemu.go b/src/runtime/virtcontainers/qemu.go index fcf700fa5..ec282d699 100644 --- a/src/runtime/virtcontainers/qemu.go +++ b/src/runtime/virtcontainers/qemu.go @@ -2280,8 +2280,7 @@ func (q *qemu) getPids() []int { return []int{0} } - var pids []int - pids = append(pids, pid) + pids := []int{pid} if q.state.VirtiofsdPid != 0 { pids = append(pids, q.state.VirtiofsdPid) }