From 91e1e612c3ca42f0eeacdee594c65972405108a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Mon, 31 Jul 2023 13:26:23 +0200 Subject: [PATCH] k8s: Rely on the USING_NFD environment variable passed by the jobs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Let's make sure we can rely on the tests passing down whether they want to be tested using Node Feataure Discovery or not. Right now, only the TDX job has this option set to "true", all the other jobs have this option set to "false". We can and have to merge this one before merging the NFD related patches as: 1) It causes no harm in exporting this environment variable, but not having it used 2) It will allow us to test the NFD after this one is merged, as changes in the yaml file, in the case of the pull_request_target event, are not taken into consideration before they're merged Fixes: #7495 Signed-off-by: Fabiano Fidêncio --- .github/workflows/run-k8s-tests-on-aks.yaml | 1 + .github/workflows/run-k8s-tests-on-sev.yaml | 1 + .github/workflows/run-k8s-tests-on-snp.yaml | 1 + .github/workflows/run-k8s-tests-on-tdx.yaml | 1 + 4 files changed, 4 insertions(+) diff --git a/.github/workflows/run-k8s-tests-on-aks.yaml b/.github/workflows/run-k8s-tests-on-aks.yaml index 724e97f5cc..130be18296 100644 --- a/.github/workflows/run-k8s-tests-on-aks.yaml +++ b/.github/workflows/run-k8s-tests-on-aks.yaml @@ -40,6 +40,7 @@ jobs: GH_PR_NUMBER: ${{ inputs.pr-number }} KATA_HOST_OS: ${{ matrix.host_os }} KATA_HYPERVISOR: ${{ matrix.vmm }} + USING_NFD: "false" steps: - uses: actions/checkout@v3 with: diff --git a/.github/workflows/run-k8s-tests-on-sev.yaml b/.github/workflows/run-k8s-tests-on-sev.yaml index bec1f4edf6..a48425e1fa 100644 --- a/.github/workflows/run-k8s-tests-on-sev.yaml +++ b/.github/workflows/run-k8s-tests-on-sev.yaml @@ -29,6 +29,7 @@ jobs: DOCKER_TAG: ${{ inputs.tag }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBECONFIG: /home/kata/.kube/config + USING_NFD: "false" steps: - uses: actions/checkout@v3 with: diff --git a/.github/workflows/run-k8s-tests-on-snp.yaml b/.github/workflows/run-k8s-tests-on-snp.yaml index cb65128268..7196a9a1b9 100644 --- a/.github/workflows/run-k8s-tests-on-snp.yaml +++ b/.github/workflows/run-k8s-tests-on-snp.yaml @@ -29,6 +29,7 @@ jobs: DOCKER_TAG: ${{ inputs.tag }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBECONFIG: /home/kata/.kube/config + USING_NFD: "false" steps: - uses: actions/checkout@v3 with: diff --git a/.github/workflows/run-k8s-tests-on-tdx.yaml b/.github/workflows/run-k8s-tests-on-tdx.yaml index e7373e3de3..a3899177c7 100644 --- a/.github/workflows/run-k8s-tests-on-tdx.yaml +++ b/.github/workflows/run-k8s-tests-on-tdx.yaml @@ -28,6 +28,7 @@ jobs: DOCKER_REPO: ${{ inputs.repo }} DOCKER_TAG: ${{ inputs.tag }} KATA_HYPERVISOR: ${{ matrix.vmm }} + USING_NFD: "true" steps: - uses: actions/checkout@v3 with: