github/kubectx
1
0
Fork 0
mirror of https://github.com/ahmetb/kubectx.git synced 2025-07-05 19:46:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable preview when fuzzy-finding (#163)

Browse Source 
The user may have global settings that enable the preview pane in fzf.

Whatever the preview command is set as, it probably doesn't render
anything meaningful for kubens - I can't think what would be.

For kubectx, the context yaml itself would _maybe_ be helpful, but it
likely contains secrets, so I don't personally think I'd find it useful
enough to get into.

This commit thus disables the preview, so that if the user did have it
enabled, there's now no pane where there would previously have probably
been an error, such as:

    [bat error]: '<namespace>': No such file or directory (os error 2)
This commit is contained in:
Oliver Ford 2019-10-11 17:14:32 +01:00 committed by Ahmet Alp Balkan
parent c3dd1e5deb
commit 00a1e12bfb
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kubectx
View File

@ -107,7 +107,7 @@ choose_context_interactive() {
local choice local choice
choice="$(_KUBECTX_FORCE_COLOR=1 \ choice="$(_KUBECTX_FORCE_COLOR=1 \
FZF_DEFAULT_COMMAND="${SELF_CMD}" \ FZF_DEFAULT_COMMAND="${SELF_CMD}" \
fzf --ansi || true)" fzf --ansi --no-preview || true)"
if [[ -z "${choice}" ]]; then if [[ -z "${choice}" ]]; then
echo 2>&1 "error: you did not choose any of the options" echo 2>&1 "error: you did not choose any of the options"
exit 1 exit 1

2
kubens
View File

@ -109,7 +109,7 @@ choose_namespace_interactive() {
local choice local choice
choice="$(_KUBECTX_FORCE_COLOR=1 \ choice="$(_KUBECTX_FORCE_COLOR=1 \
FZF_DEFAULT_COMMAND="${SELF_CMD}" \ FZF_DEFAULT_COMMAND="${SELF_CMD}" \
fzf --ansi || true)" fzf --ansi --no-preview || true)"
if [[ -z "${choice}" ]]; then if [[ -z "${choice}" ]]; then
echo 2>&1 "error: you did not choose any of the options" echo 2>&1 "error: you did not choose any of the options"
exit 1 exit 1