From 5b3796ba1c1aa458dc5c7235c61957c59622e0e8 Mon Sep 17 00:00:00 2001 From: Ahmet Alp Balkan Date: Fri, 10 Apr 2020 16:41:21 -0700 Subject: [PATCH] add some TODOs Signed-off-by: Ahmet Alp Balkan --- cmd/kubectx/main.go | 2 ++ cmd/kubectx/rename.go | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/kubectx/main.go b/cmd/kubectx/main.go index 65a4f00..09d3ca8 100644 --- a/cmd/kubectx/main.go +++ b/cmd/kubectx/main.go @@ -28,6 +28,8 @@ func main() { os.Exit(1) } case ListOp: + // TODO fzf installed show interactive selection + if err := printListContexts(os.Stdout); err != nil { printError("%v", err) os.Exit(1) diff --git a/cmd/kubectx/rename.go b/cmd/kubectx/rename.go index b8ba3dd..aad6a91 100644 --- a/cmd/kubectx/rename.go +++ b/cmd/kubectx/rename.go @@ -59,13 +59,13 @@ func renameContexts(old, new string) error { } } + // TODO the next two functions are always repeated. if err := resetFile(f); err != nil { return err } if err := saveKubeconfigRaw(f, rootNode); err != nil { return errors.Wrap(err, "failed to save modified kubeconfig") } - return nil }