From b9614bd2e0b1bb7b11da9627bb146b1b4d1a7524 Mon Sep 17 00:00:00 2001 From: Ahmet Alp Balkan Date: Thu, 4 Apr 2019 08:59:51 -0700 Subject: [PATCH] kubectx rename check if old_name is a valid ctx (#139) Without this safeguard, when user runs `kubectx NEW_NAME=OLD_NAME` where NEW_NAME is an existing context but OLD_NAME isn't, we end up deleting NEW_NAME and not doing any renames (because OLD_NAME is not found). Fixes #136. Signed-off-by: Ahmet Alp Balkan --- kubectx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kubectx b/kubectx index 3d317dc..0a85429 100755 --- a/kubectx +++ b/kubectx @@ -148,6 +148,11 @@ rename_context() { old_name="$(current_context)" fi + if ! context_exists "${old_name}"; then + echo "error: Context \"${old_name}\" not found, can't rename it." >&2 + exit 1 + fi + if context_exists "${new_name}"; then echo "Context \"${new_name}\" exists, deleting..." >&2 $KUBECTL config delete-context "${new_name}" 1>/dev/null 2>&1