Compare commits

..

1 Commits

Author SHA1 Message Date
Ahmet Alp Balkan
b854d7a91b ci: add workflow to warn PRs modifying frozen bash scripts
The bash implementations of kubectx/kubens are frozen and no longer
accepting improvements. This workflow comments on PRs that modify these
files to redirect contributors to the Go implementation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 16:47:53 -07:00
46 changed files with 503 additions and 438 deletions

View File

@@ -14,7 +14,7 @@ jobs:
steps: steps:
- name: Comment on PR if author is not ahmetb - name: Comment on PR if author is not ahmetb
if: github.event.pull_request.user.login != 'ahmetb' if: github.event.pull_request.user.login != 'ahmetb'
uses: actions/github-script@v8 uses: actions/github-script@v7
with: with:
script: | script: |
const body = [ const body = [

View File

@@ -25,7 +25,7 @@ jobs:
- name: Setup Go - name: Setup Go
uses: actions/setup-go@v6 uses: actions/setup-go@v6
with: with:
go-version: '1.25' go-version: '1.22'
- id: go-cache-paths - id: go-cache-paths
run: | run: |
echo "::set-output name=go-build::$(go env GOCACHE)" echo "::set-output name=go-build::$(go env GOCACHE)"

View File

@@ -24,12 +24,12 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@v4 uses: actions/checkout@master
- run: git fetch --tags - run: git fetch --tags
- name: Setup Go - name: Setup Go
uses: actions/setup-go@v6 uses: actions/setup-go@v6
with: with:
go-version: '1.25' go-version: '1.22'
- name: Install Snapcraft - name: Install Snapcraft
uses: samuelmeuli/action-snapcraft@v3 uses: samuelmeuli/action-snapcraft@v3
- name: Setup Snapcraft - name: Setup Snapcraft

View File

@@ -15,7 +15,7 @@
# limitations under the License. # limitations under the License.
# This is an example goreleaser.yaml file with some sane defaults. # This is an example goreleaser.yaml file with some sane defaults.
# Make sure to check the documentation at https://goreleaser.com # Make sure to check the documentation at http://goreleaser.com
version: 2 version: 2
before: before:
@@ -69,11 +69,11 @@ archives:
{{- else -}}v{{- . -}} {{- else -}}v{{- . -}}
{{- end -}} {{- end -}}
{{- end -}} {{- end -}}
ids: builds:
- kubectx - kubectx
format_overrides: format_overrides:
- goos: windows - goos: windows
formats: [zip] format: zip
files: ["LICENSE"] files: ["LICENSE"]
- id: kubens-archive - id: kubens-archive
name_template: |- name_template: |-
@@ -89,11 +89,11 @@ archives:
{{- else -}}v{{- . -}} {{- else -}}v{{- . -}}
{{- end -}} {{- end -}}
{{- end -}} {{- end -}}
ids: builds:
- kubens - kubens
format_overrides: format_overrides:
- goos: windows - goos: windows
formats: [zip] format: zip
files: ["LICENSE"] files: ["LICENSE"]
checksum: checksum:
name_template: "checksums.txt" name_template: "checksums.txt"
@@ -111,7 +111,7 @@ snapcrafts:
kubens is a tool to switch between Kubernetes namespaces (and configure them for kubectl) easily. kubens is a tool to switch between Kubernetes namespaces (and configure them for kubectl) easily.
grade: stable grade: stable
confinement: classic confinement: classic
base: core24 base: core20
apps: apps:
kubectx: kubectx:
command: kubectx command: kubectx

172
README.md
View File

@@ -72,23 +72,139 @@ names anymore.
## Installation ## Installation
| Package manager | Command | Stable versions of `kubectx` and `kubens` are small bash scripts that you
|---|---| can find in this repository.
| [Homebrew](https://brew.sh/) (macOS & Linux) | `brew install kubectx` |
| [MacPorts](https://www.macports.org) (macOS) | `sudo port install kubectx` |
| apt (Debian/Ubuntu) | `sudo apt install kubectx` |
| pacman (Arch Linux) | `sudo pacman -S kubectx` |
| [Chocolatey](https://chocolatey.org/) (Windows) | `choco install kubens kubectx` |
| [Scoop](https://scoop.sh/) (Windows) | `scoop bucket add main && scoop install main/kubens main/kubectx` |
| [winget](https://learn.microsoft.com/en-us/windows/package-manager/) (Windows) | `winget install --id ahmetb.kubectx && winget install --id ahmetb.kubens` |
| [Krew](https://github.com/kubernetes-sigs/krew/) (kubectl plugin) | `kubectl krew install ctx && kubectl krew install ns` |
Alternatively, download binaries from the [**Releases page &rarr;**](https://github.com/ahmetb/kubectx/releases) and add them to somewhere in your `PATH`. Starting with v0.9.0, `kubectx` and `kubens` **are now rewritten in Go**. They
should work the same way (and we'll keep the bash-based implementations around)
but the new features will be added to the new Go programs. Please help us test
this new Go implementation by downloading the binaries from the [**Releases page
&rarr;**](https://github.com/ahmetb/kubectx/releases)
<details> **Installation options:**
<summary>Shell completion scripts</summary>
#### zsh (with [antibody](https://getantibody.github.io)) - [as kubectl plugins (macOS & Linux)](#kubectl-plugins-macos-and-linux)
- [with Homebrew (macOS & Linux)](#homebrew-macos-and-linux)
- [with MacPorts (macOS)](#macports-macos)
- [with apt (Debian)](#apt-debian)
- [with pacman (Arch Linux)](#pacman-arch-linux)
- [with Chocolatey (Windows)](#windows-installation-using-chocolatey)
- [Windows Installation (using Scoop)](#windows-installation-using-scoop)
- [with winget (Windows)](#windows-installation-using-winget)
- [manually (macOS & Linux)](#manual-installation-macos-and-linux)
If you like to add context/namespace information to your shell prompt (`$PS1`),
you can try out [kube-ps1].
[kube-ps1]: https://github.com/jonmosco/kube-ps1
### Kubectl Plugins (macOS and Linux)
You can install and use the [Krew](https://github.com/kubernetes-sigs/krew/) kubectl
plugin manager to get `kubectx` and `kubens`.
**Note:** This will not install the shell completion scripts. If you want them,
*choose another installation method
or install the scripts [manually](#manual-installation-macos-and-linux).
```sh
kubectl krew install ctx
kubectl krew install ns
```
After installing, the tools will be available as `kubectl ctx` and `kubectl ns`.
### Homebrew (macOS and Linux)
If you use [Homebrew](https://brew.sh/) you can install like this:
```sh
brew install kubectx
```
This command will set up bash/zsh/fish completion scripts automatically. Make sure you [configure your shell](https://docs.brew.sh/Shell-Completion) to load completions for installed Homebrew formulas.
### MacPorts (macOS)
If you use [MacPorts](https://www.macports.org) you can install like this:
```sh
sudo port install kubectx
```
### apt (Debian)
``` bash
sudo apt install kubectx
```
Newer versions might be available on repos like
[Debian Buster (testing)](https://packages.debian.org/buster/kubectx),
[Sid (unstable)](https://packages.debian.org/sid/kubectx)
(_if you are unfamiliar with the Debian release process and how to enable
testing/unstable repos, check out the
[Debian Wiki](https://wiki.debian.org/DebianReleases)_):
### pacman (Arch Linux)
Available as official Arch Linux package. Install it via:
```bash
sudo pacman -S kubectx
```
### Windows Installation (using Chocolatey)
Available as packages on [Chocolatey](https://chocolatey.org/why-chocolatey)
```pwsh
choco install kubens kubectx
```
### Windows Installation (using Scoop)
Available as packages on [Scoop](https://scoop.sh/)
```pwsh
scoop bucket add main
scoop install main/kubens main/kubectx
```
### Windows Installation (using winget)
Available as packages on [winget](https://learn.microsoft.com/en-us/windows/package-manager/)
```pwsh
winget install --id ahmetb.kubectx
winget install --id ahmetb.kubens
```
### Manual Installation (macOS and Linux)
Since `kubectx` and `kubens` are written in Bash, you should be able to install
them to any POSIX environment that has Bash installed.
- Download the `kubectx`, and `kubens` scripts.
- Either:
- save them all to somewhere in your `PATH`,
- or save them to a directory, then create symlinks to `kubectx`/`kubens` from
somewhere in your `PATH`, like `/usr/local/bin`
- Make `kubectx` and `kubens` executable (`chmod +x ...`)
Example installation steps:
``` bash
sudo git clone https://github.com/ahmetb/kubectx /opt/kubectx
sudo ln -s /opt/kubectx/kubectx /usr/local/bin/kubectx
sudo ln -s /opt/kubectx/kubens /usr/local/bin/kubens
```
If you also want to have shell completions, pick an installation method for the
[completion scripts](completion/) that fits your system best: [`zsh` with
`antibody`](#completion-scripts-for-zsh-with-antibody), [plain
`zsh`](#completion-scripts-for-plain-zsh),
[`bash`](#completion-scripts-for-bash) or
[`fish`](#completion-scripts-for-fish).
#### Completion scripts for `zsh` with [antibody](https://getantibody.github.io)
Add this line to your [Plugins File](https://getantibody.github.io/usage/) (e.g. Add this line to your [Plugins File](https://getantibody.github.io/usage/) (e.g.
`~/.zsh_plugins.txt`): `~/.zsh_plugins.txt`):
@@ -101,9 +217,9 @@ Depending on your setup, you might or might not need to call `compinit` or
`autoload -U compinit && compinit` in your `~/.zshrc` after you load the Plugins `autoload -U compinit && compinit` in your `~/.zshrc` after you load the Plugins
file. If you use [oh-my-zsh](https://github.com/ohmyzsh/ohmyzsh), load the file. If you use [oh-my-zsh](https://github.com/ohmyzsh/ohmyzsh), load the
completions before you load `oh-my-zsh` because `oh-my-zsh` will call completions before you load `oh-my-zsh` because `oh-my-zsh` will call
`compinit`. `compinit`.
#### zsh (plain) #### Completion scripts for plain `zsh`
The completion scripts have to be in a path that belongs to `$fpath`. Either The completion scripts have to be in a path that belongs to `$fpath`. Either
link or copy them to an existing folder. link or copy them to an existing folder.
@@ -128,7 +244,7 @@ depending on the `$fpath` of your zsh installation.
In case of errors, calling `compaudit` might help. In case of errors, calling `compaudit` might help.
#### bash #### Completion scripts for `bash`
```bash ```bash
git clone https://github.com/ahmetb/kubectx.git ~/.kubectx git clone https://github.com/ahmetb/kubectx.git ~/.kubectx
@@ -143,7 +259,7 @@ export PATH=~/.kubectx:\$PATH
EOF EOF
``` ```
#### fish #### Completion scripts for `fish`
```fish ```fish
mkdir -p ~/.config/fish/completions mkdir -p ~/.config/fish/completions
@@ -151,12 +267,6 @@ ln -s /opt/kubectx/completion/kubectx.fish ~/.config/fish/completions/
ln -s /opt/kubectx/completion/kubens.fish ~/.config/fish/completions/ ln -s /opt/kubectx/completion/kubens.fish ~/.config/fish/completions/
``` ```
</details>
> [!NOTE]
> Tip: Show context/namespace in your shell prompt with [oh-my-posh](https://ohmyposh.dev/) or
> simply with [kube-ps1](https://github.com/jonmosco/kube-ps1).
----- -----
### Interactive mode ### Interactive mode
@@ -167,12 +277,12 @@ with fuzzy searching, you just need to [install
![kubectx interactive search with fzf](img/kubectx-interactive.gif) ![kubectx interactive search with fzf](img/kubectx-interactive.gif)
Caveats: If you have `fzf` installed, but want to opt out of using this feature, set the
- If you have `fzf` installed, but want to opt out of using this feature, set the environment variable `KUBECTX_IGNORE_FZF=1`.
environment variable `KUBECTX_IGNORE_FZF=1`.
- If you want to keep `fzf` interactive mode but need the default behavior of the If you want to keep `fzf` interactive mode but need the default behavior of the
command, you can do it by piping the output to another command (e.g. `kubectx | command, you can do it by piping the output to another command (e.g. `kubectx |
cat `). cat `).
----- -----
@@ -196,7 +306,7 @@ Colors in the output can be disabled by setting the
If you liked `kubectx`, you may like my If you liked `kubectx`, you may like my
[`kubectl-aliases`](https://github.com/ahmetb/kubectl-aliases) project, too. I [`kubectl-aliases`](https://github.com/ahmetb/kubectl-aliases) project, too. I
recommend pairing kubectx and kubens with [fzf](#interactive-mode) and recommend pairing kubectx and kubens with [fzf](#interactive-mode) and
[kube-ps1](https://github.com/jonmosco/kube-ps1). [kube-ps1].
#### Stargazers over time #### Stargazers over time

View File

@@ -15,10 +15,11 @@
package main package main
import ( import (
"errors"
"fmt" "fmt"
"io" "io"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
) )
@@ -32,18 +33,13 @@ func (_op CurrentOp) Run(stdout, _ io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
v, err := kc.GetCurrentContext() v := kc.GetCurrentContext()
if err != nil {
return fmt.Errorf("failed to get current context: %w", err)
}
if v == "" { if v == "" {
return errors.New("current-context is not set") return errors.New("current-context is not set")
} }
if _, err := fmt.Fprintln(stdout, v); err != nil { _, err := fmt.Fprintln(stdout, v)
return fmt.Errorf("write error: %w", err) return errors.Wrap(err, "write error")
}
return nil
} }

View File

@@ -15,10 +15,10 @@
package main package main
import ( import (
"errors"
"fmt"
"io" "io"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
"github.com/ahmetb/kubectx/internal/printer" "github.com/ahmetb/kubectx/internal/printer"
) )
@@ -37,14 +37,14 @@ func (op DeleteOp) Run(_, stderr io.Writer) error {
// TODO inefficiency here. we open/write/close the same file many times. // TODO inefficiency here. we open/write/close the same file many times.
deletedName, wasActiveContext, err := deleteContext(ctx) deletedName, wasActiveContext, err := deleteContext(ctx)
if err != nil { if err != nil {
return fmt.Errorf("error deleting context \"%s\": %w", deletedName, err) return errors.Wrapf(err, "error deleting context \"%s\"", deletedName)
} }
if wasActiveContext { if wasActiveContext {
printer.Warning(stderr, "You deleted the current context. Use \"%s\" to select a new context.", printer.Warning(stderr, "You deleted the current context. Use \"%s\" to select a new context.",
selfName()) selfName())
} }
_ = printer.Success(stderr, `Deleted context %s.`, printer.SuccessColor.Sprint(deletedName)) printer.Success(stderr, `Deleted context %s.`, printer.SuccessColor.Sprint(deletedName))
} }
return nil return nil
} }
@@ -55,13 +55,10 @@ func deleteContext(name string) (deleteName string, wasActiveContext bool, err e
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return deleteName, false, fmt.Errorf("kubeconfig error: %w", err) return deleteName, false, errors.Wrap(err, "kubeconfig error")
} }
cur, err := kc.GetCurrentContext() cur := kc.GetCurrentContext()
if err != nil {
return deleteName, false, fmt.Errorf("failed to get current context: %w", err)
}
// resolve "." to a real name // resolve "." to a real name
if name == "." { if name == "." {
if cur == "" { if cur == "" {
@@ -71,19 +68,12 @@ func deleteContext(name string) (deleteName string, wasActiveContext bool, err e
name = cur name = cur
} }
exists, err := kc.ContextExists(name) if !kc.ContextExists(name) {
if err != nil {
return name, false, fmt.Errorf("failed to check context: %w", err)
}
if !exists {
return name, false, errors.New("context does not exist") return name, false, errors.New("context does not exist")
} }
if err := kc.DeleteContextEntry(name); err != nil { if err := kc.DeleteContextEntry(name); err != nil {
return name, false, fmt.Errorf("failed to modify yaml doc: %w", err) return name, false, errors.Wrap(err, "failed to modify yaml doc")
} }
if err := kc.Save(); err != nil { return name, wasActiveContext, errors.Wrap(kc.Save(), "failed to save modified kubeconfig file")
return name, wasActiveContext, fmt.Errorf("failed to save modified kubeconfig file: %w", err)
}
return name, wasActiveContext, nil
} }

View File

@@ -16,13 +16,14 @@ package main
import ( import (
"bytes" "bytes"
"errors"
"fmt" "fmt"
"io" "io"
"os" "os"
"os/exec" "os/exec"
"strings" "strings"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/cmdutil" "github.com/ahmetb/kubectx/internal/cmdutil"
"github.com/ahmetb/kubectx/internal/env" "github.com/ahmetb/kubectx/internal/env"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
@@ -43,22 +44,14 @@ func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
} }
// parse kubeconfig just to see if it can be loaded // parse kubeconfig just to see if it can be loaded
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
if cmdutil.IsNotFoundErr(err) { if cmdutil.IsNotFoundErr(err) {
printer.Warning(stderr, "kubeconfig file not found") printer.Warning(stderr, "kubeconfig file not found")
return nil return nil
} }
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
}
ctxNames, err := kc.ContextNames()
if err != nil {
return fmt.Errorf("failed to get context names: %w", err)
}
if len(ctxNames) == 0 {
return errors.New("no contexts found in the kubeconfig file")
} }
kc.Close()
cmd := exec.Command("fzf", "--ansi", "--no-preview") cmd := exec.Command("fzf", "--ansi", "--no-preview")
var out bytes.Buffer var out bytes.Buffer
@@ -70,8 +63,7 @@ func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
fmt.Sprintf("FZF_DEFAULT_COMMAND=%s", op.SelfCmd), fmt.Sprintf("FZF_DEFAULT_COMMAND=%s", op.SelfCmd),
fmt.Sprintf("%s=1", env.EnvForceColor)) fmt.Sprintf("%s=1", env.EnvForceColor))
if err := cmd.Run(); err != nil { if err := cmd.Run(); err != nil {
var exitErr *exec.ExitError if _, ok := err.(*exec.ExitError); !ok {
if !errors.As(err, &exitErr) {
return err return err
} }
} }
@@ -81,9 +73,9 @@ func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
} }
name, err := switchContext(choice) name, err := switchContext(choice)
if err != nil { if err != nil {
return fmt.Errorf("failed to switch context: %w", err) return errors.Wrap(err, "failed to switch context")
} }
_ = printer.Success(stderr, "Switched to context \"%s\".", printer.SuccessColor.Sprint(name)) printer.Success(stderr, "Switched to context \"%s\".", printer.SuccessColor.Sprint(name))
return nil return nil
} }
@@ -93,20 +85,16 @@ func (op InteractiveDeleteOp) Run(_, stderr io.Writer) error {
} }
// parse kubeconfig just to see if it can be loaded // parse kubeconfig just to see if it can be loaded
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
if cmdutil.IsNotFoundErr(err) { if cmdutil.IsNotFoundErr(err) {
printer.Warning(stderr, "kubeconfig file not found") printer.Warning(stderr, "kubeconfig file not found")
return nil return nil
} }
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
kc.Close()
ctxNames, err := kc.ContextNames() if len(kc.ContextNames()) == 0 {
if err != nil {
return fmt.Errorf("failed to get context names: %w", err)
}
if len(ctxNames) == 0 {
return errors.New("no contexts found in config") return errors.New("no contexts found in config")
} }
@@ -120,8 +108,7 @@ func (op InteractiveDeleteOp) Run(_, stderr io.Writer) error {
fmt.Sprintf("FZF_DEFAULT_COMMAND=%s", op.SelfCmd), fmt.Sprintf("FZF_DEFAULT_COMMAND=%s", op.SelfCmd),
fmt.Sprintf("%s=1", env.EnvForceColor)) fmt.Sprintf("%s=1", env.EnvForceColor))
if err := cmd.Run(); err != nil { if err := cmd.Run(); err != nil {
var exitErr *exec.ExitError if _, ok := err.(*exec.ExitError); !ok {
if !errors.As(err, &exitErr) {
return err return err
} }
} }
@@ -133,7 +120,7 @@ func (op InteractiveDeleteOp) Run(_, stderr io.Writer) error {
name, wasActiveContext, err := deleteContext(choice) name, wasActiveContext, err := deleteContext(choice)
if err != nil { if err != nil {
return fmt.Errorf("failed to delete context: %w", err) return errors.Wrap(err, "failed to delete context")
} }
if wasActiveContext { if wasActiveContext {
@@ -141,7 +128,7 @@ func (op InteractiveDeleteOp) Run(_, stderr io.Writer) error {
selfName()) selfName())
} }
_ = printer.Success(stderr, `Deleted context %s.`, printer.SuccessColor.Sprint(name)) printer.Success(stderr, `Deleted context %s.`, printer.SuccessColor.Sprint(name))
return nil return nil
} }

View File

@@ -20,6 +20,8 @@ import (
"os" "os"
"path/filepath" "path/filepath"
"strings" "strings"
"github.com/pkg/errors"
) )
// HelpOp describes printing help. // HelpOp describes printing help.
@@ -48,10 +50,7 @@ func printUsage(out io.Writer) error {
help = strings.ReplaceAll(help, "%SPAC%", strings.Repeat(" ", len(selfName()))) help = strings.ReplaceAll(help, "%SPAC%", strings.Repeat(" ", len(selfName())))
_, err := fmt.Fprintf(out, "%s\n", help) _, err := fmt.Fprintf(out, "%s\n", help)
if err != nil { return errors.Wrap(err, "write error")
return fmt.Errorf("write error: %w", err)
}
return nil
} }
// selfName guesses how the user invoked the program. // selfName guesses how the user invoked the program.

View File

@@ -19,6 +19,6 @@ func checkIsolatedMode() error {
return fmt.Errorf("you are in a locked single-context shell, use 'exit' to leave") return fmt.Errorf("you are in a locked single-context shell, use 'exit' to leave")
} }
cur, _ := kc.GetCurrentContext() cur := kc.GetCurrentContext()
return fmt.Errorf("you are in a locked single-context shell (\"%s\"), use 'exit' to leave", cur) return fmt.Errorf("you are in a locked single-context shell (\"%s\"), use 'exit' to leave", cur)
} }

View File

@@ -19,6 +19,7 @@ import (
"io" "io"
"facette.io/natsort" "facette.io/natsort"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/cmdutil" "github.com/ahmetb/kubectx/internal/cmdutil"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
@@ -39,19 +40,13 @@ func (_ ListOp) Run(stdout, stderr io.Writer) error {
printer.Warning(stderr, "kubeconfig file not found") printer.Warning(stderr, "kubeconfig file not found")
return nil return nil
} }
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
ctxs, err := kc.ContextNames() ctxs := kc.ContextNames()
if err != nil {
return fmt.Errorf("failed to get context names: %w", err)
}
natsort.Sort(ctxs) natsort.Sort(ctxs)
cur, err := kc.GetCurrentContext() cur := kc.GetCurrentContext()
if err != nil {
return fmt.Errorf("failed to get current context: %w", err)
}
for _, c := range ctxs { for _, c := range ctxs {
s := c s := c
if c == cur { if c == cur {

View File

@@ -34,7 +34,7 @@ func main() {
op := parseArgs(os.Args[1:]) op := parseArgs(os.Args[1:])
if err := op.Run(color.Output, color.Error); err != nil { if err := op.Run(color.Output, color.Error); err != nil {
printer.Error(color.Error, "%s", err) printer.Error(color.Error, err.Error())
if _, ok := os.LookupEnv(env.EnvDebug); ok { if _, ok := os.LookupEnv(env.EnvDebug); ok {
// print stack trace in verbose mode // print stack trace in verbose mode

View File

@@ -15,10 +15,11 @@
package main package main
import ( import (
"fmt"
"io" "io"
"strings" "strings"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
"github.com/ahmetb/kubectx/internal/printer" "github.com/ahmetb/kubectx/internal/printer"
) )
@@ -32,8 +33,12 @@ type RenameOp struct {
// parseRenameSyntax parses A=B form into [A,B] and returns // parseRenameSyntax parses A=B form into [A,B] and returns
// whether it is parsed correctly. // whether it is parsed correctly.
func parseRenameSyntax(v string) (string, string, bool) { func parseRenameSyntax(v string) (string, string, bool) {
new, old, ok := strings.Cut(v, "=") s := strings.Split(v, "=")
if !ok || new == "" || old == "" { if len(s) != 2 {
return "", "", false
}
new, old := s[0], s[1]
if new == "" || old == "" {
return "", "", false return "", "", false
} }
return new, old, true return new, old, true
@@ -49,48 +54,37 @@ func (op RenameOp) Run(_, stderr io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
cur, err := kc.GetCurrentContext() cur := kc.GetCurrentContext()
if err != nil {
return fmt.Errorf("failed to get current context: %w", err)
}
if op.Old == "." { if op.Old == "." {
op.Old = cur op.Old = cur
} }
oldExists, err := kc.ContextExists(op.Old) if !kc.ContextExists(op.Old) {
if err != nil { return errors.Errorf("context \"%s\" not found, can't rename it", op.Old)
return fmt.Errorf("failed to check context: %w", err)
}
if !oldExists {
return fmt.Errorf("context \"%s\" not found, can't rename it", op.Old)
} }
newExists, err := kc.ContextExists(op.New) if kc.ContextExists(op.New) {
if err != nil {
return fmt.Errorf("failed to check context: %w", err)
}
if newExists {
printer.Warning(stderr, "context \"%s\" exists, overwriting it.", op.New) printer.Warning(stderr, "context \"%s\" exists, overwriting it.", op.New)
if err := kc.DeleteContextEntry(op.New); err != nil { if err := kc.DeleteContextEntry(op.New); err != nil {
return fmt.Errorf("failed to delete new context to overwrite it: %w", err) return errors.Wrap(err, "failed to delete new context to overwrite it")
} }
} }
if err := kc.ModifyContextName(op.Old, op.New); err != nil { if err := kc.ModifyContextName(op.Old, op.New); err != nil {
return fmt.Errorf("failed to change context name: %w", err) return errors.Wrap(err, "failed to change context name")
} }
if op.Old == cur { if op.Old == cur {
if err := kc.ModifyCurrentContext(op.New); err != nil { if err := kc.ModifyCurrentContext(op.New); err != nil {
return fmt.Errorf("failed to set current-context to new name: %w", err) return errors.Wrap(err, "failed to set current-context to new name")
} }
} }
if err := kc.Save(); err != nil { if err := kc.Save(); err != nil {
return fmt.Errorf("failed to save modified kubeconfig: %w", err) return errors.Wrap(err, "failed to save modified kubeconfig")
} }
_ = printer.Success(stderr, "Context %s renamed to %s.", printer.Success(stderr, "Context %s renamed to %s.",
printer.SuccessColor.Sprint(op.Old), printer.SuccessColor.Sprint(op.Old),
printer.SuccessColor.Sprint(op.New)) printer.SuccessColor.Sprint(op.New))
return nil return nil

View File

@@ -8,6 +8,7 @@ import (
"runtime" "runtime"
"github.com/fatih/color" "github.com/fatih/color"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/env" "github.com/ahmetb/kubectx/internal/env"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
@@ -33,37 +34,30 @@ func (op ShellOp) Run(_, stderr io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
exists, err := kc.ContextExists(op.Target) if !kc.ContextExists(op.Target) {
if err != nil {
return fmt.Errorf("failed to check context: %w", err)
}
if !exists {
return fmt.Errorf("no context exists with the name: \"%s\"", op.Target) return fmt.Errorf("no context exists with the name: \"%s\"", op.Target)
} }
previousCtx, err := kc.GetCurrentContext() previousCtx := kc.GetCurrentContext()
if err != nil {
return fmt.Errorf("failed to get current context: %w", err)
}
// Extract minimal kubeconfig using kubectl // Extract minimal kubeconfig using kubectl
data, err := extractMinimalKubeconfig(kubectlPath, op.Target) data, err := extractMinimalKubeconfig(kubectlPath, op.Target)
if err != nil { if err != nil {
return fmt.Errorf("failed to extract kubeconfig for context: %w", err) return errors.Wrap(err, "failed to extract kubeconfig for context")
} }
// Write to temp file // Write to temp file
tmpFile, err := os.CreateTemp("", "kubectx-shell-*.yaml") tmpFile, err := os.CreateTemp("", "kubectx-shell-*.yaml")
if err != nil { if err != nil {
return fmt.Errorf("failed to create temp kubeconfig file: %w", err) return errors.Wrap(err, "failed to create temp kubeconfig file")
} }
tmpPath := tmpFile.Name() tmpPath := tmpFile.Name()
defer os.Remove(tmpPath) defer os.Remove(tmpPath)
if _, err := tmpFile.Write(data); err != nil { if _, err := tmpFile.Write(data); err != nil {
tmpFile.Close() tmpFile.Close()
return fmt.Errorf("failed to write temp kubeconfig: %w", err) return errors.Wrap(err, "failed to write temp kubeconfig")
} }
tmpFile.Close() tmpFile.Close()

View File

@@ -2,6 +2,7 @@ package main
import ( import (
"bytes" "bytes"
"os"
"runtime" "runtime"
"testing" "testing"
@@ -32,7 +33,13 @@ func Test_detectShell_unix(t *testing.T) {
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
t.Setenv("SHELL", tt.shellEnv) orig := os.Getenv("SHELL")
defer os.Setenv("SHELL", orig)
os.Setenv("SHELL", tt.shellEnv)
if tt.shellEnv == "" {
os.Unsetenv("SHELL")
}
got := detectShell() got := detectShell()
if got != tt.want { if got != tt.want {
@@ -44,7 +51,9 @@ func Test_detectShell_unix(t *testing.T) {
func Test_ShellOp_blockedWhenNested(t *testing.T) { func Test_ShellOp_blockedWhenNested(t *testing.T) {
// Simulate being inside an isolated shell // Simulate being inside an isolated shell
t.Setenv(env.EnvIsolatedShell, "1") orig := os.Getenv(env.EnvIsolatedShell)
defer os.Setenv(env.EnvIsolatedShell, orig)
os.Setenv(env.EnvIsolatedShell, "1")
op := ShellOp{Target: "some-context"} op := ShellOp{Target: "some-context"}
var stdout, stderr bytes.Buffer var stdout, stderr bytes.Buffer
@@ -66,7 +75,10 @@ func Test_ShellOp_blockedWhenNested(t *testing.T) {
} }
func Test_resolveKubectl_envVar(t *testing.T) { func Test_resolveKubectl_envVar(t *testing.T) {
t.Setenv("KUBECTL", "/custom/path/kubectl") orig := os.Getenv("KUBECTL")
defer os.Setenv("KUBECTL", orig)
os.Setenv("KUBECTL", "/custom/path/kubectl")
got, err := resolveKubectl() got, err := resolveKubectl()
if err != nil { if err != nil {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
@@ -77,7 +89,9 @@ func Test_resolveKubectl_envVar(t *testing.T) {
} }
func Test_resolveKubectl_inPath(t *testing.T) { func Test_resolveKubectl_inPath(t *testing.T) {
t.Setenv("KUBECTL", "") orig := os.Getenv("KUBECTL")
defer os.Setenv("KUBECTL", orig)
os.Unsetenv("KUBECTL")
// kubectl should be findable in PATH on most dev machines // kubectl should be findable in PATH on most dev machines
got, err := resolveKubectl() got, err := resolveKubectl()
@@ -90,7 +104,9 @@ func Test_resolveKubectl_inPath(t *testing.T) {
} }
func Test_checkIsolatedMode_notSet(t *testing.T) { func Test_checkIsolatedMode_notSet(t *testing.T) {
t.Setenv(env.EnvIsolatedShell, "") orig := os.Getenv(env.EnvIsolatedShell)
defer os.Setenv(env.EnvIsolatedShell, orig)
os.Unsetenv(env.EnvIsolatedShell)
err := checkIsolatedMode() err := checkIsolatedMode()
if err != nil { if err != nil {
@@ -99,7 +115,9 @@ func Test_checkIsolatedMode_notSet(t *testing.T) {
} }
func Test_checkIsolatedMode_set(t *testing.T) { func Test_checkIsolatedMode_set(t *testing.T) {
t.Setenv(env.EnvIsolatedShell, "1") orig := os.Getenv(env.EnvIsolatedShell)
defer os.Setenv(env.EnvIsolatedShell, orig)
os.Setenv(env.EnvIsolatedShell, "1")
err := checkIsolatedMode() err := checkIsolatedMode()
if err == nil { if err == nil {

View File

@@ -15,26 +15,27 @@
package main package main
import ( import (
"errors" "io/ioutil"
"fmt"
"os" "os"
"path/filepath" "path/filepath"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/cmdutil" "github.com/ahmetb/kubectx/internal/cmdutil"
) )
func kubectxPrevCtxFile() (string, error) { func kubectxPrevCtxFile() (string, error) {
dir := cmdutil.CacheDir() home := cmdutil.HomeDir()
if dir == "" { if home == "" {
return "", errors.New("HOME or USERPROFILE environment variable not set") return "", errors.New("HOME or USERPROFILE environment variable not set")
} }
return filepath.Join(dir, "kubectx"), nil return filepath.Join(home, ".kube", "kubectx"), nil
} }
// readLastContext returns the saved previous context // readLastContext returns the saved previous context
// if the state file exists, otherwise returns "". // if the state file exists, otherwise returns "".
func readLastContext(path string) (string, error) { func readLastContext(path string) (string, error) {
b, err := os.ReadFile(path) b, err := ioutil.ReadFile(path)
if os.IsNotExist(err) { if os.IsNotExist(err) {
return "", nil return "", nil
} }
@@ -46,7 +47,7 @@ func readLastContext(path string) (string, error) {
func writeLastContext(path, value string) error { func writeLastContext(path, value string) error {
dir := filepath.Dir(path) dir := filepath.Dir(path)
if err := os.MkdirAll(dir, 0755); err != nil { if err := os.MkdirAll(dir, 0755); err != nil {
return fmt.Errorf("failed to create parent directories: %w", err) return errors.Wrap(err, "failed to create parent directories")
} }
return os.WriteFile(path, []byte(value), 0644) return ioutil.WriteFile(path, []byte(value), 0644)
} }

View File

@@ -15,9 +15,12 @@
package main package main
import ( import (
"io/ioutil"
"os" "os"
"path/filepath" "path/filepath"
"testing" "testing"
"github.com/ahmetb/kubectx/internal/testutil"
) )
func Test_readLastContext_nonExistingFile(t *testing.T) { func Test_readLastContext_nonExistingFile(t *testing.T) {
@@ -31,11 +34,8 @@ func Test_readLastContext_nonExistingFile(t *testing.T) {
} }
func Test_readLastContext(t *testing.T) { func Test_readLastContext(t *testing.T) {
dir := t.TempDir() path, cleanup := testutil.TempFile(t, "foo")
path := filepath.Join(dir, "testfile") defer cleanup()
if err := os.WriteFile(path, []byte("foo"), 0644); err != nil {
t.Fatal(err)
}
s, err := readLastContext(path) s, err := readLastContext(path)
if err != nil { if err != nil {
@@ -55,7 +55,10 @@ func Test_writeLastContext_err(t *testing.T) {
} }
func Test_writeLastContext(t *testing.T) { func Test_writeLastContext(t *testing.T) {
dir := t.TempDir() dir, err := ioutil.TempDir(os.TempDir(), "state-file-test")
if err != nil {
t.Fatal(err)
}
path := filepath.Join(dir, "foo", "bar") path := filepath.Join(dir, "foo", "bar")
if err := writeLastContext(path, "ctx1"); err != nil { if err := writeLastContext(path, "ctx1"); err != nil {
@@ -72,8 +75,9 @@ func Test_writeLastContext(t *testing.T) {
} }
func Test_kubectxFilePath(t *testing.T) { func Test_kubectxFilePath(t *testing.T) {
t.Setenv("HOME", filepath.FromSlash("/foo/bar")) origHome := os.Getenv("HOME")
t.Setenv("XDG_CACHE_HOME", "") os.Setenv("HOME", filepath.FromSlash("/foo/bar"))
defer os.Setenv("HOME", origHome)
expected := filepath.Join(filepath.FromSlash("/foo/bar"), ".kube", "kubectx") expected := filepath.Join(filepath.FromSlash("/foo/bar"), ".kube", "kubectx")
v, err := kubectxPrevCtxFile() v, err := kubectxPrevCtxFile()
@@ -85,22 +89,13 @@ func Test_kubectxFilePath(t *testing.T) {
} }
} }
func Test_kubectxFilePath_xdgCacheHome(t *testing.T) {
t.Setenv("XDG_CACHE_HOME", filepath.FromSlash("/tmp/xdg-cache"))
expected := filepath.Join(filepath.FromSlash("/tmp/xdg-cache"), "kubectx")
v, err := kubectxPrevCtxFile()
if err != nil {
t.Fatal(err)
}
if v != expected {
t.Fatalf("expected=\"%s\" got=\"%s\"", expected, v)
}
}
func Test_kubectxFilePath_error(t *testing.T) { func Test_kubectxFilePath_error(t *testing.T) {
t.Setenv("HOME", "") origHome := os.Getenv("HOME")
t.Setenv("USERPROFILE", "") origUserprofile := os.Getenv("USERPROFILE")
os.Unsetenv("HOME")
os.Unsetenv("USERPROFILE")
defer os.Setenv("HOME", origHome)
defer os.Setenv("USERPROFILE", origUserprofile)
_, err := kubectxPrevCtxFile() _, err := kubectxPrevCtxFile()
if err == nil { if err == nil {

View File

@@ -15,10 +15,10 @@
package main package main
import ( import (
"errors"
"fmt"
"io" "io"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
"github.com/ahmetb/kubectx/internal/printer" "github.com/ahmetb/kubectx/internal/printer"
) )
@@ -40,48 +40,39 @@ func (op SwitchOp) Run(_, stderr io.Writer) error {
newCtx, err = switchContext(op.Target) newCtx, err = switchContext(op.Target)
} }
if err != nil { if err != nil {
return fmt.Errorf("failed to switch context: %w", err) return errors.Wrap(err, "failed to switch context")
} }
if err = printer.Success(stderr, "Switched to context \"%s\".", printer.SuccessColor.Sprint(newCtx)); err != nil { err = printer.Success(stderr, "Switched to context \"%s\".", printer.SuccessColor.Sprint(newCtx))
return fmt.Errorf("print error: %w", err) return errors.Wrap(err, "print error")
}
return nil
} }
// switchContext switches to specified context name. // switchContext switches to specified context name.
func switchContext(name string) (string, error) { func switchContext(name string) (string, error) {
prevCtxFile, err := kubectxPrevCtxFile() prevCtxFile, err := kubectxPrevCtxFile()
if err != nil { if err != nil {
return "", fmt.Errorf("failed to determine state file: %w", err) return "", errors.Wrap(err, "failed to determine state file")
} }
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return "", fmt.Errorf("kubeconfig error: %w", err) return "", errors.Wrap(err, "kubeconfig error")
} }
prev, err := kc.GetCurrentContext() prev := kc.GetCurrentContext()
if err != nil { if !kc.ContextExists(name) {
return "", fmt.Errorf("failed to get current context: %w", err) return "", errors.Errorf("no context exists with the name: \"%s\"", name)
}
exists, err := kc.ContextExists(name)
if err != nil {
return "", fmt.Errorf("failed to check context: %w", err)
}
if !exists {
return "", fmt.Errorf("no context exists with the name: \"%s\"", name)
} }
if err := kc.ModifyCurrentContext(name); err != nil { if err := kc.ModifyCurrentContext(name); err != nil {
return "", err return "", err
} }
if err := kc.Save(); err != nil { if err := kc.Save(); err != nil {
return "", fmt.Errorf("failed to save kubeconfig: %w", err) return "", errors.Wrap(err, "failed to save kubeconfig")
} }
if prev != name { if prev != name {
if err := writeLastContext(prevCtxFile, prev); err != nil { if err := writeLastContext(prevCtxFile, prev); err != nil {
return "", fmt.Errorf("failed to save previous context name: %w", err) return "", errors.Wrap(err, "failed to save previous context name")
} }
} }
return name, nil return name, nil
@@ -91,11 +82,11 @@ func switchContext(name string) (string, error) {
func swapContext() (string, error) { func swapContext() (string, error) {
prevCtxFile, err := kubectxPrevCtxFile() prevCtxFile, err := kubectxPrevCtxFile()
if err != nil { if err != nil {
return "", fmt.Errorf("failed to determine state file: %w", err) return "", errors.Wrap(err, "failed to determine state file")
} }
prev, err := readLastContext(prevCtxFile) prev, err := readLastContext(prevCtxFile)
if err != nil { if err != nil {
return "", fmt.Errorf("failed to read previous context file: %w", err) return "", errors.Wrap(err, "failed to read previous context file")
} }
if prev == "" { if prev == "" {
return "", errors.New("no previous context found") return "", errors.New("no previous context found")

View File

@@ -15,9 +15,10 @@
package main package main
import ( import (
"fmt"
"io" "io"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
"github.com/ahmetb/kubectx/internal/printer" "github.com/ahmetb/kubectx/internal/printer"
) )
@@ -32,19 +33,16 @@ func (_ UnsetOp) Run(_, stderr io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
if err := kc.UnsetCurrentContext(); err != nil { if err := kc.UnsetCurrentContext(); err != nil {
return fmt.Errorf("error while modifying current-context: %w", err) return errors.Wrap(err, "error while modifying current-context")
} }
if err := kc.Save(); err != nil { if err := kc.Save(); err != nil {
return fmt.Errorf("failed to save kubeconfig file after modification: %w", err) return errors.Wrap(err, "failed to save kubeconfig file after modification")
} }
err := printer.Success(stderr, "Active context unset for kubectl.") err := printer.Success(stderr, "Active context unset for kubectl.")
if err != nil { return errors.Wrap(err, "write error")
return fmt.Errorf("write error: %w", err)
}
return nil
} }

View File

@@ -3,6 +3,8 @@ package main
import ( import (
"fmt" "fmt"
"io" "io"
"github.com/pkg/errors"
) )
var ( var (
@@ -14,8 +16,5 @@ type VersionOp struct{}
func (_ VersionOp) Run(stdout, _ io.Writer) error { func (_ VersionOp) Run(stdout, _ io.Writer) error {
_, err := fmt.Fprintf(stdout, "%s\n", version) _, err := fmt.Fprintf(stdout, "%s\n", version)
if err != nil { return errors.Wrap(err, "write error")
return fmt.Errorf("write error: %w", err)
}
return nil
} }

View File

@@ -15,10 +15,11 @@
package main package main
import ( import (
"errors"
"fmt" "fmt"
"io" "io"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
) )
@@ -28,23 +29,17 @@ func (c CurrentOp) Run(stdout, _ io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
ctx, err := kc.GetCurrentContext() ctx := kc.GetCurrentContext()
if err != nil {
return fmt.Errorf("failed to get current context: %w", err)
}
if ctx == "" { if ctx == "" {
return errors.New("current-context is not set") return errors.New("current-context is not set")
} }
ns, err := kc.NamespaceOfContext(ctx) ns, err := kc.NamespaceOfContext(ctx)
if err != nil { if err != nil {
return fmt.Errorf("failed to read namespace of \"%s\": %w", ctx, err) return errors.Wrapf(err, "failed to read namespace of \"%s\"", ctx)
} }
_, err = fmt.Fprintln(stdout, ns) _, err = fmt.Fprintln(stdout, ns)
if err != nil { return errors.Wrap(err, "write error")
return fmt.Errorf("write error: %w", err)
}
return nil
} }

View File

@@ -16,13 +16,14 @@ package main
import ( import (
"bytes" "bytes"
"errors"
"fmt" "fmt"
"io" "io"
"os" "os"
"os/exec" "os/exec"
"strings" "strings"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/cmdutil" "github.com/ahmetb/kubectx/internal/cmdutil"
"github.com/ahmetb/kubectx/internal/env" "github.com/ahmetb/kubectx/internal/env"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
@@ -37,22 +38,14 @@ type InteractiveSwitchOp struct {
func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error { func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
// parse kubeconfig just to see if it can be loaded // parse kubeconfig just to see if it can be loaded
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
if cmdutil.IsNotFoundErr(err) { if cmdutil.IsNotFoundErr(err) {
printer.Warning(stderr, "kubeconfig file not found") printer.Warning(stderr, "kubeconfig file not found")
return nil return nil
} }
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
}
ctxNames, err := kc.ContextNames()
if err != nil {
return fmt.Errorf("failed to get context names: %w", err)
}
if len(ctxNames) == 0 {
return errors.New("no contexts found in the kubeconfig file")
} }
defer kc.Close()
cmd := exec.Command("fzf", "--ansi", "--no-preview") cmd := exec.Command("fzf", "--ansi", "--no-preview")
var out bytes.Buffer var out bytes.Buffer
@@ -64,8 +57,7 @@ func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
fmt.Sprintf("FZF_DEFAULT_COMMAND=%s", op.SelfCmd), fmt.Sprintf("FZF_DEFAULT_COMMAND=%s", op.SelfCmd),
fmt.Sprintf("%s=1", env.EnvForceColor)) fmt.Sprintf("%s=1", env.EnvForceColor))
if err := cmd.Run(); err != nil { if err := cmd.Run(); err != nil {
var exitErr *exec.ExitError if _, ok := err.(*exec.ExitError); !ok {
if !errors.As(err, &exitErr) {
return err return err
} }
} }
@@ -75,8 +67,8 @@ func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
} }
name, err := switchNamespace(kc, choice, false) name, err := switchNamespace(kc, choice, false)
if err != nil { if err != nil {
return fmt.Errorf("failed to switch namespace: %w", err) return errors.Wrap(err, "failed to switch namespace")
} }
_ = printer.Success(stderr, "Active namespace is \"%s\".", printer.SuccessColor.Sprint(name)) printer.Success(stderr, "Active namespace is \"%s\".", printer.SuccessColor.Sprint(name))
return nil return nil
} }

View File

@@ -20,6 +20,8 @@ import (
"os" "os"
"path/filepath" "path/filepath"
"strings" "strings"
"github.com/pkg/errors"
) )
// HelpOp describes printing help. // HelpOp describes printing help.
@@ -44,10 +46,7 @@ func printUsage(out io.Writer) error {
help = strings.ReplaceAll(help, "%PROG%", selfName()) help = strings.ReplaceAll(help, "%PROG%", selfName())
_, err := fmt.Fprintf(out, "%s\n", help) _, err := fmt.Fprintf(out, "%s\n", help)
if err != nil { return errors.Wrap(err, "write error")
return fmt.Errorf("write error: %w", err)
}
return nil
} }
// selfName guesses how the user invoked the program. // selfName guesses how the user invoked the program.

View File

@@ -16,12 +16,11 @@ package main
import ( import (
"context" "context"
"errors"
"fmt" "fmt"
"io" "io"
"os" "os"
"slices"
"github.com/pkg/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes" "k8s.io/client-go/kubernetes"
_ "k8s.io/client-go/plugin/pkg/client/auth" _ "k8s.io/client-go/plugin/pkg/client/auth"
@@ -37,24 +36,21 @@ func (op ListOp) Run(stdout, stderr io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
ctx, err := kc.GetCurrentContext() ctx := kc.GetCurrentContext()
if err != nil {
return fmt.Errorf("failed to get current context: %w", err)
}
if ctx == "" { if ctx == "" {
return errors.New("current-context is not set") return errors.New("current-context is not set")
} }
curNs, err := kc.NamespaceOfContext(ctx) curNs, err := kc.NamespaceOfContext(ctx)
if err != nil { if err != nil {
return fmt.Errorf("cannot read current namespace: %w", err) return errors.Wrap(err, "cannot read current namespace")
} }
ns, err := queryNamespaces(kc) ns, err := queryNamespaces(kc)
if err != nil { if err != nil {
return fmt.Errorf("could not list namespaces (is the cluster accessible?): %w", err) return errors.Wrap(err, "could not list namespaces (is the cluster accessible?)")
} }
for _, c := range ns { for _, c := range ns {
@@ -74,7 +70,7 @@ func queryNamespaces(kc *kubeconfig.Kubeconfig) ([]string, error) {
clientset, err := newKubernetesClientSet(kc) clientset, err := newKubernetesClientSet(kc)
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to initialize k8s REST client: %w", err) return nil, errors.Wrap(err, "failed to initialize k8s REST client")
} }
var out []string var out []string
@@ -87,10 +83,9 @@ func queryNamespaces(kc *kubeconfig.Kubeconfig) ([]string, error) {
Continue: next, Continue: next,
}) })
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to list namespaces from k8s API: %w", err) return nil, errors.Wrap(err, "failed to list namespaces from k8s API")
} }
next = list.Continue next = list.Continue
out = slices.Grow(out, len(list.Items))
for _, it := range list.Items { for _, it := range list.Items {
out = append(out, it.Name) out = append(out, it.Name)
} }
@@ -104,11 +99,11 @@ func queryNamespaces(kc *kubeconfig.Kubeconfig) ([]string, error) {
func newKubernetesClientSet(kc *kubeconfig.Kubeconfig) (*kubernetes.Clientset, error) { func newKubernetesClientSet(kc *kubeconfig.Kubeconfig) (*kubernetes.Clientset, error) {
b, err := kc.Bytes() b, err := kc.Bytes()
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to convert in-memory kubeconfig to yaml: %w", err) return nil, errors.Wrap(err, "failed to convert in-memory kubeconfig to yaml")
} }
cfg, err := clientcmd.RESTConfigFromKubeConfig(b) cfg, err := clientcmd.RESTConfigFromKubeConfig(b)
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to initialize config: %w", err) return nil, errors.Wrap(err, "failed to initialize config")
} }
return kubernetes.NewForConfig(cfg) return kubernetes.NewForConfig(cfg)
} }

View File

@@ -33,7 +33,7 @@ func main() {
cmdutil.PrintDeprecatedEnvWarnings(color.Error, os.Environ()) cmdutil.PrintDeprecatedEnvWarnings(color.Error, os.Environ())
op := parseArgs(os.Args[1:]) op := parseArgs(os.Args[1:])
if err := op.Run(color.Output, color.Error); err != nil { if err := op.Run(color.Output, color.Error); err != nil {
printer.Error(color.Error, "%s", err) printer.Error(color.Error, err.Error())
if _, ok := os.LookupEnv(env.EnvDebug); ok { if _, ok := os.LookupEnv(env.EnvDebug); ok {
// print stack trace in verbose mode // print stack trace in verbose mode

View File

@@ -16,6 +16,7 @@ package main
import ( import (
"bytes" "bytes"
"io/ioutil"
"os" "os"
"path/filepath" "path/filepath"
"runtime" "runtime"
@@ -24,7 +25,7 @@ import (
"github.com/ahmetb/kubectx/internal/cmdutil" "github.com/ahmetb/kubectx/internal/cmdutil"
) )
var defaultDir = filepath.Join(cmdutil.CacheDir(), "kubens") var defaultDir = filepath.Join(cmdutil.HomeDir(), ".kube", "kubens")
type NSFile struct { type NSFile struct {
dir string dir string
@@ -44,7 +45,7 @@ func (f NSFile) path() string {
// Load reads the previous namespace setting, or returns empty if not exists. // Load reads the previous namespace setting, or returns empty if not exists.
func (f NSFile) Load() (string, error) { func (f NSFile) Load() (string, error) {
b, err := os.ReadFile(f.path()) b, err := ioutil.ReadFile(f.path())
if err != nil { if err != nil {
if os.IsNotExist(err) { if os.IsNotExist(err) {
return "", nil return "", nil
@@ -60,7 +61,7 @@ func (f NSFile) Save(value string) error {
if err := os.MkdirAll(d, 0755); err != nil { if err := os.MkdirAll(d, 0755); err != nil {
return err return err
} }
return os.WriteFile(f.path(), []byte(value), 0644) return ioutil.WriteFile(f.path(), []byte(value), 0644)
} }
// isWindows determines if the process is running on windows OS. // isWindows determines if the process is running on windows OS.

View File

@@ -15,13 +15,21 @@
package main package main
import ( import (
"io/ioutil"
"os"
"runtime" "runtime"
"strings" "strings"
"testing" "testing"
"github.com/ahmetb/kubectx/internal/testutil"
) )
func TestNSFile(t *testing.T) { func TestNSFile(t *testing.T) {
td := t.TempDir() td, err := ioutil.TempDir(os.TempDir(), "")
if err != nil {
t.Fatal(err)
}
defer os.RemoveAll(td)
f := NewNSFile("foo") f := NewNSFile("foo")
f.dir = td f.dir = td
@@ -48,7 +56,7 @@ func TestNSFile(t *testing.T) {
} }
func TestNSFile_path_windows(t *testing.T) { func TestNSFile_path_windows(t *testing.T) {
t.Setenv("_FORCE_GOOS", "windows") defer testutil.WithEnvVar("_FORCE_GOOS", "windows")()
fp := NewNSFile("a:b:c").path() fp := NewNSFile("a:b:c").path()
if expected := "a__b__c"; !strings.HasSuffix(fp, expected) { if expected := "a__b__c"; !strings.HasSuffix(fp, expected) {
@@ -66,7 +74,7 @@ func Test_isWindows(t *testing.T) {
t.Fatalf("isWindows() returned true for %s", runtime.GOOS) t.Fatalf("isWindows() returned true for %s", runtime.GOOS)
} }
t.Setenv("_FORCE_GOOS", "windows") defer testutil.WithEnvVar("_FORCE_GOOS", "windows")()
if !isWindows() { if !isWindows() {
t.Fatalf("isWindows() failed to detect windows with env override.") t.Fatalf("isWindows() failed to detect windows with env override.")
} }

View File

@@ -16,11 +16,10 @@ package main
import ( import (
"context" "context"
"errors"
"fmt"
"io" "io"
"os" "os"
"github.com/pkg/errors"
errors2 "k8s.io/apimachinery/pkg/api/errors" errors2 "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -37,7 +36,7 @@ func (s SwitchOp) Run(_, stderr io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
toNS, err := switchNamespace(kc, s.Target, s.Force) toNS, err := switchNamespace(kc, s.Target, s.Force)
@@ -49,27 +48,24 @@ func (s SwitchOp) Run(_, stderr io.Writer) error {
} }
func switchNamespace(kc *kubeconfig.Kubeconfig, ns string, force bool) (string, error) { func switchNamespace(kc *kubeconfig.Kubeconfig, ns string, force bool) (string, error) {
ctx, err := kc.GetCurrentContext() ctx := kc.GetCurrentContext()
if err != nil {
return "", fmt.Errorf("failed to get current context: %w", err)
}
if ctx == "" { if ctx == "" {
return "", errors.New("current-context is not set") return "", errors.New("current-context is not set")
} }
curNS, err := kc.NamespaceOfContext(ctx) curNS, err := kc.NamespaceOfContext(ctx)
if err != nil { if err != nil {
return "", fmt.Errorf("failed to get current namespace: %w", err) return "", errors.Wrap(err, "failed to get current namespace")
} }
f := NewNSFile(ctx) f := NewNSFile(ctx)
prev, err := f.Load() prev, err := f.Load()
if err != nil { if err != nil {
return "", fmt.Errorf("failed to load previous namespace from file: %w", err) return "", errors.Wrap(err, "failed to load previous namespace from file")
} }
if ns == "-" { if ns == "-" {
if prev == "" { if prev == "" {
return "", fmt.Errorf("No previous namespace found for current context (%s)", ctx) return "", errors.Errorf("No previous namespace found for current context (%s)", ctx)
} }
ns = prev ns = prev
} }
@@ -77,22 +73,22 @@ func switchNamespace(kc *kubeconfig.Kubeconfig, ns string, force bool) (string,
if !force { if !force {
ok, err := namespaceExists(kc, ns) ok, err := namespaceExists(kc, ns)
if err != nil { if err != nil {
return "", fmt.Errorf("failed to query if namespace exists (is cluster accessible?): %w", err) return "", errors.Wrap(err, "failed to query if namespace exists (is cluster accessible?)")
} }
if !ok { if !ok {
return "", fmt.Errorf("no namespace exists with name \"%s\"", ns) return "", errors.Errorf("no namespace exists with name \"%s\"", ns)
} }
} }
if err := kc.SetNamespace(ctx, ns); err != nil { if err := kc.SetNamespace(ctx, ns); err != nil {
return "", fmt.Errorf("failed to change to namespace \"%s\": %w", ns, err) return "", errors.Wrapf(err, "failed to change to namespace \"%s\"", ns)
} }
if err := kc.Save(); err != nil { if err := kc.Save(); err != nil {
return "", fmt.Errorf("failed to save kubeconfig file: %w", err) return "", errors.Wrap(err, "failed to save kubeconfig file")
} }
if curNS != ns { if curNS != ns {
if err := f.Save(curNS); err != nil { if err := f.Save(curNS); err != nil {
return "", fmt.Errorf("failed to save the previous namespace to file: %w", err) return "", errors.Wrap(err, "failed to save the previous namespace to file")
} }
} }
return ns, nil return ns, nil
@@ -106,15 +102,13 @@ func namespaceExists(kc *kubeconfig.Kubeconfig, ns string) (bool, error) {
clientset, err := newKubernetesClientSet(kc) clientset, err := newKubernetesClientSet(kc)
if err != nil { if err != nil {
return false, fmt.Errorf("failed to initialize k8s REST client: %w", err) return false, errors.Wrap(err, "failed to initialize k8s REST client")
} }
namespace, err := clientset.CoreV1().Namespaces().Get(context.Background(), ns, metav1.GetOptions{}) namespace, err := clientset.CoreV1().Namespaces().Get(context.Background(), ns, metav1.GetOptions{})
if errors2.IsNotFound(err) { if errors2.IsNotFound(err) {
return false, nil return false, nil
} }
if err != nil { return namespace != nil, errors.Wrapf(err, "failed to query "+
return false, fmt.Errorf("failed to query namespace %q from k8s API: %w", ns, err) "namespace %q from k8s API", ns)
}
return namespace != nil, nil
} }

View File

@@ -15,10 +15,10 @@
package main package main
import ( import (
"errors"
"fmt"
"io" "io"
"github.com/pkg/errors"
"github.com/ahmetb/kubectx/internal/kubeconfig" "github.com/ahmetb/kubectx/internal/kubeconfig"
"github.com/ahmetb/kubectx/internal/printer" "github.com/ahmetb/kubectx/internal/printer"
) )
@@ -30,7 +30,7 @@ func (_ UnsetOp) Run(_, stderr io.Writer) error {
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader) kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
defer kc.Close() defer kc.Close()
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
return fmt.Errorf("kubeconfig error: %w", err) return errors.Wrap(err, "kubeconfig error")
} }
ns, err := clearNamespace(kc) ns, err := clearNamespace(kc)
@@ -42,20 +42,17 @@ func (_ UnsetOp) Run(_, stderr io.Writer) error {
} }
func clearNamespace(kc *kubeconfig.Kubeconfig) (string, error) { func clearNamespace(kc *kubeconfig.Kubeconfig) (string, error) {
ctx, err := kc.GetCurrentContext() ctx := kc.GetCurrentContext()
if err != nil {
return "", fmt.Errorf("failed to get current context: %w", err)
}
ns := "default" ns := "default"
if ctx == "" { if ctx == "" {
return "", errors.New("current-context is not set") return "", errors.New("current-context is not set")
} }
if err := kc.SetNamespace(ctx, ns); err != nil { if err := kc.SetNamespace(ctx, ns); err != nil {
return "", fmt.Errorf("failed to clear namespace: %w", err) return "", errors.Wrapf(err, "failed to clear namespace")
} }
if err := kc.Save(); err != nil { if err := kc.Save(); err != nil {
return "", fmt.Errorf("failed to save kubeconfig file: %w", err) return "", errors.Wrap(err, "failed to save kubeconfig file")
} }
return ns, nil return ns, nil
} }

View File

@@ -3,6 +3,8 @@ package main
import ( import (
"fmt" "fmt"
"io" "io"
"github.com/pkg/errors"
) )
var ( var (
@@ -14,8 +16,5 @@ type VersionOp struct{}
func (_ VersionOp) Run(stdout, _ io.Writer) error { func (_ VersionOp) Run(stdout, _ io.Writer) error {
_, err := fmt.Fprintf(stdout, "%s\n", version) _, err := fmt.Fprintf(stdout, "%s\n", version)
if err != nil { return errors.Wrap(err, "write error")
return fmt.Errorf("write error: %w", err)
}
return nil
} }

1
go.mod
View File

@@ -7,6 +7,7 @@ require (
github.com/fatih/color v1.18.0 github.com/fatih/color v1.18.0
github.com/google/go-cmp v0.7.0 github.com/google/go-cmp v0.7.0
github.com/mattn/go-isatty v0.0.20 github.com/mattn/go-isatty v0.0.20
github.com/pkg/errors v0.9.1
k8s.io/apimachinery v0.35.2 k8s.io/apimachinery v0.35.2
k8s.io/client-go v0.35.2 k8s.io/client-go v0.35.2
sigs.k8s.io/kustomize/kyaml v0.21.1 sigs.k8s.io/kustomize/kyaml v0.21.1

2
go.sum
View File

@@ -65,6 +65,8 @@ github.com/onsi/ginkgo/v2 v2.27.2 h1:LzwLj0b89qtIy6SSASkzlNvX6WktqurSHwkk2ipF/Ns
github.com/onsi/ginkgo/v2 v2.27.2/go.mod h1:ArE1D/XhNXBXCBkKOLkbsb2c81dQHCRcF5zwn/ykDRo= github.com/onsi/ginkgo/v2 v2.27.2/go.mod h1:ArE1D/XhNXBXCBkKOLkbsb2c81dQHCRcF5zwn/ykDRo=
github.com/onsi/gomega v1.38.2 h1:eZCjf2xjZAqe+LeWvKb5weQ+NcPwX84kqJ0cZNxok2A= github.com/onsi/gomega v1.38.2 h1:eZCjf2xjZAqe+LeWvKb5weQ+NcPwX84kqJ0cZNxok2A=
github.com/onsi/gomega v1.38.2/go.mod h1:W2MJcYxRGV63b418Ai34Ud0hEdTVXq9NW9+Sx6uXf3k= github.com/onsi/gomega v1.38.2/go.mod h1:W2MJcYxRGV63b418Ai34Ud0hEdTVXq9NW9+Sx6uXf3k=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ= github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=

View File

@@ -15,9 +15,9 @@
package cmdutil package cmdutil
import ( import (
"errors"
"os" "os"
"path/filepath"
"github.com/pkg/errors"
) )
func HomeDir() string { func HomeDir() string {
@@ -28,20 +28,8 @@ func HomeDir() string {
return home return home
} }
// CacheDir returns XDG_CACHE_HOME if set, otherwise $HOME/.kube, // IsNotFoundErr determines if the underlying error is os.IsNotExist. Right now
// matching the bash scripts' behavior: ${XDG_CACHE_HOME:-$HOME/.kube}. // errors from github.com/pkg/errors doesn't work with os.IsNotExist.
func CacheDir() string {
if xdg := os.Getenv("XDG_CACHE_HOME"); xdg != "" {
return xdg
}
home := HomeDir()
if home == "" {
return ""
}
return filepath.Join(home, ".kube")
}
// IsNotFoundErr determines if the underlying error is os.IsNotExist.
func IsNotFoundErr(err error) bool { func IsNotFoundErr(err error) bool {
for e := err; e != nil; e = errors.Unwrap(e) { for e := err; e != nil; e = errors.Unwrap(e) {
if os.IsNotExist(e) { if os.IsNotExist(e) {

View File

@@ -15,8 +15,9 @@
package cmdutil package cmdutil
import ( import (
"path/filepath"
"testing" "testing"
"github.com/ahmetb/kubectx/internal/testutil"
) )
func Test_homeDir(t *testing.T) { func Test_homeDir(t *testing.T) {
@@ -62,40 +63,18 @@ func Test_homeDir(t *testing.T) {
for _, c := range cases { for _, c := range cases {
t.Run(c.name, func(tt *testing.T) { t.Run(c.name, func(tt *testing.T) {
var unsets []func()
for _, e := range c.envs { for _, e := range c.envs {
tt.Setenv(e.k, e.v) unsets = append(unsets, testutil.WithEnvVar(e.k, e.v))
} }
got := HomeDir() got := HomeDir()
if got != c.want { if got != c.want {
t.Errorf("expected:%q got:%q", c.want, got) t.Errorf("expected:%q got:%q", c.want, got)
} }
for _, u := range unsets {
u()
}
}) })
} }
} }
func TestCacheDir(t *testing.T) {
t.Run("XDG_CACHE_HOME set", func(t *testing.T) {
t.Setenv("XDG_CACHE_HOME", "/tmp/xdg-cache")
t.Setenv("HOME", "/home/user")
if got := CacheDir(); got != "/tmp/xdg-cache" {
t.Errorf("expected:%q got:%q", "/tmp/xdg-cache", got)
}
})
t.Run("XDG_CACHE_HOME unset, falls back to HOME/.kube", func(t *testing.T) {
t.Setenv("XDG_CACHE_HOME", "")
t.Setenv("HOME", "/home/user")
want := filepath.Join("/home/user", ".kube")
if got := CacheDir(); got != want {
t.Errorf("expected:%q got:%q", want, got)
}
})
t.Run("neither set", func(t *testing.T) {
t.Setenv("XDG_CACHE_HOME", "")
t.Setenv("HOME", "")
t.Setenv("USERPROFILE", "")
if got := CacheDir(); got != "" {
t.Errorf("expected:%q got:%q", "", got)
}
})
}

View File

@@ -15,10 +15,7 @@
package kubeconfig package kubeconfig
import ( import (
"errors" "github.com/pkg/errors"
"fmt"
"slices"
"sigs.k8s.io/kustomize/kyaml/yaml" "sigs.k8s.io/kustomize/kyaml/yaml"
) )
@@ -45,30 +42,29 @@ func (k *Kubeconfig) contextNode(name string) (*yaml.RNode, error) {
return nil, err return nil, err
} }
if context == nil { if context == nil {
return nil, fmt.Errorf("context with name \"%s\" not found", name) return nil, errors.Errorf("context with name \"%s\" not found", name)
} }
return context, nil return context, nil
} }
func (k *Kubeconfig) ContextNames() ([]string, error) { func (k *Kubeconfig) ContextNames() []string {
contexts, err := k.config.Pipe(yaml.Get("contexts")) contexts, err := k.config.Pipe(yaml.Get("contexts"))
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to get contexts: %w", err) return nil
}
if contexts == nil {
return nil, nil
} }
names, err := contexts.ElementValues("name") names, err := contexts.ElementValues("name")
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to get context names: %w", err) return nil
} }
return names, nil return names
} }
func (k *Kubeconfig) ContextExists(name string) (bool, error) { func (k *Kubeconfig) ContextExists(name string) bool {
names, err := k.ContextNames() ctxNames := k.ContextNames()
if err != nil { for _, v := range ctxNames {
return false, err if v == name {
return true
}
} }
return slices.Contains(names, name), nil return false
} }

View File

@@ -33,10 +33,7 @@ func TestKubeconfig_ContextNames(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
ctx, err := kc.ContextNames() ctx := kc.ContextNames()
if err != nil {
t.Fatal(err)
}
expected := []string{"abc", "def", "ghi"} expected := []string{"abc", "def", "ghi"}
if diff := cmp.Diff(expected, ctx); diff != "" { if diff := cmp.Diff(expected, ctx); diff != "" {
t.Fatalf("%s", diff) t.Fatalf("%s", diff)
@@ -49,10 +46,7 @@ func TestKubeconfig_ContextNames_noContextsEntry(t *testing.T) {
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
t.Fatal(err) t.Fatal(err)
} }
ctx, err := kc.ContextNames() ctx := kc.ContextNames()
if err != nil {
t.Fatal(err)
}
var expected []string = nil var expected []string = nil
if diff := cmp.Diff(expected, ctx); diff != "" { if diff := cmp.Diff(expected, ctx); diff != "" {
t.Fatalf("%s", diff) t.Fatalf("%s", diff)
@@ -65,9 +59,10 @@ func TestKubeconfig_ContextNames_nonArrayContextsEntry(t *testing.T) {
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
t.Fatal(err) t.Fatal(err)
} }
_, err := kc.ContextNames() ctx := kc.ContextNames()
if err == nil { var expected []string = nil
t.Fatal("expected error for non-array contexts entry") if diff := cmp.Diff(expected, ctx); diff != "" {
t.Fatalf("%s", diff)
} }
} }
@@ -82,15 +77,13 @@ func TestKubeconfig_CheckContextExists(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
if exists, err := kc.ContextExists("c1"); err != nil || !exists { if !kc.ContextExists("c1") {
t.Fatal("c1 actually exists; reported false") t.Fatal("c1 actually exists; reported false")
} }
if exists, err := kc.ContextExists("c2"); err != nil || !exists { if !kc.ContextExists("c2") {
t.Fatal("c2 actually exists; reported false") t.Fatal("c2 actually exists; reported false")
} }
if exists, err := kc.ContextExists("c3"); err != nil { if kc.ContextExists("c3") {
t.Fatal(err)
} else if exists {
t.Fatal("c3 does not exist; but reported true") t.Fatal("c3 does not exist; but reported true")
} }
} }

View File

@@ -15,19 +15,17 @@
package kubeconfig package kubeconfig
import ( import (
"fmt"
"sigs.k8s.io/kustomize/kyaml/yaml" "sigs.k8s.io/kustomize/kyaml/yaml"
) )
// GetCurrentContext returns "current-context" value in given // GetCurrentContext returns "current-context" value in given
// kubeconfig object Node, or returns ("", nil) if not found. // kubeconfig object Node, or returns "" if not found.
func (k *Kubeconfig) GetCurrentContext() (string, error) { func (k *Kubeconfig) GetCurrentContext() string {
v, err := k.config.Pipe(yaml.Get("current-context")) v, err := k.config.Pipe(yaml.Get("current-context"))
if err != nil { if err != nil {
return "", fmt.Errorf("failed to read current-context: %w", err) return ""
} }
return yaml.GetValue(v), nil return yaml.GetValue(v)
} }
func (k *Kubeconfig) UnsetCurrentContext() error { func (k *Kubeconfig) UnsetCurrentContext() error {

View File

@@ -26,10 +26,7 @@ func TestKubeconfig_GetCurrentContext(t *testing.T) {
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
t.Fatal(err) t.Fatal(err)
} }
v, err := kc.GetCurrentContext() v := kc.GetCurrentContext()
if err != nil {
t.Fatal(err)
}
expected := "foo" expected := "foo"
if v != expected { if v != expected {
@@ -43,10 +40,7 @@ func TestKubeconfig_GetCurrentContext_missingField(t *testing.T) {
if err := kc.Parse(); err != nil { if err := kc.Parse(); err != nil {
t.Fatal(err) t.Fatal(err)
} }
v, err := kc.GetCurrentContext() v := kc.GetCurrentContext()
if err != nil {
t.Fatal(err)
}
expected := "" expected := ""
if v != expected { if v != expected {

View File

@@ -15,10 +15,9 @@
package kubeconfig package kubeconfig
import ( import (
"errors"
"fmt"
"io" "io"
"github.com/pkg/errors"
"sigs.k8s.io/kustomize/kyaml/yaml" "sigs.k8s.io/kustomize/kyaml/yaml"
) )
@@ -55,7 +54,7 @@ func (k *Kubeconfig) Close() error {
func (k *Kubeconfig) Parse() error { func (k *Kubeconfig) Parse() error {
files, err := k.loader.Load() files, err := k.loader.Load()
if err != nil { if err != nil {
return fmt.Errorf("failed to load: %w", err) return errors.Wrap(err, "failed to load")
} }
// TODO since we don't support multiple kubeconfig files at the moment, there's just 1 file // TODO since we don't support multiple kubeconfig files at the moment, there's just 1 file
@@ -64,7 +63,7 @@ func (k *Kubeconfig) Parse() error {
k.f = f k.f = f
var v yaml.Node var v yaml.Node
if err := yaml.NewDecoder(f).Decode(&v); err != nil { if err := yaml.NewDecoder(f).Decode(&v); err != nil {
return fmt.Errorf("failed to decode: %w", err) return errors.Wrap(err, "failed to decode")
} }
k.config = yaml.NewRNode(&v) k.config = yaml.NewRNode(&v)
if k.config.YNode().Kind != yaml.MappingNode { if k.config.YNode().Kind != yaml.MappingNode {
@@ -83,12 +82,9 @@ func (k *Kubeconfig) Bytes() ([]byte, error) {
func (k *Kubeconfig) Save() error { func (k *Kubeconfig) Save() error {
if err := k.f.Reset(); err != nil { if err := k.f.Reset(); err != nil {
return fmt.Errorf("failed to reset file: %w", err) return errors.Wrap(err, "failed to reset file")
} }
enc := yaml.NewEncoder(k.f) enc := yaml.NewEncoder(k.f)
enc.SetIndent(0) enc.SetIndent(0)
if err := enc.Encode(k.config.YNode()); err != nil { return enc.Encode(k.config.YNode())
return err
}
return enc.Close()
} }

View File

@@ -15,12 +15,11 @@
package kubeconfig package kubeconfig
import ( import (
"errors" "github.com/ahmetb/kubectx/internal/cmdutil"
"fmt"
"os" "os"
"path/filepath" "path/filepath"
"github.com/ahmetb/kubectx/internal/cmdutil" "github.com/pkg/errors"
) )
var ( var (
@@ -34,15 +33,15 @@ type kubeconfigFile struct{ *os.File }
func (*StandardKubeconfigLoader) Load() ([]ReadWriteResetCloser, error) { func (*StandardKubeconfigLoader) Load() ([]ReadWriteResetCloser, error) {
cfgPath, err := kubeconfigPath() cfgPath, err := kubeconfigPath()
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot determine kubeconfig path: %w", err) return nil, errors.Wrap(err, "cannot determine kubeconfig path")
} }
f, err := os.OpenFile(cfgPath, os.O_RDWR, 0) f, err := os.OpenFile(cfgPath, os.O_RDWR, 0)
if err != nil { if err != nil {
if os.IsNotExist(err) { if os.IsNotExist(err) {
return nil, fmt.Errorf("kubeconfig file not found: %w", err) return nil, errors.Wrap(err, "kubeconfig file not found")
} }
return nil, fmt.Errorf("failed to open file: %w", err) return nil, errors.Wrap(err, "failed to open file")
} }
// TODO we'll return all kubeconfig files when we start implementing multiple kubeconfig support // TODO we'll return all kubeconfig files when we start implementing multiple kubeconfig support
@@ -51,12 +50,10 @@ func (*StandardKubeconfigLoader) Load() ([]ReadWriteResetCloser, error) {
func (kf *kubeconfigFile) Reset() error { func (kf *kubeconfigFile) Reset() error {
if err := kf.Truncate(0); err != nil { if err := kf.Truncate(0); err != nil {
return fmt.Errorf("failed to truncate file: %w", err) return errors.Wrap(err, "failed to truncate file")
} }
if _, err := kf.Seek(0, 0); err != nil { _, err := kf.Seek(0, 0)
return fmt.Errorf("failed to seek in file: %w", err) return errors.Wrap(err, "failed to seek in file")
}
return nil
} }
func kubeconfigPath() (string, error) { func kubeconfigPath() (string, error) {

View File

@@ -15,16 +15,17 @@
package kubeconfig package kubeconfig
import ( import (
"github.com/ahmetb/kubectx/internal/cmdutil"
"os" "os"
"path/filepath" "path/filepath"
"strings" "strings"
"testing" "testing"
"github.com/ahmetb/kubectx/internal/cmdutil" "github.com/ahmetb/kubectx/internal/testutil"
) )
func Test_kubeconfigPath(t *testing.T) { func Test_kubeconfigPath(t *testing.T) {
t.Setenv("HOME", "/x/y/z") defer testutil.WithEnvVar("HOME", "/x/y/z")()
expected := filepath.FromSlash("/x/y/z/.kube/config") expected := filepath.FromSlash("/x/y/z/.kube/config")
got, err := kubeconfigPath() got, err := kubeconfigPath()
@@ -37,9 +38,9 @@ func Test_kubeconfigPath(t *testing.T) {
} }
func Test_kubeconfigPath_noEnvVars(t *testing.T) { func Test_kubeconfigPath_noEnvVars(t *testing.T) {
t.Setenv("XDG_CACHE_HOME", "") defer testutil.WithEnvVar("XDG_CACHE_HOME", "")()
t.Setenv("HOME", "") defer testutil.WithEnvVar("HOME", "")()
t.Setenv("USERPROFILE", "") defer testutil.WithEnvVar("USERPROFILE", "")()
_, err := kubeconfigPath() _, err := kubeconfigPath()
if err == nil { if err == nil {
@@ -48,7 +49,7 @@ func Test_kubeconfigPath_noEnvVars(t *testing.T) {
} }
func Test_kubeconfigPath_envOvveride(t *testing.T) { func Test_kubeconfigPath_envOvveride(t *testing.T) {
t.Setenv("KUBECONFIG", "foo") defer testutil.WithEnvVar("KUBECONFIG", "foo")()
v, err := kubeconfigPath() v, err := kubeconfigPath()
if err != nil { if err != nil {
@@ -61,7 +62,7 @@ func Test_kubeconfigPath_envOvveride(t *testing.T) {
func Test_kubeconfigPath_envOvverideDoesNotSupportPathSeparator(t *testing.T) { func Test_kubeconfigPath_envOvverideDoesNotSupportPathSeparator(t *testing.T) {
path := strings.Join([]string{"file1", "file2"}, string(os.PathListSeparator)) path := strings.Join([]string{"file1", "file2"}, string(os.PathListSeparator))
t.Setenv("KUBECONFIG", path) defer testutil.WithEnvVar("KUBECONFIG", path)()
_, err := kubeconfigPath() _, err := kubeconfigPath()
if err == nil { if err == nil {
@@ -70,7 +71,7 @@ func Test_kubeconfigPath_envOvverideDoesNotSupportPathSeparator(t *testing.T) {
} }
func TestStandardKubeconfigLoader_returnsNotFoundErr(t *testing.T) { func TestStandardKubeconfigLoader_returnsNotFoundErr(t *testing.T) {
t.Setenv("KUBECONFIG", "foo") defer testutil.WithEnvVar("KUBECONFIG", "foo")()
kc := new(Kubeconfig).WithLoader(DefaultLoader) kc := new(Kubeconfig).WithLoader(DefaultLoader)
err := kc.Parse() err := kc.Parse()
if err == nil { if err == nil {

View File

@@ -18,6 +18,8 @@ import (
"testing" "testing"
"github.com/google/go-cmp/cmp" "github.com/google/go-cmp/cmp"
"github.com/ahmetb/kubectx/internal/testutil"
) )
var ( var (
@@ -25,8 +27,8 @@ var (
) )
func Test_useColors_forceColors(t *testing.T) { func Test_useColors_forceColors(t *testing.T) {
t.Setenv("_KUBECTX_FORCE_COLOR", "1") defer testutil.WithEnvVar("_KUBECTX_FORCE_COLOR", "1")()
t.Setenv("NO_COLOR", "1") defer testutil.WithEnvVar("NO_COLOR", "1")()
if v := useColors(); !cmp.Equal(v, &tr) { if v := useColors(); !cmp.Equal(v, &tr) {
t.Fatalf("expected useColors() = true; got = %v", v) t.Fatalf("expected useColors() = true; got = %v", v)
@@ -34,7 +36,7 @@ func Test_useColors_forceColors(t *testing.T) {
} }
func Test_useColors_disableColors(t *testing.T) { func Test_useColors_disableColors(t *testing.T) {
t.Setenv("NO_COLOR", "1") defer testutil.WithEnvVar("NO_COLOR", "1")()
if v := useColors(); !cmp.Equal(v, &fa) { if v := useColors(); !cmp.Equal(v, &fa) {
t.Fatalf("expected useColors() = false; got = %v", v) t.Fatalf("expected useColors() = false; got = %v", v)
@@ -42,8 +44,8 @@ func Test_useColors_disableColors(t *testing.T) {
} }
func Test_useColors_default(t *testing.T) { func Test_useColors_default(t *testing.T) {
t.Setenv("NO_COLOR", "") defer testutil.WithEnvVar("NO_COLOR", "")()
t.Setenv("_KUBECTX_FORCE_COLOR", "") defer testutil.WithEnvVar("_KUBECTX_FORCE_COLOR", "")()
if v := useColors(); v != nil { if v := useColors(); v != nil {
t.Fatalf("expected useColors() = nil; got=%v", *v) t.Fatalf("expected useColors() = nil; got=%v", *v)

View File

@@ -43,17 +43,17 @@ func init() {
} }
} }
func Error(w io.Writer, format string, args ...any) error { func Error(w io.Writer, format string, args ...interface{}) error {
_, err := io.WriteString(w, ErrorColor.Sprint("error: ")+fmt.Sprintf(format, args...)+"\n") _, err := fmt.Fprintf(w, ErrorColor.Sprint("error: ")+format+"\n", args...)
return err return err
} }
func Warning(w io.Writer, format string, args ...any) error { func Warning(w io.Writer, format string, args ...interface{}) error {
_, err := io.WriteString(w, WarningColor.Sprint("warning: ")+fmt.Sprintf(format, args...)+"\n") _, err := fmt.Fprintf(w, WarningColor.Sprint("warning: ")+format+"\n", args...)
return err return err
} }
func Success(w io.Writer, format string, args ...any) error { func Success(w io.Writer, format string, args ...interface{}) error {
_, err := io.WriteString(w, SuccessColor.Sprint("✔ ")+fmt.Sprintf(format, args...)+"\n") _, err := fmt.Fprintf(w, SuccessColor.Sprint("✔ ")+fmt.Sprintf(format+"\n", args...))
return err return err
} }

View File

@@ -31,7 +31,7 @@ type Context struct {
func Ctx(name string) *Context { return &Context{Name: name} } func Ctx(name string) *Context { return &Context{Name: name} }
func (c *Context) Ns(ns string) *Context { c.Context.Namespace = ns; return c } func (c *Context) Ns(ns string) *Context { c.Context.Namespace = ns; return c }
type Kubeconfig map[string]any type Kubeconfig map[string]interface{}
func KC() *Kubeconfig { func KC() *Kubeconfig {
return &Kubeconfig{ return &Kubeconfig{
@@ -39,9 +39,9 @@ func KC() *Kubeconfig {
"kind": "Config"} "kind": "Config"}
} }
func (k *Kubeconfig) Set(key string, v any) *Kubeconfig { (*k)[key] = v; return k } func (k *Kubeconfig) Set(key string, v interface{}) *Kubeconfig { (*k)[key] = v; return k }
func (k *Kubeconfig) WithCurrentCtx(s string) *Kubeconfig { (*k)["current-context"] = s; return k } func (k *Kubeconfig) WithCurrentCtx(s string) *Kubeconfig { (*k)["current-context"] = s; return k }
func (k *Kubeconfig) WithCtxs(c ...*Context) *Kubeconfig { (*k)["contexts"] = c; return k } func (k *Kubeconfig) WithCtxs(c ...*Context) *Kubeconfig { (*k)["contexts"] = c; return k }
func (k *Kubeconfig) ToYAML(t *testing.T) string { func (k *Kubeconfig) ToYAML(t *testing.T) string {
t.Helper() t.Helper()

View File

@@ -0,0 +1,40 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package testutil
import (
"io/ioutil"
"os"
"testing"
)
func TempFile(t *testing.T, contents string) (path string, cleanup func()) {
// TODO consider removing, used only in one place.
t.Helper()
f, err := ioutil.TempFile(os.TempDir(), "test-file")
if err != nil {
t.Fatalf("failed to create test file: %v", err)
}
path = f.Name()
if _, err := f.Write([]byte(contents)); err != nil {
t.Fatalf("failed to write to test file: %v", err)
}
return path, func() {
f.Close()
os.Remove(path)
}
}

View File

@@ -0,0 +1,31 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package testutil
import "os"
// WithEnvVar sets an env var temporarily. Call its return value
// in defer to restore original value in env (if exists).
func WithEnvVar(key, value string) func() {
orig, ok := os.LookupEnv(key)
os.Setenv(key, value)
return func() {
if ok {
os.Setenv(key, orig)
} else {
os.Unsetenv(key)
}
}
}