mirror of
https://github.com/ahmetb/kubectx.git
synced 2026-03-18 11:52:24 +00:00
0d800e1367
This change addresses eight key improvements to the kubectx/kubens codebase: Resource Management Fixes: - Fix use-after-close bugs where Kubeconfig was accessed after Close() - Fix resource leaks on error paths by ensuring defer kc.Close() is called - Fix YAML encoder not being closed after Encode(), causing buffered data loss API Design Improvements: - Change ContextNames() to return ([]string, error) instead of silently returning nil on error, making parse failures distinguishable from empty results - Change GetCurrentContext() to return (string, error) instead of returning "" for both "not set" and parse error cases - Update all 16 call sites across cmd/kubectx and cmd/kubens packages to handle the new error returns while preserving backward-compatible behavior Error Handling: - Add explicit error handling for printer.Success() calls in 5+ locations by prefixing unchecked calls with _ = Performance: - Add slice pre-allocation in namespace list pagination using slices.Grow() before append loops, reducing allocations when fetching 500+ item batches All changes maintain backward compatibility for missing kubeconfig keys while improving error transparency and resource safety.
97 lines
2.5 KiB
Go
97 lines
2.5 KiB
Go
// Copyright 2021 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package kubeconfig
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
|
|
"github.com/ahmetb/kubectx/internal/testutil"
|
|
)
|
|
|
|
func TestKubeconfig_ContextNames(t *testing.T) {
|
|
tl := WithMockKubeconfigLoader(
|
|
testutil.KC().WithCtxs(
|
|
testutil.Ctx("abc"),
|
|
testutil.Ctx("def"),
|
|
testutil.Ctx("ghi")).Set("field1", map[string]string{"bar": "zoo"}).ToYAML(t))
|
|
kc := new(Kubeconfig).WithLoader(tl)
|
|
if err := kc.Parse(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
ctx, err := kc.ContextNames()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
expected := []string{"abc", "def", "ghi"}
|
|
if diff := cmp.Diff(expected, ctx); diff != "" {
|
|
t.Fatalf("%s", diff)
|
|
}
|
|
}
|
|
|
|
func TestKubeconfig_ContextNames_noContextsEntry(t *testing.T) {
|
|
tl := WithMockKubeconfigLoader(`a: b`)
|
|
kc := new(Kubeconfig).WithLoader(tl)
|
|
if err := kc.Parse(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ctx, err := kc.ContextNames()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var expected []string = nil
|
|
if diff := cmp.Diff(expected, ctx); diff != "" {
|
|
t.Fatalf("%s", diff)
|
|
}
|
|
}
|
|
|
|
func TestKubeconfig_ContextNames_nonArrayContextsEntry(t *testing.T) {
|
|
tl := WithMockKubeconfigLoader(`contexts: "hello"`)
|
|
kc := new(Kubeconfig).WithLoader(tl)
|
|
if err := kc.Parse(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
_, err := kc.ContextNames()
|
|
if err == nil {
|
|
t.Fatal("expected error for non-array contexts entry")
|
|
}
|
|
}
|
|
|
|
func TestKubeconfig_CheckContextExists(t *testing.T) {
|
|
tl := WithMockKubeconfigLoader(
|
|
testutil.KC().WithCtxs(
|
|
testutil.Ctx("c1"),
|
|
testutil.Ctx("c2")).ToYAML(t))
|
|
|
|
kc := new(Kubeconfig).WithLoader(tl)
|
|
if err := kc.Parse(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if exists, err := kc.ContextExists("c1"); err != nil || !exists {
|
|
t.Fatal("c1 actually exists; reported false")
|
|
}
|
|
if exists, err := kc.ContextExists("c2"); err != nil || !exists {
|
|
t.Fatal("c2 actually exists; reported false")
|
|
}
|
|
if exists, err := kc.ContextExists("c3"); err != nil {
|
|
t.Fatal(err)
|
|
} else if exists {
|
|
t.Fatal("c3 does not exist; but reported true")
|
|
}
|
|
}
|