mirror of
https://github.com/ahmetb/kubectx.git
synced 2026-05-14 19:12:07 +00:00
When kubens needs to query the Kubernetes API (e.g. to check if a namespace exists), it builds a REST client from the in-memory kubeconfig bytes using clientcmd.RESTConfigFromKubeConfig(). This function has no knowledge of the kubeconfig file's location on disk, so it cannot resolve relative paths in exec credential plugin commands (e.g. `command: ../scripts/get-token.sh`). This causes a "no such file or directory" error for users whose kubeconfig uses relative paths in exec-based authentication. The fix threads the kubeconfig file path through a new PathHinter optional interface on ReadWriteResetCloser. When a file path is available, newKubernetesClientSet now uses clientcmd.NewNonInteractiveDeferredLoadingClientConfig with ExplicitPath, which resolves relative paths relative to the kubeconfig file's directory — matching kubectl's own behavior. The old bytes-based fallback is preserved for in-memory configs (e.g. tests). Fixes #488 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
136 lines
3.7 KiB
Go
136 lines
3.7 KiB
Go
// Copyright 2021 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package main
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"slices"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/client-go/kubernetes"
|
|
_ "k8s.io/client-go/plugin/pkg/client/auth"
|
|
"k8s.io/client-go/rest"
|
|
"k8s.io/client-go/tools/clientcmd"
|
|
|
|
"github.com/ahmetb/kubectx/internal/kubeconfig"
|
|
"github.com/ahmetb/kubectx/internal/printer"
|
|
)
|
|
|
|
type ListOp struct{}
|
|
|
|
func (op ListOp) Run(stdout, stderr io.Writer) error {
|
|
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
|
|
defer kc.Close()
|
|
if err := kc.Parse(); err != nil {
|
|
return fmt.Errorf("kubeconfig error: %w", err)
|
|
}
|
|
|
|
ctx, err := kc.GetCurrentContext()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get current context: %w", err)
|
|
}
|
|
if ctx == "" {
|
|
return errors.New("current-context is not set")
|
|
}
|
|
curNs, err := kc.NamespaceOfContext(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("cannot read current namespace: %w", err)
|
|
}
|
|
|
|
ns, err := queryNamespaces(kc)
|
|
if err != nil {
|
|
return fmt.Errorf("could not list namespaces (is the cluster accessible?): %w", err)
|
|
}
|
|
|
|
for _, c := range ns {
|
|
s := c
|
|
if c == curNs {
|
|
s = printer.ActiveItemColor.Sprint(c)
|
|
}
|
|
fmt.Fprintf(stdout, "%s\n", s)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func queryNamespaces(kc *kubeconfig.Kubeconfig) ([]string, error) {
|
|
if os.Getenv("_MOCK_NAMESPACES") != "" {
|
|
return []string{"ns1", "ns2"}, nil
|
|
}
|
|
|
|
clientset, err := newKubernetesClientSet(kc)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to initialize k8s REST client: %w", err)
|
|
}
|
|
|
|
var out []string
|
|
var next string
|
|
for {
|
|
list, err := clientset.CoreV1().Namespaces().List(
|
|
context.Background(),
|
|
metav1.ListOptions{
|
|
Limit: 500,
|
|
Continue: next,
|
|
})
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to list namespaces from k8s API: %w", err)
|
|
}
|
|
next = list.Continue
|
|
out = slices.Grow(out, len(list.Items))
|
|
for _, it := range list.Items {
|
|
out = append(out, it.Name)
|
|
}
|
|
if next == "" {
|
|
break
|
|
}
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
func newKubernetesClientSet(kc *kubeconfig.Kubeconfig) (*kubernetes.Clientset, error) {
|
|
var cfg *rest.Config
|
|
var err error
|
|
|
|
if paths := kc.ConfigPaths(); len(paths) > 0 {
|
|
// Load from file paths so that client-go resolves relative paths
|
|
// (e.g. in exec credential plugins) relative to the kubeconfig directory.
|
|
//
|
|
// TODO: This re-reads and re-parses the kubeconfig files from disk via
|
|
// client-go, duplicating work already done by our kyaml-based loader.
|
|
// A better approach would be to extract the current context/cluster/user
|
|
// entries from the already-parsed multi-file kubeconfig and normalize
|
|
// relative paths in memory based on which file each entry was read from.
|
|
cfg, err = clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
|
|
&clientcmd.ClientConfigLoadingRules{Precedence: paths},
|
|
&clientcmd.ConfigOverrides{},
|
|
).ClientConfig()
|
|
} else {
|
|
// Fallback for in-memory configs (e.g. tests).
|
|
var b []byte
|
|
b, err = kc.Bytes()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to convert in-memory kubeconfig to yaml: %w", err)
|
|
}
|
|
cfg, err = clientcmd.RESTConfigFromKubeConfig(b)
|
|
}
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to initialize config: %w", err)
|
|
}
|
|
return kubernetes.NewForConfig(cfg)
|
|
}
|