mirror of
https://github.com/ahmetb/kubectx.git
synced 2026-05-17 04:45:50 +00:00
Previously, kubectx would error with "multiple files in KUBECONFIG are currently not supported" when KUBECONFIG contained colon-separated paths. This is a common setup where users maintain separate kubeconfig files for different clusters/environments. This change evolves the internal Kubeconfig struct from holding a single file to a slice of file entries, matching kubectl's merge semantics: - Reading current-context: first file with a non-empty value wins - Writing current-context: always written to the first file - Listing contexts: merged from all files, first occurrence wins for duplicate names - Modifying a context (delete/rename/set-namespace): written to the file that owns that context - Missing files in the KUBECONFIG list are silently skipped (matching kubectl behavior), but permission errors are propagated The Loader interface already returned []ReadWriteResetCloser, so all public method signatures remain unchanged — zero modifications needed in cmd/kubectx/ or cmd/kubens/ callers. Fixes #485 Fixes #211 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
150 lines
3.9 KiB
Go
150 lines
3.9 KiB
Go
// Copyright 2021 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package kubeconfig
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/ahmetb/kubectx/internal/cmdutil"
|
|
)
|
|
|
|
func Test_kubeconfigPaths_default(t *testing.T) {
|
|
t.Setenv("HOME", "/x/y/z")
|
|
|
|
expected := filepath.FromSlash("/x/y/z/.kube/config")
|
|
got, err := kubeconfigPaths()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(got) != 1 || got[0] != expected {
|
|
t.Fatalf("got=%q expected=[%q]", got, expected)
|
|
}
|
|
}
|
|
|
|
func Test_kubeconfigPaths_noEnvVars(t *testing.T) {
|
|
t.Setenv("XDG_CACHE_HOME", "")
|
|
t.Setenv("HOME", "")
|
|
t.Setenv("USERPROFILE", "")
|
|
|
|
_, err := kubeconfigPaths()
|
|
if err == nil {
|
|
t.Fatalf("expected error")
|
|
}
|
|
}
|
|
|
|
func Test_kubeconfigPaths_envSingleFile(t *testing.T) {
|
|
t.Setenv("KUBECONFIG", "foo")
|
|
|
|
v, err := kubeconfigPaths()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(v) != 1 || v[0] != "foo" {
|
|
t.Fatalf("expected=[\"foo\"], got=%q", v)
|
|
}
|
|
}
|
|
|
|
func Test_kubeconfigPaths_envMultipleFiles(t *testing.T) {
|
|
path := strings.Join([]string{"file1", "file2", "file3"}, string(os.PathListSeparator))
|
|
t.Setenv("KUBECONFIG", path)
|
|
|
|
v, err := kubeconfigPaths()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(v) != 3 || v[0] != "file1" || v[1] != "file2" || v[2] != "file3" {
|
|
t.Fatalf("expected=[file1,file2,file3], got=%q", v)
|
|
}
|
|
}
|
|
|
|
func TestStandardKubeconfigLoader_returnsNotFoundErr(t *testing.T) {
|
|
t.Setenv("KUBECONFIG", "foo")
|
|
kc := new(Kubeconfig).WithLoader(DefaultLoader)
|
|
err := kc.Parse()
|
|
if err == nil {
|
|
t.Fatal("expected err")
|
|
}
|
|
if !cmdutil.IsNotFoundErr(err) {
|
|
t.Fatalf("expected ENOENT error; got=%v", err)
|
|
}
|
|
}
|
|
|
|
func TestStandardKubeconfigLoader_multipleFiles_skipsMissing(t *testing.T) {
|
|
dir := t.TempDir()
|
|
existing := filepath.Join(dir, "config1")
|
|
if err := os.WriteFile(existing, []byte("apiVersion: v1\nkind: Config\ncontexts: []\n"), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
missing := filepath.Join(dir, "config2")
|
|
|
|
path := strings.Join([]string{existing, missing}, string(os.PathListSeparator))
|
|
t.Setenv("KUBECONFIG", path)
|
|
|
|
files, err := new(StandardKubeconfigLoader).Load()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(files) != 1 {
|
|
t.Fatalf("expected 1 file, got %d", len(files))
|
|
}
|
|
files[0].Close()
|
|
}
|
|
|
|
func TestStandardKubeconfigLoader_multipleFiles_allMissing(t *testing.T) {
|
|
dir := t.TempDir()
|
|
path := strings.Join([]string{
|
|
filepath.Join(dir, "missing1"),
|
|
filepath.Join(dir, "missing2"),
|
|
}, string(os.PathListSeparator))
|
|
t.Setenv("KUBECONFIG", path)
|
|
|
|
_, err := new(StandardKubeconfigLoader).Load()
|
|
if err == nil {
|
|
t.Fatal("expected error when all files missing")
|
|
}
|
|
if !cmdutil.IsNotFoundErr(err) {
|
|
t.Fatalf("expected ENOENT error; got=%v", err)
|
|
}
|
|
}
|
|
|
|
func TestStandardKubeconfigLoader_multipleFiles_loadsAll(t *testing.T) {
|
|
dir := t.TempDir()
|
|
f1 := filepath.Join(dir, "config1")
|
|
f2 := filepath.Join(dir, "config2")
|
|
if err := os.WriteFile(f1, []byte("apiVersion: v1\nkind: Config\ncontexts: []\n"), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(f2, []byte("apiVersion: v1\nkind: Config\ncontexts: []\n"), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
path := strings.Join([]string{f1, f2}, string(os.PathListSeparator))
|
|
t.Setenv("KUBECONFIG", path)
|
|
|
|
files, err := new(StandardKubeconfigLoader).Load()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(files) != 2 {
|
|
t.Fatalf("expected 2 files, got %d", len(files))
|
|
}
|
|
for _, f := range files {
|
|
f.Close()
|
|
}
|
|
}
|