mirror of
https://github.com/ahmetb/kubectx.git
synced 2026-03-16 19:02:14 +00:00
0d800e1367
This change addresses eight key improvements to the kubectx/kubens codebase: Resource Management Fixes: - Fix use-after-close bugs where Kubeconfig was accessed after Close() - Fix resource leaks on error paths by ensuring defer kc.Close() is called - Fix YAML encoder not being closed after Encode(), causing buffered data loss API Design Improvements: - Change ContextNames() to return ([]string, error) instead of silently returning nil on error, making parse failures distinguishable from empty results - Change GetCurrentContext() to return (string, error) instead of returning "" for both "not set" and parse error cases - Update all 16 call sites across cmd/kubectx and cmd/kubens packages to handle the new error returns while preserving backward-compatible behavior Error Handling: - Add explicit error handling for printer.Success() calls in 5+ locations by prefixing unchecked calls with _ = Performance: - Add slice pre-allocation in namespace list pagination using slices.Grow() before append loops, reducing allocations when fetching 500+ item batches All changes maintain backward compatibility for missing kubeconfig keys while improving error transparency and resource safety.
36 lines
1.1 KiB
Go
36 lines
1.1 KiB
Go
// Copyright 2021 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package kubeconfig
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"sigs.k8s.io/kustomize/kyaml/yaml"
|
|
)
|
|
|
|
// GetCurrentContext returns "current-context" value in given
|
|
// kubeconfig object Node, or returns ("", nil) if not found.
|
|
func (k *Kubeconfig) GetCurrentContext() (string, error) {
|
|
v, err := k.config.Pipe(yaml.Get("current-context"))
|
|
if err != nil {
|
|
return "", fmt.Errorf("failed to read current-context: %w", err)
|
|
}
|
|
return yaml.GetValue(v), nil
|
|
}
|
|
|
|
func (k *Kubeconfig) UnsetCurrentContext() error {
|
|
return k.config.PipeE(yaml.SetField("current-context", yaml.NewStringRNode("")))
|
|
}
|