mirror of
https://github.com/ahmetb/kubectx.git
synced 2026-03-18 03:42:12 +00:00
0d800e1367
This change addresses eight key improvements to the kubectx/kubens codebase: Resource Management Fixes: - Fix use-after-close bugs where Kubeconfig was accessed after Close() - Fix resource leaks on error paths by ensuring defer kc.Close() is called - Fix YAML encoder not being closed after Encode(), causing buffered data loss API Design Improvements: - Change ContextNames() to return ([]string, error) instead of silently returning nil on error, making parse failures distinguishable from empty results - Change GetCurrentContext() to return (string, error) instead of returning "" for both "not set" and parse error cases - Update all 16 call sites across cmd/kubectx and cmd/kubens packages to handle the new error returns while preserving backward-compatible behavior Error Handling: - Add explicit error handling for printer.Success() calls in 5+ locations by prefixing unchecked calls with _ = Performance: - Add slice pre-allocation in namespace list pagination using slices.Grow() before append loops, reducing allocations when fetching 500+ item batches All changes maintain backward compatibility for missing kubeconfig keys while improving error transparency and resource safety.
90 lines
2.7 KiB
Go
90 lines
2.7 KiB
Go
// Copyright 2021 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package main
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/ahmetb/kubectx/internal/kubeconfig"
|
|
"github.com/ahmetb/kubectx/internal/printer"
|
|
)
|
|
|
|
// DeleteOp indicates intention to delete contexts.
|
|
type DeleteOp struct {
|
|
Contexts []string // NAME or '.' to indicate current-context.
|
|
}
|
|
|
|
// deleteContexts deletes context entries one by one.
|
|
func (op DeleteOp) Run(_, stderr io.Writer) error {
|
|
if err := checkIsolatedMode(); err != nil {
|
|
return err
|
|
}
|
|
for _, ctx := range op.Contexts {
|
|
// TODO inefficiency here. we open/write/close the same file many times.
|
|
deletedName, wasActiveContext, err := deleteContext(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("error deleting context \"%s\": %w", deletedName, err)
|
|
}
|
|
if wasActiveContext {
|
|
printer.Warning(stderr, "You deleted the current context. Use \"%s\" to select a new context.",
|
|
selfName())
|
|
}
|
|
|
|
_ = printer.Success(stderr, `Deleted context %s.`, printer.SuccessColor.Sprint(deletedName))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// deleteContext deletes a context entry by NAME or current-context
|
|
// indicated by ".".
|
|
func deleteContext(name string) (deleteName string, wasActiveContext bool, err error) {
|
|
kc := new(kubeconfig.Kubeconfig).WithLoader(kubeconfig.DefaultLoader)
|
|
defer kc.Close()
|
|
if err := kc.Parse(); err != nil {
|
|
return deleteName, false, fmt.Errorf("kubeconfig error: %w", err)
|
|
}
|
|
|
|
cur, err := kc.GetCurrentContext()
|
|
if err != nil {
|
|
return deleteName, false, fmt.Errorf("failed to get current context: %w", err)
|
|
}
|
|
// resolve "." to a real name
|
|
if name == "." {
|
|
if cur == "" {
|
|
return deleteName, false, errors.New("can't use '.' as the no active context is set")
|
|
}
|
|
wasActiveContext = true
|
|
name = cur
|
|
}
|
|
|
|
exists, err := kc.ContextExists(name)
|
|
if err != nil {
|
|
return name, false, fmt.Errorf("failed to check context: %w", err)
|
|
}
|
|
if !exists {
|
|
return name, false, errors.New("context does not exist")
|
|
}
|
|
|
|
if err := kc.DeleteContextEntry(name); err != nil {
|
|
return name, false, fmt.Errorf("failed to modify yaml doc: %w", err)
|
|
}
|
|
if err := kc.Save(); err != nil {
|
|
return name, wasActiveContext, fmt.Errorf("failed to save modified kubeconfig file: %w", err)
|
|
}
|
|
return name, wasActiveContext, nil
|
|
}
|