mirror of
https://github.com/ahmetb/kubectx.git
synced 2026-03-18 03:42:12 +00:00
860e09775b
Modernize the codebase to use idiomatic Go 1.25 patterns, removing deprecated APIs and reducing external dependencies.
- Replace deprecated `io/ioutil` with `os.ReadFile`, `os.WriteFile`, `os.MkdirTemp`, `os.CreateTemp`
- Replace `interface{}` with `any` (Go 1.18+)
- Remove `github.com/pkg/errors` dependency entirely, using stdlib `fmt.Errorf` with `%w` and `errors.New`
- Use `errors.As()` instead of direct type assertions on error values
- Use `strings.Cut()` for delimiter parsing instead of `strings.Split` + length check
- Use `slices.Contains()` for linear search in `ContextExists()`
- Use `t.Setenv()` and `t.TempDir()` in tests instead of manual env save/restore and temp dir cleanup
- Delete unused `internal/testutil/tempfile.go` helper
- Update GitHub Actions CI and release workflows from Go 1.22 to 1.25
Net result: -70 lines, 1 fewer external dependency.
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
114 lines
2.6 KiB
Go
114 lines
2.6 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/ahmetb/kubectx/internal/env"
|
|
)
|
|
|
|
func Test_detectShell_unix(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("skipping unix shell detection test on windows")
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
shellEnv string
|
|
want string
|
|
}{
|
|
{
|
|
name: "SHELL env set",
|
|
shellEnv: "/bin/zsh",
|
|
want: "/bin/zsh",
|
|
},
|
|
{
|
|
name: "SHELL env empty, falls back to /bin/sh",
|
|
shellEnv: "",
|
|
want: "/bin/sh",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Setenv("SHELL", tt.shellEnv)
|
|
|
|
got := detectShell()
|
|
if got != tt.want {
|
|
t.Errorf("detectShell() = %q, want %q", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_ShellOp_blockedWhenNested(t *testing.T) {
|
|
// Simulate being inside an isolated shell
|
|
t.Setenv(env.EnvIsolatedShell, "1")
|
|
|
|
op := ShellOp{Target: "some-context"}
|
|
var stdout, stderr bytes.Buffer
|
|
err := op.Run(&stdout, &stderr)
|
|
|
|
if err == nil {
|
|
t.Fatal("expected error when running ShellOp inside isolated shell, got nil")
|
|
}
|
|
|
|
want := "locked single-context shell to"
|
|
if !bytes.Contains([]byte(err.Error()), []byte(want)) {
|
|
// The error may not contain the context name if kubeconfig is not available,
|
|
// but it should still be blocked
|
|
want2 := "locked single-context shell"
|
|
if !bytes.Contains([]byte(err.Error()), []byte(want2)) {
|
|
t.Errorf("error message %q does not contain %q", err.Error(), want2)
|
|
}
|
|
}
|
|
}
|
|
|
|
func Test_resolveKubectl_envVar(t *testing.T) {
|
|
t.Setenv("KUBECTL", "/custom/path/kubectl")
|
|
got, err := resolveKubectl()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if got != "/custom/path/kubectl" {
|
|
t.Errorf("resolveKubectl() = %q, want %q", got, "/custom/path/kubectl")
|
|
}
|
|
}
|
|
|
|
func Test_resolveKubectl_inPath(t *testing.T) {
|
|
t.Setenv("KUBECTL", "")
|
|
|
|
// kubectl should be findable in PATH on most dev machines
|
|
got, err := resolveKubectl()
|
|
if err != nil {
|
|
t.Skip("kubectl not in PATH, skipping")
|
|
}
|
|
if got == "" {
|
|
t.Error("resolveKubectl() returned empty string")
|
|
}
|
|
}
|
|
|
|
func Test_checkIsolatedMode_notSet(t *testing.T) {
|
|
t.Setenv(env.EnvIsolatedShell, "")
|
|
|
|
err := checkIsolatedMode()
|
|
if err != nil {
|
|
t.Errorf("expected nil error when not in isolated mode, got: %v", err)
|
|
}
|
|
}
|
|
|
|
func Test_checkIsolatedMode_set(t *testing.T) {
|
|
t.Setenv(env.EnvIsolatedShell, "1")
|
|
|
|
err := checkIsolatedMode()
|
|
if err == nil {
|
|
t.Fatal("expected error when in isolated mode, got nil")
|
|
}
|
|
|
|
want := "locked single-context shell"
|
|
if !bytes.Contains([]byte(err.Error()), []byte(want)) {
|
|
t.Errorf("error message %q does not contain %q", err.Error(), want)
|
|
}
|
|
}
|