github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 03:41:45 +00:00
Code Issues Projects Releases Wiki Activity

Remove Todos for CSR checking

Browse Source 
Remove Todos for verification of “allowed to
post CSR” and "allowed to auto approve CSR"
for bootstraptoken group, as these privilege
bindings are not managed by kubeadm source
code

Signed-off-by: Howard Zhang <howard.zhang@arm.com>
This commit is contained in:
Howard Zhang 2019-12-24 15:56:01 +08:00
parent d758fc3edb
commit 006980c160
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/e2e_kubeadm/bootstrap_token_test.go
View File

@ -68,7 +68,6 @@ var _ = Describe("bootstrap token", func() {
rbacv1.GroupKind, bootstrapTokensGroup, rbacv1.GroupKind, bootstrapTokensGroup,
bootstrapTokensAllowPostCSRClusterRoleName, bootstrapTokensAllowPostCSRClusterRoleName,
) )
//TODO: check if possible to verify "allowed to post CSR" using subject asses review as well
}) })
ginkgo.It("should be allowed to auto approve CSR for kubelet certificates on joining nodes", func() { ginkgo.It("should be allowed to auto approve CSR for kubelet certificates on joining nodes", func() {
@ -77,6 +76,5 @@ var _ = Describe("bootstrap token", func() {
rbacv1.GroupKind, bootstrapTokensGroup, rbacv1.GroupKind, bootstrapTokensGroup,
bootstrapTokensCSRAutoApprovalClusterRoleName, bootstrapTokensCSRAutoApprovalClusterRoleName,
) )
//TODO: check if possible to verify "allowed to auto approve CSR" using subject asses review as well
}) })
}) })