github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-20 18:31:15 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #114078 from Karthik-K-N/fix-flake-test

Browse Source 
Fix TestJitterWithNegativeMaxFactor flaky test
This commit is contained in:
Kubernetes Prow Robot 2023-01-06 05:19:58 -08:00 committed by GitHub
commit 00cd2ae3bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
staging/src/k8s.io/legacy-cloud-providers/azure/retry/azure_retry_test.go
View File

@ -80,13 +80,17 @@ func TestJitterWithNegativeMaxFactor(t *testing.T) {
// jitter := duration + time.Duration(rand.Float64()*maxFactor*float64(duration)) // jitter := duration + time.Duration(rand.Float64()*maxFactor*float64(duration))
// If maxFactor is 0.0 or less than 0.0, a suggested default value will be chosen. // If maxFactor is 0.0 or less than 0.0, a suggested default value will be chosen.
// rand.Float64() returns, as a float64, a pseudo-random number in [0.0,1.0). // rand.Float64() returns, as a float64, a pseudo-random number in [0.0,1.0).
duration := time.Duration(time.Second) duration := time.Second
maxFactor := -3.0 maxFactor := -3.0
res := jitter(duration, maxFactor) res := jitter(duration, maxFactor)
defaultMaxFactor := 1.0 // jitter with negative maxFactor should not be negative
expected := jitter(duration, defaultMaxFactor) assert.Equal(t, res >= duration, true)
assert.Equal(t, expected-res >= time.Duration(0.0*float64(duration)), true) assert.Equal(t, res <= 2*duration, true)
assert.Equal(t, expected-res < time.Duration(1.0*float64(duration)), true)
maxFactor = 2.0
res = jitter(duration, maxFactor)
assert.Equal(t, res >= duration, true)
assert.Equal(t, res <= 3*duration, true)
} }
func TestDoExponentialBackoffRetry(t *testing.T) { func TestDoExponentialBackoffRetry(t *testing.T) {