From ce7b08af9280ab67b9ba111f8d50296fed0bc4db Mon Sep 17 00:00:00 2001
From: David Eads <deads2k@users.noreply.github.com>
Date: Thu, 1 Dec 2016 08:48:45 -0500
Subject: [PATCH] Revert "[kubeadm] use iteration instead of recursion in
 function"

---
 cmd/kubeadm/app/master/apiclient.go | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/cmd/kubeadm/app/master/apiclient.go b/cmd/kubeadm/app/master/apiclient.go
index 447f20fe001..8966f33c1dd 100644
--- a/cmd/kubeadm/app/master/apiclient.go
+++ b/cmd/kubeadm/app/master/apiclient.go
@@ -178,22 +178,21 @@ func attemptToUpdateMasterRoleLabelsAndTaints(client *clientset.Clientset, sched
 		n.ObjectMeta.Annotations[v1.TaintsAnnotationKey] = string(taintsAnnotation)
 	}
 
-	for {
-		if _, err := client.Nodes().Update(n); err != nil {
-			if apierrs.IsConflict(err) {
-				fmt.Println("<master/apiclient> temporarily unable to update master node metadata due to conflict (will retry)")
-				time.Sleep(apiCallRetryInterval)
-			} else {
-				return err
-			}
+	if _, err := client.Nodes().Update(n); err != nil {
+		if apierrs.IsConflict(err) {
+			fmt.Println("<master/apiclient> temporarily unable to update master node metadata due to conflict (will retry)")
+			time.Sleep(apiCallRetryInterval)
+			attemptToUpdateMasterRoleLabelsAndTaints(client, schedulable)
 		} else {
-			return nil
+			return err
 		}
 	}
 
+	return nil
 }
 
 func UpdateMasterRoleLabelsAndTaints(client *clientset.Clientset, schedulable bool) error {
+	// TODO(phase1+) use iterate instead of recursion
 	err := attemptToUpdateMasterRoleLabelsAndTaints(client, schedulable)
 	if err != nil {
 		return fmt.Errorf("<master/apiclient> failed to update master node - %v", err)