From 76919e9569746e4e1ae0ec190892af3a142553c9 Mon Sep 17 00:00:00 2001 From: Ritikaa96 Date: Mon, 4 Sep 2023 13:53:57 +0900 Subject: [PATCH 1/2] Updated descriptions in kubectl create deployment help , added example for multiple images Signed-off-by: Ritikaa96 --- .../k8s.io/kubectl/pkg/cmd/create/create_deployment.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go index 4519eba1be6..dfede8e96d6 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go @@ -53,7 +53,10 @@ var ( kubectl create deployment my-dep --image=nginx --replicas=3 # Create a deployment named my-dep that runs the busybox image and expose port 5701 - kubectl create deployment my-dep --image=busybox --port=5701`)) + kubectl create deployment my-dep --image=busybox --port=5701 + + # Create a deployment named my-dep that runs multiple containers + kubectl create deployment dep --image=busybox:latest --port=5701 --image=ubuntu:latest --image=nginx`)) ) // CreateDeploymentOptions is returned by NewCmdCreateDeployment @@ -112,9 +115,9 @@ func NewCmdCreateDeployment(f cmdutil.Factory, ioStreams genericiooptions.IOStre cmdutil.AddApplyAnnotationFlags(cmd) cmdutil.AddValidateFlags(cmd) cmdutil.AddDryRunFlag(cmd) - cmd.Flags().StringSliceVar(&o.Images, "image", o.Images, "Image names to run.") + cmd.Flags().StringSliceVar(&o.Images, "image", o.Images, "Image names to run. A deployment can have multiple images set for multi-container pod. It is to be noted that command can't be mentioned along with list of images. ") cmd.MarkFlagRequired("image") - cmd.Flags().Int32Var(&o.Port, "port", o.Port, "The port that this container exposes.") + cmd.Flags().Int32Var(&o.Port, "port", o.Port, "The containerPort that this deployment exposes.") cmd.Flags().Int32VarP(&o.Replicas, "replicas", "r", o.Replicas, "Number of replicas to create. Default is 1.") cmdutil.AddFieldManagerFlagVar(cmd, &o.FieldManager, "kubectl-create") From 9efff41b8e0103361cd7b8a41dc9641638c5a292 Mon Sep 17 00:00:00 2001 From: Ritikaa96 Date: Thu, 30 Nov 2023 13:09:54 +0530 Subject: [PATCH 2/2] making suggested changes Signed-off-by: Ritikaa96 --- .../src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go index dfede8e96d6..519c7fb6223 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_deployment.go @@ -56,7 +56,7 @@ var ( kubectl create deployment my-dep --image=busybox --port=5701 # Create a deployment named my-dep that runs multiple containers - kubectl create deployment dep --image=busybox:latest --port=5701 --image=ubuntu:latest --image=nginx`)) + kubectl create deployment my-dep --image=busybox:latest --image=ubuntu:latest --image=nginx`)) ) // CreateDeploymentOptions is returned by NewCmdCreateDeployment @@ -115,7 +115,7 @@ func NewCmdCreateDeployment(f cmdutil.Factory, ioStreams genericiooptions.IOStre cmdutil.AddApplyAnnotationFlags(cmd) cmdutil.AddValidateFlags(cmd) cmdutil.AddDryRunFlag(cmd) - cmd.Flags().StringSliceVar(&o.Images, "image", o.Images, "Image names to run. A deployment can have multiple images set for multi-container pod. It is to be noted that command can't be mentioned along with list of images. ") + cmd.Flags().StringSliceVar(&o.Images, "image", o.Images, "Image names to run. A deployment can have multiple images set for multi-container pod.") cmd.MarkFlagRequired("image") cmd.Flags().Int32Var(&o.Port, "port", o.Port, "The containerPort that this deployment exposes.") cmd.Flags().Int32VarP(&o.Replicas, "replicas", "r", o.Replicas, "Number of replicas to create. Default is 1.")