mirror of
https://github.com/k3s-io/kubernetes.git
synced 2026-01-04 23:17:50 +00:00
Merge pull request #25443 from nikhiljindal/tryingClientGen
Automatic merge from submit-queue Adding Services to federation clientset Commits: 1. Regenerate the client without any changes to client-gen 2. Update clientgen to add a parameter to specify generating client only for Services v1 object. 3. Regenerate federation_internalclientset 4. Regenerate federation_release_1_3 Second commit is the most important one. Other 3 commits are auto generated by running client-gen. I have added a command line argument to client-gen that takes in a list of group/version/resource. If a group version is part of this list, then only the resources in this list are included in the client. For other group versions, the existing check of genclient=true in types.go is used. Other alternatives considered were: * Update genclient in types.go to mention the clientset name in which it should be included instead of just saying genclient=true (so Services will say genclient=core,federation while all other v1 resources will say genclient=core). This requires a code change in types.go to change a client set. * Create another types.go which will only include Services and use that to generate federation clientset. This will lead to duplicate Service definition. cc @caesarxuchao @lavalamp @jianhuiz @mfanjie @kubernetes/sig-cluster-federation <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/25443) <!-- Reviewable:end -->
This commit is contained in:
@@ -176,6 +176,7 @@ image-gc-high-threshold
|
||||
image-gc-low-threshold
|
||||
image-pull-policy
|
||||
include-extended-apis
|
||||
included-types-overrides
|
||||
input-base
|
||||
input-dirs
|
||||
insecure-bind-address
|
||||
@@ -198,8 +199,8 @@ k8s-build-output
|
||||
keep-gogoproto
|
||||
km-path
|
||||
kube-api-burst
|
||||
kube-api-qps
|
||||
kube-api-content-type
|
||||
kube-api-qps
|
||||
kube-master
|
||||
kube-master
|
||||
kube-master-url
|
||||
|
||||
Reference in New Issue
Block a user