From 017998e8890b0b7eb14c2cfbd281ccd1fc52dba4 Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Tue, 3 May 2022 18:44:11 +0200 Subject: [PATCH] e2e: node: explicit skip for device plugin tests The device plugin e2e tests where failing lately and to unblock the release a skip was added in the prow job configuration: https://github.com/kubernetes/test-infra/blob/71cf119c846b21f8fc37ab7bac00899a80ce9bea/config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml#L401 The problem here is not only the broken test which need to be fixed, but also the fact that this is the only skip (for a specific test) we do this way, which is surprising (xref: https://github.com/kubernetes/kubernetes/issues/106635#issuecomment-1105627265) As next step towards improvement, we add an explicit skip in the tests proper. This makes at least more obvious these tests need more work, and allow us to remove the edge case in the prow configuration. Signed-off-by: Francesco Romani --- test/e2e_node/device_plugin_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/e2e_node/device_plugin_test.go b/test/e2e_node/device_plugin_test.go index 9d3ece3a92f..d0b70fa0360 100644 --- a/test/e2e_node/device_plugin_test.go +++ b/test/e2e_node/device_plugin_test.go @@ -25,6 +25,7 @@ import ( v1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/serializer" + e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper" e2etestfiles "k8s.io/kubernetes/test/e2e/framework/testfiles" admissionapi "k8s.io/pod-security-admission/api" @@ -116,6 +117,8 @@ func testDevicePlugin(f *framework.Framework, pluginSockDir string) { var devicePluginPod, dptemplate *v1.Pod ginkgo.BeforeEach(func() { + e2eskipper.Skipf("Device Plugin tests are currently broken and being investigated") + ginkgo.By("Wait for node to be ready") gomega.Eventually(func() bool { nodes, err := e2enode.TotalReady(f.ClientSet)