From 01ae1b1b5a5e2210d1aeebc5e955e1aacf8e7e62 Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Thu, 20 Mar 2025 20:12:02 +0000 Subject: [PATCH] remove kubernetes.io/hostname label copying --- pkg/features/kube_features.go | 4 ++-- plugin/pkg/admission/podtopologylabels/admission.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index 11dd7106c83..a6e058523ce 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -970,8 +970,8 @@ const ( // alpha: v1.33 // // Enables the PodTopologyLabelsAdmission admission plugin that mutates `pod/binding` - // requests by copying the `topology.k8s.io/{zone,region}` and `kubernetes.io/hostname` - // labels from the assigned Node object (in the Binding being admitted) onto the Binding + // requests by copying the `topology.k8s.io/{zone,region}` labels from the assigned + // Node object (in the Binding being admitted) onto the Binding // so that it can be persisted onto the Pod object when the Pod is being scheduled. // This allows workloads running in pods to understand the topology information of their assigned node. // Enabling this feature also permits external schedulers to set labels on pods in an atomic diff --git a/plugin/pkg/admission/podtopologylabels/admission.go b/plugin/pkg/admission/podtopologylabels/admission.go index d0d6d2066f9..a2c22e786a9 100644 --- a/plugin/pkg/admission/podtopologylabels/admission.go +++ b/plugin/pkg/admission/podtopologylabels/admission.go @@ -41,7 +41,7 @@ const PluginName = "PodTopologyLabels" // This configuration is used by kube-apiserver. // It is not exported to avoid any chance of accidentally mutating the variable. var defaultConfig = Config{ - Labels: []string{"topology.k8s.io/zone", "topology.k8s.io/region", "kubernetes.io/hostname"}, + Labels: []string{"topology.k8s.io/zone", "topology.k8s.io/region"}, } // Register registers a plugin