Error test cases added

Signed-off-by: twelcon <mastermind12210@gmail.com>
This commit is contained in:
twelcon 2023-06-20 19:42:17 +05:30
parent a609beb6b1
commit 01c2c4f35f
No known key found for this signature in database
GPG Key ID: 0246EC33BB5116B5

View File

@ -6749,10 +6749,13 @@ func TestValidateResizePolicy(t *testing.T) {
tSupportedResizeResources := sets.NewString(string(core.ResourceCPU), string(core.ResourceMemory)) tSupportedResizeResources := sets.NewString(string(core.ResourceCPU), string(core.ResourceMemory))
tSupportedResizePolicies := sets.NewString(string(core.NotRequired), string(core.RestartContainer)) tSupportedResizePolicies := sets.NewString(string(core.NotRequired), string(core.RestartContainer))
type T struct { type T struct {
PolicyList []core.ContainerResizePolicy PolicyList []core.ContainerResizePolicy
ExpectError bool ExpectError bool
Errors field.ErrorList Errors field.ErrorList
PodRestartPolicy core.RestartPolicy
} }
// var PodRestartPolicy core.RestartPolicy
// PodRestartPolicy = "Never"
testCases := map[string]T{ testCases := map[string]T{
"ValidCPUandMemoryPolicies": { "ValidCPUandMemoryPolicies": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6761,6 +6764,7 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
false, false,
nil, nil,
"Always",
}, },
"ValidCPUPolicy": { "ValidCPUPolicy": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6768,6 +6772,7 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
false, false,
nil, nil,
"Always",
}, },
"ValidMemoryPolicy": { "ValidMemoryPolicy": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6775,11 +6780,13 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
false, false,
nil, nil,
"Always",
}, },
"NoPolicy": { "NoPolicy": {
[]core.ContainerResizePolicy{}, []core.ContainerResizePolicy{},
false, false,
nil, nil,
"Always",
}, },
"ValidCPUandInvalidMemoryPolicy": { "ValidCPUandInvalidMemoryPolicy": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6788,6 +6795,7 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
true, true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("Restarrrt"), tSupportedResizePolicies.List())}, field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("Restarrrt"), tSupportedResizePolicies.List())},
"Always",
}, },
"ValidMemoryandInvalidCPUPolicy": { "ValidMemoryandInvalidCPUPolicy": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6796,6 +6804,7 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
true, true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("RestartNotRequirrred"), tSupportedResizePolicies.List())}, field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("RestartNotRequirrred"), tSupportedResizePolicies.List())},
"Always",
}, },
"InvalidResourceNameValidPolicy": { "InvalidResourceNameValidPolicy": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6803,6 +6812,7 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
true, true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceName("cpuuu"), tSupportedResizeResources.List())}, field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceName("cpuuu"), tSupportedResizeResources.List())},
"Always",
}, },
"ValidResourceNameMissingPolicy": { "ValidResourceNameMissingPolicy": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6810,6 +6820,7 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
true, true,
field.ErrorList{field.Required(field.NewPath("field"), "")}, field.ErrorList{field.Required(field.NewPath("field"), "")},
"Always",
}, },
"RepeatedPolicies": { "RepeatedPolicies": {
[]core.ContainerResizePolicy{ []core.ContainerResizePolicy{
@ -6819,12 +6830,20 @@ func TestValidateResizePolicy(t *testing.T) {
}, },
true, true,
field.ErrorList{field.Duplicate(field.NewPath("field").Index(2), core.ResourceCPU)}, field.ErrorList{field.Duplicate(field.NewPath("field").Index(2), core.ResourceCPU)},
"Always",
},
"InvalidPolicyWithPodRestartPolicy": {
[]core.ContainerResizePolicy{
{ResourceName: "cpu", RestartPolicy: "NotRequired"},
{ResourceName: "memory", RestartPolicy: "RestartContainer"},
},
true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("RestartContainer"), []string{string(core.NotRequired)})},
"Never",
}, },
} }
var PodRestartPolicy core.RestartPolicy
PodRestartPolicy = "Never"
for k, v := range testCases { for k, v := range testCases {
errs := validateResizePolicy(v.PolicyList, field.NewPath("field"), &PodRestartPolicy) errs := validateResizePolicy(v.PolicyList, field.NewPath("field"), &v.PodRestartPolicy)
if !v.ExpectError && len(errs) > 0 { if !v.ExpectError && len(errs) > 0 {
t.Errorf("Testcase %s - expected success, got error: %+v", k, errs) t.Errorf("Testcase %s - expected success, got error: %+v", k, errs)
} }
@ -7480,7 +7499,7 @@ func TestValidateContainers(t *testing.T) {
} }
var PodRestartPolicy core.RestartPolicy var PodRestartPolicy core.RestartPolicy
PodRestartPolicy = "Never" PodRestartPolicy = "Always"
if errs := validateContainers(successCase, volumeDevices, nil, field.NewPath("field"), PodValidationOptions{}, &PodRestartPolicy); len(errs) != 0 { if errs := validateContainers(successCase, volumeDevices, nil, field.NewPath("field"), PodValidationOptions{}, &PodRestartPolicy); len(errs) != 0 {
t.Errorf("expected success: %v", errs) t.Errorf("expected success: %v", errs)
} }