Error test cases added

Signed-off-by: twelcon <mastermind12210@gmail.com>
This commit is contained in:
twelcon 2023-06-20 19:42:17 +05:30
parent a609beb6b1
commit 01c2c4f35f
No known key found for this signature in database
GPG Key ID: 0246EC33BB5116B5

View File

@ -6752,7 +6752,10 @@ func TestValidateResizePolicy(t *testing.T) {
PolicyList []core.ContainerResizePolicy
ExpectError bool
Errors field.ErrorList
PodRestartPolicy core.RestartPolicy
}
// var PodRestartPolicy core.RestartPolicy
// PodRestartPolicy = "Never"
testCases := map[string]T{
"ValidCPUandMemoryPolicies": {
[]core.ContainerResizePolicy{
@ -6761,6 +6764,7 @@ func TestValidateResizePolicy(t *testing.T) {
},
false,
nil,
"Always",
},
"ValidCPUPolicy": {
[]core.ContainerResizePolicy{
@ -6768,6 +6772,7 @@ func TestValidateResizePolicy(t *testing.T) {
},
false,
nil,
"Always",
},
"ValidMemoryPolicy": {
[]core.ContainerResizePolicy{
@ -6775,11 +6780,13 @@ func TestValidateResizePolicy(t *testing.T) {
},
false,
nil,
"Always",
},
"NoPolicy": {
[]core.ContainerResizePolicy{},
false,
nil,
"Always",
},
"ValidCPUandInvalidMemoryPolicy": {
[]core.ContainerResizePolicy{
@ -6788,6 +6795,7 @@ func TestValidateResizePolicy(t *testing.T) {
},
true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("Restarrrt"), tSupportedResizePolicies.List())},
"Always",
},
"ValidMemoryandInvalidCPUPolicy": {
[]core.ContainerResizePolicy{
@ -6796,6 +6804,7 @@ func TestValidateResizePolicy(t *testing.T) {
},
true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("RestartNotRequirrred"), tSupportedResizePolicies.List())},
"Always",
},
"InvalidResourceNameValidPolicy": {
[]core.ContainerResizePolicy{
@ -6803,6 +6812,7 @@ func TestValidateResizePolicy(t *testing.T) {
},
true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceName("cpuuu"), tSupportedResizeResources.List())},
"Always",
},
"ValidResourceNameMissingPolicy": {
[]core.ContainerResizePolicy{
@ -6810,6 +6820,7 @@ func TestValidateResizePolicy(t *testing.T) {
},
true,
field.ErrorList{field.Required(field.NewPath("field"), "")},
"Always",
},
"RepeatedPolicies": {
[]core.ContainerResizePolicy{
@ -6819,12 +6830,20 @@ func TestValidateResizePolicy(t *testing.T) {
},
true,
field.ErrorList{field.Duplicate(field.NewPath("field").Index(2), core.ResourceCPU)},
"Always",
},
"InvalidPolicyWithPodRestartPolicy": {
[]core.ContainerResizePolicy{
{ResourceName: "cpu", RestartPolicy: "NotRequired"},
{ResourceName: "memory", RestartPolicy: "RestartContainer"},
},
true,
field.ErrorList{field.NotSupported(field.NewPath("field"), core.ResourceResizeRestartPolicy("RestartContainer"), []string{string(core.NotRequired)})},
"Never",
},
}
var PodRestartPolicy core.RestartPolicy
PodRestartPolicy = "Never"
for k, v := range testCases {
errs := validateResizePolicy(v.PolicyList, field.NewPath("field"), &PodRestartPolicy)
errs := validateResizePolicy(v.PolicyList, field.NewPath("field"), &v.PodRestartPolicy)
if !v.ExpectError && len(errs) > 0 {
t.Errorf("Testcase %s - expected success, got error: %+v", k, errs)
}
@ -7480,7 +7499,7 @@ func TestValidateContainers(t *testing.T) {
}
var PodRestartPolicy core.RestartPolicy
PodRestartPolicy = "Never"
PodRestartPolicy = "Always"
if errs := validateContainers(successCase, volumeDevices, nil, field.NewPath("field"), PodValidationOptions{}, &PodRestartPolicy); len(errs) != 0 {
t.Errorf("expected success: %v", errs)
}