github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 19:31:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #100738 from cuisongliu/bug_register-gen_groupName

Browse Source 
code-generator/register-gen: groupName can't override
This commit is contained in:
Kubernetes Prow Robot 2021-08-05 08:17:22 -07:00 committed by GitHub
commit 01d2ee8e53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
staging/src/k8s.io/code-generator/cmd/register-gen/generators/packages.go
View File

@ -82,7 +82,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
// if there is a comment of the form "// +groupName=somegroup" or "// +groupName=somegroup.foo.bar.io", // if there is a comment of the form "// +groupName=somegroup" or "// +groupName=somegroup.foo.bar.io",
// extract the fully qualified API group name from it and overwrite the group inferred from the package path // extract the fully qualified API group name from it and overwrite the group inferred from the package path
if override := types.ExtractCommentTags("+", pkg.DocComments)["groupName"]; override != nil { if override := types.ExtractCommentTags("+", pkg.Comments)["groupName"]; override != nil {
groupName := override[0] groupName := override[0]
klog.V(5).Infof("overriding the group name with = %s", groupName) klog.V(5).Infof("overriding the group name with = %s", groupName)
gv.Group = clientgentypes.Group(groupName) gv.Group = clientgentypes.Group(groupName)