From 023a477c6348fb4ef7a7967823578717c9d12e44 Mon Sep 17 00:00:00 2001 From: Ashley Gau Date: Fri, 13 Apr 2018 15:31:27 -0700 Subject: [PATCH] Add comments, t.Parallel() --- .../providers/gce/gce_loadbalancer_test.go | 14 ++++++++++++++ .../providers/gce/gce_loadbalancer_utils_test.go | 4 ++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/pkg/cloudprovider/providers/gce/gce_loadbalancer_test.go b/pkg/cloudprovider/providers/gce/gce_loadbalancer_test.go index c141033c986..7d7224892c1 100644 --- a/pkg/cloudprovider/providers/gce/gce_loadbalancer_test.go +++ b/pkg/cloudprovider/providers/gce/gce_loadbalancer_test.go @@ -25,6 +25,8 @@ import ( ) func TestGetLoadBalancer(t *testing.T) { + t.Parallel() + vals := DefaultTestClusterValues() gce, err := fakeGCECloud(vals) require.NoError(t, err) @@ -50,6 +52,8 @@ func TestGetLoadBalancer(t *testing.T) { } func TestEnsureLoadBalancerCreatesExternalLb(t *testing.T) { + t.Parallel() + vals := DefaultTestClusterValues() gce, err := fakeGCECloud(vals) require.NoError(t, err) @@ -66,6 +70,8 @@ func TestEnsureLoadBalancerCreatesExternalLb(t *testing.T) { } func TestEnsureLoadBalancerCreatesInternalLb(t *testing.T) { + t.Parallel() + vals := DefaultTestClusterValues() gce, err := fakeGCECloud(vals) require.NoError(t, err) @@ -82,6 +88,8 @@ func TestEnsureLoadBalancerCreatesInternalLb(t *testing.T) { } func TestEnsureLoadBalancerDeletesExistingInternalLb(t *testing.T) { + t.Parallel() + vals := DefaultTestClusterValues() gce, err := fakeGCECloud(vals) require.NoError(t, err) @@ -102,6 +110,8 @@ func TestEnsureLoadBalancerDeletesExistingInternalLb(t *testing.T) { } func TestEnsureLoadBalancerDeletesExistingExternalLb(t *testing.T) { + t.Parallel() + vals := DefaultTestClusterValues() gce, err := fakeGCECloud(vals) require.NoError(t, err) @@ -123,6 +133,8 @@ func TestEnsureLoadBalancerDeletesExistingExternalLb(t *testing.T) { } func TestEnsureLoadBalancerDeletedDeletesExternalLb(t *testing.T) { + t.Parallel() + vals := DefaultTestClusterValues() gce, err := fakeGCECloud(vals) require.NoError(t, err) @@ -140,6 +152,8 @@ func TestEnsureLoadBalancerDeletedDeletesExternalLb(t *testing.T) { } func TestEnsureLoadBalancerDeletedDeletesInternalLb(t *testing.T) { + t.Parallel() + vals := DefaultTestClusterValues() gce, err := fakeGCECloud(vals) require.NoError(t, err) diff --git a/pkg/cloudprovider/providers/gce/gce_loadbalancer_utils_test.go b/pkg/cloudprovider/providers/gce/gce_loadbalancer_utils_test.go index d34ee3ad52e..366d347e7b6 100644 --- a/pkg/cloudprovider/providers/gce/gce_loadbalancer_utils_test.go +++ b/pkg/cloudprovider/providers/gce/gce_loadbalancer_utils_test.go @@ -214,7 +214,7 @@ func assertExternalLbResources(t *testing.T, gce *GCECloud, apiService *v1.Servi // Check that Firewalls are created for the LoadBalancer and the HealthCheck fwNames := []string{ - MakeFirewallName(lbName), + MakeFirewallName(lbName), // Firewalls for external LBs are prefixed with k8s-fw- MakeHealthCheckFirewallName(vals.ClusterID, hcName, true), } @@ -291,7 +291,7 @@ func assertInternalLbResources(t *testing.T, gce *GCECloud, apiService *v1.Servi // Check that Firewalls are created for the LoadBalancer and the HealthCheck fwNames := []string{ - lbName, + lbName, // Firewalls for internal LBs are named the same name as the loadbalancer. makeHealthCheckFirewallName(lbName, vals.ClusterID, true), }