From 023fe48c98f5fd3458e8547ce0dceafeb97f385e Mon Sep 17 00:00:00 2001 From: Pengfei Ni Date: Wed, 5 Apr 2017 22:34:30 +0800 Subject: [PATCH] Do not clear hostPid for host-networked container --- pkg/kubelet/dockershim/security_context.go | 1 - pkg/kubelet/dockershim/security_context_test.go | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/dockershim/security_context.go b/pkg/kubelet/dockershim/security_context.go index f5ba3a39d0b..f1f3025b9a6 100644 --- a/pkg/kubelet/dockershim/security_context.go +++ b/pkg/kubelet/dockershim/security_context.go @@ -167,7 +167,6 @@ func modifyHostNetworkOptionForContainer(hostNetwork bool, sandboxID string, hc hc.NetworkMode = dockercontainer.NetworkMode(sandboxNSMode) hc.IpcMode = dockercontainer.IpcMode(sandboxNSMode) hc.UTSMode = "" - hc.PidMode = "" if hostNetwork { hc.UTSMode = namespaceModeHost diff --git a/pkg/kubelet/dockershim/security_context_test.go b/pkg/kubelet/dockershim/security_context_test.go index a0f54e95c05..9b89b46703f 100644 --- a/pkg/kubelet/dockershim/security_context_test.go +++ b/pkg/kubelet/dockershim/security_context_test.go @@ -306,6 +306,7 @@ func TestModifyContainerNamespaceOptions(t *testing.T) { expected: &dockercontainer.HostConfig{ NetworkMode: dockercontainer.NetworkMode(sandboxNSMode), IpcMode: dockercontainer.IpcMode(sandboxNSMode), + PidMode: namespaceModeHost, }, }, }