From 0244c0e65890fc97d7b723963b44b1c3c1c87355 Mon Sep 17 00:00:00 2001 From: nolancon Date: Thu, 30 May 2019 05:39:21 +0100 Subject: [PATCH] remove dependency on implementation from policy preferred and strict update build --- pkg/kubelet/cm/topologymanager/BUILD | 13 ++++++++++++- pkg/kubelet/cm/topologymanager/policy_preferred.go | 2 +- pkg/kubelet/cm/topologymanager/policy_strict.go | 2 +- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/cm/topologymanager/BUILD b/pkg/kubelet/cm/topologymanager/BUILD index cdd0dbce856..7a639ac9966 100644 --- a/pkg/kubelet/cm/topologymanager/BUILD +++ b/pkg/kubelet/cm/topologymanager/BUILD @@ -1,9 +1,11 @@ -load("@io_bazel_rules_go//go:def.bzl", "go_library") +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") go_library( name = "go_default_library", srcs = [ "policy.go", + "policy_preferred.go", + "policy_strict.go", "topology_manager.go", ], importpath = "k8s.io/kubernetes/pkg/kubelet/cm/topologymanager", @@ -31,3 +33,12 @@ filegroup( tags = ["automanaged"], visibility = ["//visibility:public"], ) + +go_test( + name = "go_default_test", + srcs = [ + "policy_preferred_test.go", + "policy_strict_test.go", + ], + embed = [":go_default_library"], +) diff --git a/pkg/kubelet/cm/topologymanager/policy_preferred.go b/pkg/kubelet/cm/topologymanager/policy_preferred.go index 04b2588b626..36d7f3e4bf9 100644 --- a/pkg/kubelet/cm/topologymanager/policy_preferred.go +++ b/pkg/kubelet/cm/topologymanager/policy_preferred.go @@ -25,7 +25,7 @@ type preferredPolicy struct{} var _ Policy = &preferredPolicy{} // PolicyPreferred policy name. -const PolicyPreferred policyName = "preferred" +const PolicyPreferred string = "preferred" // NewPreferredPolicy returns preferred policy. func NewPreferredPolicy() Policy { diff --git a/pkg/kubelet/cm/topologymanager/policy_strict.go b/pkg/kubelet/cm/topologymanager/policy_strict.go index 14849885007..530e7d22a03 100644 --- a/pkg/kubelet/cm/topologymanager/policy_strict.go +++ b/pkg/kubelet/cm/topologymanager/policy_strict.go @@ -25,7 +25,7 @@ type strictPolicy struct{} var _ Policy = &strictPolicy{} // PolicyStrict policy name. -const PolicyStrict policyName = "strict" +const PolicyStrict string = "strict" // NewStrictPolicy returns strict policy. func NewStrictPolicy() Policy {