From 0b5fcbe2ab86477e7bd0ba70f6a14b452a05735d Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Thu, 19 Jan 2017 10:27:59 -0500 Subject: [PATCH] Remove kubeadm authorizer package dependency --- cmd/kubeadm/app/apis/kubeadm/v1alpha1/BUILD | 1 - cmd/kubeadm/app/apis/kubeadm/v1alpha1/defaults.go | 7 ++----- cmd/kubeadm/app/cmd/BUILD | 1 - cmd/kubeadm/app/cmd/init.go | 3 +-- cmd/kubeadm/app/master/BUILD | 1 - cmd/kubeadm/app/master/manifests.go | 5 ++--- 6 files changed, 5 insertions(+), 13 deletions(-) diff --git a/cmd/kubeadm/app/apis/kubeadm/v1alpha1/BUILD b/cmd/kubeadm/app/apis/kubeadm/v1alpha1/BUILD index 51baff30032..245a85a353c 100644 --- a/cmd/kubeadm/app/apis/kubeadm/v1alpha1/BUILD +++ b/cmd/kubeadm/app/apis/kubeadm/v1alpha1/BUILD @@ -19,7 +19,6 @@ go_library( tags = ["automanaged"], deps = [ "//pkg/api/v1:go_default_library", - "//pkg/kubeapiserver/authorizer:go_default_library", "//vendor:k8s.io/apimachinery/pkg/apis/meta/v1", "//vendor:k8s.io/apimachinery/pkg/runtime", "//vendor:k8s.io/apimachinery/pkg/runtime/schema", diff --git a/cmd/kubeadm/app/apis/kubeadm/v1alpha1/defaults.go b/cmd/kubeadm/app/apis/kubeadm/v1alpha1/defaults.go index 8fe01b709d5..2d5c0d27303 100644 --- a/cmd/kubeadm/app/apis/kubeadm/v1alpha1/defaults.go +++ b/cmd/kubeadm/app/apis/kubeadm/v1alpha1/defaults.go @@ -16,10 +16,7 @@ limitations under the License. package v1alpha1 -import ( - "k8s.io/apimachinery/pkg/runtime" - "k8s.io/kubernetes/pkg/kubeapiserver/authorizer" -) +import "k8s.io/apimachinery/pkg/runtime" const ( DefaultServiceDNSDomain = "cluster.local" @@ -28,7 +25,7 @@ const ( DefaultKubernetesFallbackVersion = "v1.5.0" DefaultAPIBindPort = 6443 DefaultDiscoveryBindPort = 9898 - DefaultAuthorizationMode = authorizer.ModeRBAC + DefaultAuthorizationMode = "RBAC" ) func addDefaultingFuncs(scheme *runtime.Scheme) error { diff --git a/cmd/kubeadm/app/cmd/BUILD b/cmd/kubeadm/app/cmd/BUILD index 273c47638af..880f7acd327 100644 --- a/cmd/kubeadm/app/cmd/BUILD +++ b/cmd/kubeadm/app/cmd/BUILD @@ -34,7 +34,6 @@ go_library( "//cmd/kubeadm/app/util:go_default_library", "//pkg/api:go_default_library", "//pkg/api/v1:go_default_library", - "//pkg/kubeapiserver/authorizer:go_default_library", "//pkg/kubectl:go_default_library", "//pkg/kubectl/cmd/util:go_default_library", "//pkg/util/flag:go_default_library", diff --git a/cmd/kubeadm/app/cmd/init.go b/cmd/kubeadm/app/cmd/init.go index 560beed1e01..0952f46a740 100644 --- a/cmd/kubeadm/app/cmd/init.go +++ b/cmd/kubeadm/app/cmd/init.go @@ -42,7 +42,6 @@ import ( "k8s.io/kubernetes/cmd/kubeadm/app/preflight" kubeadmutil "k8s.io/kubernetes/cmd/kubeadm/app/util" "k8s.io/kubernetes/pkg/api" - "k8s.io/kubernetes/pkg/kubeapiserver/authorizer" ) var ( @@ -258,7 +257,7 @@ func (i *Init) Run(out io.Writer) error { return err } - if i.cfg.AuthorizationMode == authorizer.ModeRBAC { + if i.cfg.AuthorizationMode == "RBAC" { err = apiconfig.CreateBootstrapRBACClusterRole(client) if err != nil { return err diff --git a/cmd/kubeadm/app/master/BUILD b/cmd/kubeadm/app/master/BUILD index e9fcef0884d..10011ddc536 100644 --- a/cmd/kubeadm/app/master/BUILD +++ b/cmd/kubeadm/app/master/BUILD @@ -30,7 +30,6 @@ go_library( "//pkg/apis/extensions/v1beta1:go_default_library", "//pkg/client/clientset_generated/clientset:go_default_library", "//pkg/client/unversioned/clientcmd:go_default_library", - "//pkg/kubeapiserver/authorizer:go_default_library", "//pkg/kubectl/cmd/util:go_default_library", "//pkg/registry/core/service/ipallocator:go_default_library", "//pkg/util/cert:go_default_library", diff --git a/cmd/kubeadm/app/master/manifests.go b/cmd/kubeadm/app/master/manifests.go index f966eb3a71a..5bd03ca8968 100644 --- a/cmd/kubeadm/app/master/manifests.go +++ b/cmd/kubeadm/app/master/manifests.go @@ -29,7 +29,6 @@ import ( "k8s.io/kubernetes/cmd/kubeadm/app/images" "k8s.io/kubernetes/pkg/api/resource" api "k8s.io/kubernetes/pkg/api/v1" - "k8s.io/kubernetes/pkg/kubeapiserver/authorizer" cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" "k8s.io/kubernetes/pkg/util/intstr" @@ -302,9 +301,9 @@ func getAPIServerCommand(cfg *kubeadmapi.MasterConfiguration) []string { if cfg.AuthorizationMode != "" { command = append(command, "--authorization-mode="+cfg.AuthorizationMode) switch cfg.AuthorizationMode { - case authorizer.ModeABAC: + case "ABAC": command = append(command, "--authorization-policy-file="+path.Join(kubeadmapi.GlobalEnvParams.KubernetesDir, authorizationPolicyFile)) - case authorizer.ModeWebhook: + case "Webhook": command = append(command, "--authorization-webhook-config-file="+path.Join(kubeadmapi.GlobalEnvParams.KubernetesDir, authorizationWebhookConfigFile)) } }