github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

test/e2e/framework: Log arguments at a higher level

Browse Source 
Both of these are explicit arguments and are more elegantly logged
in a test framework by logging the arguments to the test.

The namespaces to be deleted are already logged inside
WaitForNamespacesDeleted
This commit is contained in:
Clayton Coleman 2021-01-20 14:45:22 -05:00
parent 737858cd7c
commit 02a13a4a39
No known key found for this signature in database
GPG Key ID: 3D16906B4F1C5CB3
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/e2e/e2e.go
View File

@ -247,7 +247,6 @@ func setupSuite() {
if err != nil { if err != nil {
framework.Failf("Error deleting orphaned namespaces: %v", err) framework.Failf("Error deleting orphaned namespaces: %v", err)
} }
klog.Infof("Waiting for deletion of the following namespaces: %v", deleted)
if err := framework.WaitForNamespacesDeleted(c, deleted, namespaceCleanupTimeout); err != nil { if err := framework.WaitForNamespacesDeleted(c, deleted, namespaceCleanupTimeout); err != nil {
framework.Failf("Failed to delete orphaned namespaces %v: %v", deleted, err) framework.Failf("Failed to delete orphaned namespaces %v: %v", deleted, err)
} }

4
test/e2e/framework/test_context.go
View File

@ -433,7 +433,7 @@ func AfterReadingAllFlags(t *TestContextType) {
kubeConfig := createKubeConfig(clusterConfig) kubeConfig := createKubeConfig(clusterConfig)
clientcmd.WriteToFile(*kubeConfig, tempFile.Name()) clientcmd.WriteToFile(*kubeConfig, tempFile.Name())
t.KubeConfig = tempFile.Name() t.KubeConfig = tempFile.Name()
klog.Infof("Using a temporary kubeconfig file from in-cluster config : %s", tempFile.Name()) klog.V(4).Infof("Using a temporary kubeconfig file from in-cluster config : %s", tempFile.Name())
} }
} }
if len(t.KubeConfig) == 0 { if len(t.KubeConfig) == 0 {
@ -454,7 +454,7 @@ func AfterReadingAllFlags(t *TestContextType) {
t.AllowedNotReadyNodes = t.CloudConfig.NumNodes / 100 t.AllowedNotReadyNodes = t.CloudConfig.NumNodes / 100
} }
klog.Infof("Tolerating taints %q when considering if nodes are ready", TestContext.NonblockingTaints) klog.V(4).Infof("Tolerating taints %q when considering if nodes are ready", TestContext.NonblockingTaints)
// Make sure that all test runs have a valid TestContext.CloudConfig.Provider. // Make sure that all test runs have a valid TestContext.CloudConfig.Provider.
// TODO: whether and how long this code is needed is getting discussed // TODO: whether and how long this code is needed is getting discussed