From 02a2d79bde66feaf152ead4974da6a735a009a79 Mon Sep 17 00:00:00 2001 From: Kenichi Omichi Date: Wed, 28 Aug 2019 23:03:43 +0000 Subject: [PATCH] Reduce indents of DumpAllNamespaceInfo() During cleanup of DumpAllNamespaceInfo(), the code was a little unreadable. This reduces the indents for the code readability. --- test/e2e/framework/util.go | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/test/e2e/framework/util.go b/test/e2e/framework/util.go index b825aae8d4c..356b41cf591 100644 --- a/test/e2e/framework/util.go +++ b/test/e2e/framework/util.go @@ -1769,14 +1769,15 @@ func DumpAllNamespaceInfo(c clientset.Interface, namespace string) { // 2. there are so many of them that working with them are mostly impossible // So we dump them only if the cluster is relatively small. maxNodesForDump := TestContext.MaxNodesToGather - if nodes, err := c.CoreV1().Nodes().List(metav1.ListOptions{}); err == nil { - if len(nodes.Items) <= maxNodesForDump { - dumpAllNodeInfo(c) - } else { - e2elog.Logf("skipping dumping cluster info - cluster too large") - } - } else { + nodes, err := c.CoreV1().Nodes().List(metav1.ListOptions{}) + if err != nil { e2elog.Logf("unable to fetch node list: %v", err) + return + } + if len(nodes.Items) <= maxNodesForDump { + dumpAllNodeInfo(c) + } else { + e2elog.Logf("skipping dumping cluster info - cluster too large") } }