github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 20:24:09 +00:00
Code Issues Projects Releases Wiki Activity

Issue 63622 - Flaky e2e/aggr test.

Browse Source 
Investigated issue 63622. The test usually passes. When it does it seems
to take almost 30 seconds for the sample-apiserver to start returning
2xx rather than 4xx to flunder requests. On the failing tests I looked
at it was taking almost 45 seconds for the sample-apiserver to become
healthy. I bumped the wait/timeout in the test for this case to 60
seconds. I also added a log statement to make it easier to track how
long it was taking for the sample-apiserver to come up. Once we have a
bit more history I will log a bug for the long start up time.
Fixed go format error.
This commit is contained in:
Walter Fender 2018-06-11 14:43:23 -07:00
parent de8cc31355
commit 02bd75764c
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/e2e/apimachinery/aggregator.go
View File

@ -324,7 +324,7 @@ func TestSampleAPIServer(f *framework.Framework, image string) {
currentPods *v1.PodList currentPods *v1.PodList
) )
err = wait.Poll(100*time.Millisecond, 30*time.Second, func() (bool, error) { err = pollTimed(100*time.Millisecond, 60*time.Second, func() (bool, error) {
currentAPIService, _ = aggrclient.ApiregistrationV1beta1().APIServices().Get("v1alpha1.wardle.k8s.io", metav1.GetOptions{}) currentAPIService, _ = aggrclient.ApiregistrationV1beta1().APIServices().Get("v1alpha1.wardle.k8s.io", metav1.GetOptions{})
currentPods, _ = client.CoreV1().Pods(namespace).List(metav1.ListOptions{}) currentPods, _ = client.CoreV1().Pods(namespace).List(metav1.ListOptions{})
@ -346,7 +346,7 @@ func TestSampleAPIServer(f *framework.Framework, image string) {
return false, err return false, err
} }
return true, nil return true, nil
}) }, "Waited %s for the sample-apiserver to be ready to handle requests.")
if err != nil { if err != nil {
currentAPIServiceJSON, _ := json.Marshal(currentAPIService) currentAPIServiceJSON, _ := json.Marshal(currentAPIService)
framework.Logf("current APIService: %s", string(currentAPIServiceJSON)) framework.Logf("current APIService: %s", string(currentAPIServiceJSON))
@ -460,6 +460,17 @@ func TestSampleAPIServer(f *framework.Framework, image string) {
cleanTest(client, aggrclient, namespace) cleanTest(client, aggrclient, namespace)
} }
// pollTimed will call Poll but time how long Poll actually took.
// It will then framework.logf the msg with the duration of the Poll.
// It is assumed that msg will contain one %s for the elapsed time.
func pollTimed(interval, timeout time.Duration, condition wait.ConditionFunc, msg string) error {
defer func(start time.Time, msg string) {
elapsed := time.Since(start)
framework.Logf(msg, elapsed)
}(time.Now(), msg)
return wait.Poll(interval, timeout, condition)
}
func validateErrorWithDebugInfo(f *framework.Framework, err error, pods *v1.PodList, msg string, fields ...interface{}) { func validateErrorWithDebugInfo(f *framework.Framework, err error, pods *v1.PodList, msg string, fields ...interface{}) {
if err != nil { if err != nil {
namespace := f.Namespace.Name namespace := f.Namespace.Name