From 037640af8c87156851c25bfe4529876df691ea39 Mon Sep 17 00:00:00 2001 From: ZhaoRuquan <49401013+ruquanzhao@users.noreply.github.com> Date: Tue, 22 Aug 2023 17:43:46 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Mahamed Ali --- cluster/common.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cluster/common.sh b/cluster/common.sh index 96eb87089b9..4b4d1ee53ec 100755 --- a/cluster/common.sh +++ b/cluster/common.sh @@ -330,10 +330,10 @@ function find-tar() { function find-release-tars() { # Use first item in KUBE_BUILD_PLATFORMS as server platform KUBE_BUILD_PLATFORMS=${KUBE_BUILD_PLATFORMS:-"linux/amd64"} - SERVER_PLATFORM=$(cut -d' ' -f1 <<< $KUBE_BUILD_PLATFORMS) - OS=$(cut -d'/' -f1 <<< $SERVER_PLATFORM) - ARCH=$(cut -d'/' -f2 <<< $SERVER_PLATFORM) - SERVER_BINARY_TAR=$(find-tar kubernetes-server-${OS}-${ARCH}.tar.gz) + SERVER_PLATFORM=$(cut -d' ' -f1 <<< "${KUBE_BUILD_PLATFORMS}") + OS=$(cut -d'/' -f1 <<< "${SERVER_PLATFORM}") + ARCH=$(cut -d'/' -f2 <<< "${SERVER_PLATFORM}") + SERVER_BINARY_TAR=$(find-tar kubernetes-server-"${OS}"-"${ARCH}".tar.gz) if [[ -z "${SERVER_BINARY_TAR}" ]]; then exit 1 fi @@ -341,7 +341,7 @@ function find-release-tars() { local find_result if [[ "${NUM_WINDOWS_NODES}" -gt "0" ]]; then - if NODE_BINARY_TAR=$(find-tar kubernetes-node-windows-${ARCH}.tar.gz); then + if NODE_BINARY_TAR=$(find-tar kubernetes-node-windows-"${ARCH}".tar.gz); then find_result=0 else find_result=1