From 8dcd8696654e4993fb96bc0522f509fce2d06946 Mon Sep 17 00:00:00 2001 From: lengrongfu Date: Sun, 9 Oct 2022 15:29:19 +0800 Subject: [PATCH] feat: update preemption victims metric Signed-off-by: lengrongfu --- pkg/scheduler/metrics/metrics.go | 4 ++-- .../testdata/stable-metrics-list.yaml | 17 +++++++---------- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/pkg/scheduler/metrics/metrics.go b/pkg/scheduler/metrics/metrics.go index 43ca7e77796..abe97d700c4 100644 --- a/pkg/scheduler/metrics/metrics.go +++ b/pkg/scheduler/metrics/metrics.go @@ -77,8 +77,8 @@ var ( Subsystem: SchedulerSubsystem, Name: "preemption_victims", Help: "Number of selected preemption victims", - // we think #victims>50 is pretty rare, therefore [50, +Inf) is considered a single bucket. - Buckets: metrics.LinearBuckets(5, 5, 10), + // we think #victims>64 is pretty rare, therefore [64, +Inf) is considered a single bucket. + Buckets: metrics.ExponentialBuckets(1, 2, 7), StabilityLevel: metrics.STABLE, }) PreemptionAttempts = metrics.NewCounter( diff --git a/test/instrumentation/testdata/stable-metrics-list.yaml b/test/instrumentation/testdata/stable-metrics-list.yaml index b6062178e15..5c6b551ce6c 100644 --- a/test/instrumentation/testdata/stable-metrics-list.yaml +++ b/test/instrumentation/testdata/stable-metrics-list.yaml @@ -88,16 +88,13 @@ type: Histogram stabilityLevel: STABLE buckets: - - 5 - - 10 - - 15 - - 20 - - 25 - - 30 - - 35 - - 40 - - 45 - - 50 + - 1 + - 2 + - 4 + - 8 + - 16 + - 32 + - 64 - name: queue_incoming_pods_total subsystem: scheduler help: Number of pods added to scheduling queues by event and queue type.