sched: remove Unknown queuing literal

This commit is contained in:
Wei Huang 2021-02-10 11:02:44 -08:00
parent 0f3aada51e
commit 04a40d1f18
No known key found for this signature in database
GPG Key ID: BE5E9752F8B6E005
2 changed files with 4 additions and 12 deletions

View File

@ -118,14 +118,8 @@ func (sched *Scheduler) updateNodeInCache(oldObj, newObj interface{}) {
klog.Errorf("scheduler cache UpdateNode failed: %v", err)
}
// Only activate unschedulable pods if the node became more schedulable.
// We skip the node property comparison when there is no unschedulable pods in the queue
// to save processing cycles. We still trigger a move to active queue to cover the case
// that a pod being processed by the scheduler is determined unschedulable. We want this
// pod to be reevaluated when a change in the cluster happens.
if sched.SchedulingQueue.NumUnschedulablePods() == 0 {
sched.SchedulingQueue.MoveAllToActiveOrBackoffQueue(queue.Unknown)
} else if event := nodeSchedulingPropertiesChange(newNode, oldNode); event != "" {
// Only requeue unschedulable pods if the node became more schedulable.
if event := nodeSchedulingPropertiesChange(newNode, oldNode); event != "" {
sched.SchedulingQueue.MoveAllToActiveOrBackoffQueue(event)
}
}

View File

@ -18,8 +18,6 @@ package queue
// Events that trigger scheduler queue to change.
const (
// Unknown event
Unknown = "Unknown"
// PodAdd is the event when a new pod is added to API server.
PodAdd = "PodAdd"
// NodeAdd is the event when a new node is added to the cluster.
@ -63,9 +61,9 @@ const (
NodeSpecUnschedulableChange = "NodeSpecUnschedulableChange"
// NodeAllocatableChange is the event when node allocatable is changed.
NodeAllocatableChange = "NodeAllocatableChange"
// NodeLabelsChange is the event when node label is changed.
// NodeLabelChange is the event when node label is changed.
NodeLabelChange = "NodeLabelChange"
// NodeTaintsChange is the event when node taint is changed.
// NodeTaintChange is the event when node taint is changed.
NodeTaintChange = "NodeTaintChange"
// NodeConditionChange is the event when node condition is changed.
NodeConditionChange = "NodeConditionChange"