github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 05:03:09 +00:00
Code Issues Projects Releases Wiki Activity

Improve pathrecorder duplicate registration info

Browse Source 
Print information from both the original path registration and the new
path registration stack traces when encountering a duplicate. This helps
the developer determine where the duplication is coming from and makes
it much easier to resolve.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
This commit is contained in:
Andy Goldstein 2021-12-03 14:42:27 -05:00
parent 2daa3415ec
commit 04aa8f9dcd
No known key found for this signature in database
GPG Key ID: 409C2BE062A844A4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/apiserver/pkg/server/mux/pathrecorder.go
View File

@ -103,10 +103,11 @@ func (m *PathRecorderMux) ListedPaths() []string {
} }
func (m *PathRecorderMux) trackCallers(path string) { func (m *PathRecorderMux) trackCallers(path string) {
stack := string(debug.Stack())
if existingStack, ok := m.pathStacks[path]; ok { if existingStack, ok := m.pathStacks[path]; ok {
utilruntime.HandleError(fmt.Errorf("registered %q from %v", path, existingStack)) utilruntime.HandleError(fmt.Errorf("duplicate path registration of %q: original registration from %v\n\nnew registration from %v", path, existingStack, stack))
} }
m.pathStacks[path] = string(debug.Stack()) m.pathStacks[path] = stack
} }
// refreshMuxLocked creates a new mux and must be called while locked. Otherwise the view of handlers may // refreshMuxLocked creates a new mux and must be called while locked. Otherwise the view of handlers may