From aa173c834f291cab3fea5ebf5da18053f8329470 Mon Sep 17 00:00:00 2001 From: Jianfei Bai Date: Mon, 19 Aug 2019 20:08:42 +0800 Subject: [PATCH] Remove duplicated log. --- pkg/kubelet/kubelet_node_status.go | 2 +- pkg/kubelet/nodestatus/setters.go | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/kubelet/kubelet_node_status.go b/pkg/kubelet/kubelet_node_status.go index 46e0595a751..6da8d407b90 100644 --- a/pkg/kubelet/kubelet_node_status.go +++ b/pkg/kubelet/kubelet_node_status.go @@ -503,7 +503,7 @@ func (kl *Kubelet) setNodeStatus(node *v1.Node) { for i, f := range kl.setNodeStatusFuncs { klog.V(5).Infof("Setting node status at position %v", i) if err := f(node); err != nil { - klog.Warningf("Failed to set some node status fields: %s", err) + klog.Errorf("Failed to set some node status fields: %s", err) } } } diff --git a/pkg/kubelet/nodestatus/setters.go b/pkg/kubelet/nodestatus/setters.go index bbeabe280a4..bb64442af98 100644 --- a/pkg/kubelet/nodestatus/setters.go +++ b/pkg/kubelet/nodestatus/setters.go @@ -364,8 +364,6 @@ func VersionInfo(versionInfoFunc func() (*cadvisorapiv1.VersionInfo, error), // return func(node *v1.Node) error { verinfo, err := versionInfoFunc() if err != nil { - // TODO(mtaufen): consider removing this log line, since returned error will be logged - klog.Errorf("Error getting version info: %v", err) return fmt.Errorf("error getting version info: %v", err) } @@ -404,8 +402,6 @@ func Images(nodeStatusMaxImages int32, var imagesOnNode []v1.ContainerImage containerImages, err := imageListFunc() if err != nil { - // TODO(mtaufen): consider removing this log line, since returned error will be logged - klog.Errorf("Error getting image list: %v", err) node.Status.Images = imagesOnNode return fmt.Errorf("error getting image list: %v", err) }