From 059e8353b76cd7f8f0702aa5e2b0e577c79dd0ac Mon Sep 17 00:00:00 2001 From: AxeZhan Date: Tue, 5 Sep 2023 19:23:01 +0800 Subject: [PATCH] check labels/annotations in the beginning --- test/e2e/kubectl/rollout.go | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/test/e2e/kubectl/rollout.go b/test/e2e/kubectl/rollout.go index f51ea382018..fe4c296b0e0 100644 --- a/test/e2e/kubectl/rollout.go +++ b/test/e2e/kubectl/rollout.go @@ -69,15 +69,22 @@ var _ = SIGDescribe("Kubectl rollout", func() { } origEnv := d.Spec.Template.Spec.Containers[0].Env - origLabels := d.Spec.Template.Labels - origAnnotations := d.Spec.Template.Annotations - for _, env := range origEnv { if env.Name == "foo" && env.Value == "bar" { framework.Failf("labeled deployment should not have an env named foo and valued bar at the beginning") } } + origLabels := d.Spec.Template.Labels + if len(origLabels) == 0 { + framework.Failf("original labels should not be empty in kubectl rollout test") + } + + origAnnotations := d.Spec.Template.Annotations + if len(origAnnotations) == 0 { + framework.Failf("original annotations should not be empty in kubectl rollout test") + } + // do a small update if _, err = e2ekubectl.RunKubectl(ns, "set", "env", "deployment/httpd-deployment", "foo=bar"); err != nil { framework.Failf("kubectl failed set env for deployment")