github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-11-24 05:11:09 +00:00
Code Issues Projects Releases Wiki Activity

Fix for the 'kubectl explain crd --recursive' goes into an infinite loop issue

Browse Source
This commit is contained in:
Vikranth Thati
2018-10-31 03:30:46 +05:30
parent 03a145de8a
commit 05a461c17b
4 changed files with 113 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kubectl/explain/recursive_fields_printer.go
View File

@@ -30,6 +30,7 @@ type recursiveFieldsPrinter struct {
var _ proto.SchemaVisitor = &recursiveFieldsPrinter{}
var _ fieldsPrinter = &recursiveFieldsPrinter{}
var visitedReferences = map[string]struct{}{}
// VisitArray is just a passthrough.
func (f *recursiveFieldsPrinter) VisitArray(a *proto.Array) {
@@ -64,7 +65,12 @@ func (f *recursiveFieldsPrinter) VisitPrimitive(p *proto.Primitive) {
// VisitReference is just a passthrough.
func (f *recursiveFieldsPrinter) VisitReference(r proto.Reference) {
if _, ok := visitedReferences[r.Reference()]; ok {
return
}
visitedReferences[r.Reference()] = struct{}{}
r.SubSchema().Accept(f)
delete(visitedReferences, r.Reference())
}
// PrintFields will recursively print all the fields for the given