From ed3ebbaaa7580ec5395c4aeb913df2546155f146 Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Fri, 23 Dec 2022 12:32:17 -0800 Subject: [PATCH] Remove TODO about API proxy checking for svc --- pkg/registry/core/service/storage/storage.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/registry/core/service/storage/storage.go b/pkg/registry/core/service/storage/storage.go index 12d44aaf834..17c14e63b9b 100644 --- a/pkg/registry/core/service/storage/storage.go +++ b/pkg/registry/core/service/storage/storage.go @@ -464,7 +464,7 @@ func (r *REST) ResourceLocation(ctx context.Context, id string) (*url.URL, http. // but in the expected case we'll only make one. for try := 0; try < len(ss.Addresses); try++ { addr := ss.Addresses[(addrSeed+try)%len(ss.Addresses)] - // TODO(thockin): do we really need this check? + // We only proxy to addresses that are actually pods. if err := isValidAddress(ctx, &addr, r.pods); err != nil { utilruntime.HandleError(fmt.Errorf("Address %v isn't valid (%v)", addr, err)) continue