github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-11 04:52:08 +00:00
Code Issues Projects Releases Wiki Activity

mention overflows when mistakenly call function FromInt

Browse Source
This commit is contained in:
xialong.lee 2016-11-09 13:58:31 +08:00
parent 68a7c2c6b5
commit 06f138a689
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/util/intstr/BUILD
View File

@ -21,6 +21,7 @@ go_library(
"//pkg/genericapiserver/openapi/common:go_default_library", "//pkg/genericapiserver/openapi/common:go_default_library",
"//vendor:github.com/go-openapi/spec", "//vendor:github.com/go-openapi/spec",
"//vendor:github.com/gogo/protobuf/proto", "//vendor:github.com/gogo/protobuf/proto",
"//vendor:github.com/golang/glog",
"//vendor:github.com/google/gofuzz", "//vendor:github.com/google/gofuzz",
], ],
) )

5
pkg/util/intstr/intstr.go
View File

@ -20,12 +20,14 @@ import (
"encoding/json" "encoding/json"
"fmt" "fmt"
"math" "math"
"runtime/debug"
"strconv" "strconv"
"strings" "strings"
"k8s.io/kubernetes/pkg/genericapiserver/openapi/common" "k8s.io/kubernetes/pkg/genericapiserver/openapi/common"
"github.com/go-openapi/spec" "github.com/go-openapi/spec"
"github.com/golang/glog"
"github.com/google/gofuzz" "github.com/google/gofuzz"
) )
@ -57,6 +59,9 @@ const (
// than int32. // than int32.
// TODO: convert to (val int32) // TODO: convert to (val int32)
func FromInt(val int) IntOrString { func FromInt(val int) IntOrString {
if val > math.MaxInt32 || val < math.MinInt32 {
glog.Errorf("value: %d overflows int32\n%s\n", val, debug.Stack())
}
return IntOrString{Type: Int, IntVal: int32(val)} return IntOrString{Type: Int, IntVal: int32(val)}
} }