github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-16 07:13:53 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #129643 from dims/prevent-alpha-feature-gates-from-being-enabled-by-default

Browse Source 
Prevent alpha feature gates from being enabled by default
This commit is contained in:
Kubernetes Prow Robot 2025-01-15 12:28:33 -08:00 committed by GitHub
commit 071296aaab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pkg/features/kube_features_test.go
View File

@ -73,3 +73,27 @@ func TestAllRegisteredFeaturesExpected(t *testing.T) {
}
}
}
func TestEnsureAlphaGatesAreNotSwitchedOnByDefault(t *testing.T) {
checkAlphaGates := func(feature featuregate.Feature, spec featuregate.FeatureSpec) {
// FIXME(dims): remove this check when WindowsHostNetwork is fixed up or removed
// entirely. Please do NOT add more entries here.
if feature == "WindowsHostNetwork" {
return
}
if spec.PreRelease == featuregate.Alpha && spec.Default {
t.Errorf("The alpha feature gate %q is switched on by default", feature)
}
if spec.PreRelease == featuregate.Alpha && spec.LockToDefault {
t.Errorf("The alpha feature gate %q is locked to default", feature)
}
}
for feature, spec := range defaultKubernetesFeatureGates {
checkAlphaGates(feature, spec)
}
for feature, specs := range defaultVersionedKubernetesFeatureGates {
for _, spec := range specs {
checkAlphaGates(feature, spec)
}
}
}