github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 05:03:09 +00:00
Code Issues Projects Releases Wiki Activity

handle nil extension points

Browse Source
This commit is contained in:
JieJhih Jhang 2019-05-18 07:24:27 +08:00
parent 2cd5fc54a1
commit 0734d1debb
1 changed files with 53 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
pkg/scheduler/framework/v1alpha1/framework.go
View File

@ -84,66 +84,76 @@ func NewFramework(r Registry, plugins *config.Plugins, args []config.PluginConfi
f.plugins[name] = p f.plugins[name] = p
} }
for _, r := range plugins.Reserve.Enabled { if plugins.Reserve != nil {
if pg, ok := f.plugins[r.Name]; ok { for _, r := range plugins.Reserve.Enabled {
p, ok := pg.(ReservePlugin) if pg, ok := f.plugins[r.Name]; ok {
if !ok { p, ok := pg.(ReservePlugin)
return nil, fmt.Errorf("plugin %v does not extend reserve plugin", r.Name) if !ok {
return nil, fmt.Errorf("plugin %v does not extend reserve plugin", r.Name)
}
f.reservePlugins = append(f.reservePlugins, p)
} else {
return nil, fmt.Errorf("reserve plugin %v does not exist", r.Name)
} }
f.reservePlugins = append(f.reservePlugins, p)
} else {
return nil, fmt.Errorf("reserve plugin %v does not exist", r.Name)
} }
} }
for _, pb := range plugins.PreBind.Enabled { if plugins.PreBind != nil {
if pg, ok := f.plugins[pb.Name]; ok { for _, pb := range plugins.PreBind.Enabled {
p, ok := pg.(PrebindPlugin) if pg, ok := f.plugins[pb.Name]; ok {
if !ok { p, ok := pg.(PrebindPlugin)
return nil, fmt.Errorf("plugin %v does not extend prebind plugin", pb.Name) if !ok {
return nil, fmt.Errorf("plugin %v does not extend prebind plugin", pb.Name)
}
f.prebindPlugins = append(f.prebindPlugins, p)
} else {
return nil, fmt.Errorf("prebind plugin %v does not exist", pb.Name)
} }
f.prebindPlugins = append(f.prebindPlugins, p)
} else {
return nil, fmt.Errorf("prebind plugin %v does not exist", pb.Name)
} }
} }
for _, ur := range plugins.Unreserve.Enabled { if plugins.Unreserve != nil {
if pg, ok := f.plugins[ur.Name]; ok { for _, ur := range plugins.Unreserve.Enabled {
p, ok := pg.(UnreservePlugin) if pg, ok := f.plugins[ur.Name]; ok {
if !ok { p, ok := pg.(UnreservePlugin)
return nil, fmt.Errorf("plugin %v does not extend unreserve plugin", ur.Name) if !ok {
return nil, fmt.Errorf("plugin %v does not extend unreserve plugin", ur.Name)
}
f.unreservePlugins = append(f.unreservePlugins, p)
} else {
return nil, fmt.Errorf("unreserve plugin %v does not exist", ur.Name)
} }
f.unreservePlugins = append(f.unreservePlugins, p)
} else {
return nil, fmt.Errorf("unreserve plugin %v does not exist", ur.Name)
} }
} }
for _, pr := range plugins.Permit.Enabled { if plugins.Permit != nil {
if pg, ok := f.plugins[pr.Name]; ok { for _, pr := range plugins.Permit.Enabled {
p, ok := pg.(PermitPlugin) if pg, ok := f.plugins[pr.Name]; ok {
if !ok { p, ok := pg.(PermitPlugin)
return nil, fmt.Errorf("plugin %v does not extend permit plugin", pr.Name) if !ok {
return nil, fmt.Errorf("plugin %v does not extend permit plugin", pr.Name)
}
f.permitPlugins = append(f.permitPlugins, p)
} else {
return nil, fmt.Errorf("permit plugin %v does not exist", pr.Name)
} }
f.permitPlugins = append(f.permitPlugins, p)
} else {
return nil, fmt.Errorf("permit plugin %v does not exist", pr.Name)
} }
} }
for _, qs := range plugins.QueueSort.Enabled { if plugins.QueueSort != nil {
if pg, ok := f.plugins[qs.Name]; ok { for _, qs := range plugins.QueueSort.Enabled {
p, ok := pg.(QueueSortPlugin) if pg, ok := f.plugins[qs.Name]; ok {
if !ok { p, ok := pg.(QueueSortPlugin)
return nil, fmt.Errorf("plugin %v does not extend queue sort plugin", qs.Name) if !ok {
return nil, fmt.Errorf("plugin %v does not extend queue sort plugin", qs.Name)
}
f.queueSortPlugins = append(f.queueSortPlugins, p)
if len(f.queueSortPlugins) > 1 {
return nil, fmt.Errorf("only one queue sort plugin can be enabled")
}
} else {
return nil, fmt.Errorf("queue sort plugin %v does not exist", qs.Name)
} }
f.queueSortPlugins = append(f.queueSortPlugins, p)
if len(f.queueSortPlugins) > 1 {
return nil, fmt.Errorf("only one queue sort plugin can be enabled")
}
} else {
return nil, fmt.Errorf("queue sort plugin %v does not exist", qs.Name)
} }
} }