github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 21:17:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #27711 from xiangpengzhao/port-allocator-test

Browse Source 
Automatic merge from submit-queue

Cover port_allocator_test with more conditions

The test cases of port_allocator_test should cover more conditions, such as `rangeAllocator.used.Bit`.
This commit is contained in:
Kubernetes Submit Queue 2016-12-07 12:14:36 -08:00 committed by GitHub
commit 08c0f7dded
1 changed files with 49 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
pkg/proxy/userspace/port_allocator_test.go
View File

@ -37,7 +37,9 @@ func TestRangeAllocatorEmpty(t *testing.T) {
func TestRangeAllocatorFullyAllocated(t *testing.T) { func TestRangeAllocatorFullyAllocated(t *testing.T) {
r := &net.PortRange{} r := &net.PortRange{}
r.Set("1-1") r.Set("1-1")
a := newPortRangeAllocator(*r) pra := newPortRangeAllocator(*r)
a := pra.(*rangeAllocator)
p, err := a.AllocateNext() p, err := a.AllocateNext()
if err != nil { if err != nil {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
@ -46,12 +48,26 @@ func TestRangeAllocatorFullyAllocated(t *testing.T) {
t.Fatalf("unexpected allocated port: %d", p) t.Fatalf("unexpected allocated port: %d", p)
} }
a.lock.Lock()
if bit := a.used.Bit(p - a.Base); bit != 1 {
a.lock.Unlock()
t.Fatalf("unexpected used bit for allocated port: %d", p)
}
a.lock.Unlock()
_, err = a.AllocateNext() _, err = a.AllocateNext()
if err == nil { if err == nil {
t.Fatalf("expected error because of fully-allocated range") t.Fatalf("expected error because of fully-allocated range")
} }
a.Release(p) a.Release(p)
a.lock.Lock()
if bit := a.used.Bit(p - a.Base); bit != 0 {
a.lock.Unlock()
t.Fatalf("unexpected used bit for allocated port: %d", p)
}
a.lock.Unlock()
p, err = a.AllocateNext() p, err = a.AllocateNext()
if err != nil { if err != nil {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
@ -59,6 +75,12 @@ func TestRangeAllocatorFullyAllocated(t *testing.T) {
if p != 1 { if p != 1 {
t.Fatalf("unexpected allocated port: %d", p) t.Fatalf("unexpected allocated port: %d", p)
} }
a.lock.Lock()
if bit := a.used.Bit(p - a.Base); bit != 1 {
a.lock.Unlock()
t.Fatalf("unexpected used bit for allocated port: %d", p)
}
a.lock.Unlock()
_, err = a.AllocateNext() _, err = a.AllocateNext()
if err == nil { if err == nil {
@ -69,7 +91,8 @@ func TestRangeAllocatorFullyAllocated(t *testing.T) {
func TestRangeAllocator_RandomishAllocation(t *testing.T) { func TestRangeAllocator_RandomishAllocation(t *testing.T) {
r := &net.PortRange{} r := &net.PortRange{}
r.Set("1-100") r.Set("1-100")
a := newPortRangeAllocator(*r) pra := newPortRangeAllocator(*r)
a := pra.(*rangeAllocator)
// allocate all the ports // allocate all the ports
var err error var err error
@ -79,11 +102,26 @@ func TestRangeAllocator_RandomishAllocation(t *testing.T) {
if err != nil { if err != nil {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
} }
if ports[i] < 1 || ports[i] > 100 {
t.Fatalf("unexpected allocated port: %d", ports[i])
}
a.lock.Lock()
if bit := a.used.Bit(ports[i] - a.Base); bit != 1 {
a.lock.Unlock()
t.Fatalf("unexpected used bit for allocated port: %d", ports[i])
}
a.lock.Unlock()
} }
// release them all // release them all
for i := 0; i < 100; i++ { for i := 0; i < 100; i++ {
a.Release(ports[i]) a.Release(ports[i])
a.lock.Lock()
if bit := a.used.Bit(ports[i] - a.Base); bit != 0 {
a.lock.Unlock()
t.Fatalf("unexpected used bit for allocated port: %d", ports[i])
}
a.lock.Unlock()
} }
// allocate the ports again // allocate the ports again
@ -93,6 +131,15 @@ func TestRangeAllocator_RandomishAllocation(t *testing.T) {
if err != nil { if err != nil {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
} }
if rports[i] < 1 || rports[i] > 100 {
t.Fatalf("unexpected allocated port: %d", rports[i])
}
a.lock.Lock()
if bit := a.used.Bit(rports[i] - a.Base); bit != 1 {
a.lock.Unlock()
t.Fatalf("unexpected used bit for allocated port: %d", rports[i])
}
a.lock.Unlock()
} }
if reflect.DeepEqual(ports, rports) { if reflect.DeepEqual(ports, rports) {