github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 10:51:29 +00:00
Code Issues Projects Releases Wiki Activity

Replace false with exit 1

Browse Source 
Some scripts contained `false` for returning 1 to callers instead of
`exit 1` and that works like:

  $ false
  $ echo $?
  1
  $

But that made confusion in a PR review process.
So this replaces `false` with `exit 1` for long-term maintenance.
This commit is contained in:
Kenichi Omichi 2019-04-16 23:13:00 +00:00
parent db5d390d99
commit 08dc056480
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hack/verify-golint.sh
View File

@ -94,7 +94,7 @@ else
echo 'checking by adding it to hack/.golint_failures (if your reviewer is okay with it).' echo 'checking by adding it to hack/.golint_failures (if your reviewer is okay with it).'
echo echo
} >&2 } >&2
false exit 1
fi fi
if [[ ${#not_failing[@]} -gt 0 ]]; then if [[ ${#not_failing[@]} -gt 0 ]]; then
@ -106,7 +106,7 @@ if [[ ${#not_failing[@]} -gt 0 ]]; then
done done
echo echo
} >&2 } >&2
false exit 1
fi fi
if [[ ${#gone[@]} -gt 0 ]]; then if [[ ${#gone[@]} -gt 0 ]]; then
@ -118,5 +118,5 @@ if [[ ${#gone[@]} -gt 0 ]]; then
done done
echo echo
} >&2 } >&2
false exit 1
fi fi

6
hack/verify-shellcheck.sh
View File

@ -169,7 +169,7 @@ else
echo 'checking by adding it to hack/.shellcheck_failures (if your reviewer is okay with it).' echo 'checking by adding it to hack/.shellcheck_failures (if your reviewer is okay with it).'
echo echo
} >&2 } >&2
false exit 1
fi fi
if [[ ${#not_failing[@]} -gt 0 ]]; then if [[ ${#not_failing[@]} -gt 0 ]]; then
@ -181,7 +181,7 @@ if [[ ${#not_failing[@]} -gt 0 ]]; then
done done
echo echo
} >&2 } >&2
false exit 1
fi fi
# Check that all failing_packages actually still exist # Check that all failing_packages actually still exist
@ -199,5 +199,5 @@ if [[ ${#gone[@]} -gt 0 ]]; then
done done
echo echo
} >&2 } >&2
false exit 1
fi fi