From 09379fbba7304fda2b50e9287b65ba6ef8436cce Mon Sep 17 00:00:00 2001 From: Bartosz Date: Wed, 4 Mar 2026 10:11:57 +0000 Subject: [PATCH] Remove test for unhandled case. Assume placement will always contain nodes that are present in the snapshot --- pkg/scheduler/backend/cache/snapshot_test.go | 31 -------------------- 1 file changed, 31 deletions(-) diff --git a/pkg/scheduler/backend/cache/snapshot_test.go b/pkg/scheduler/backend/cache/snapshot_test.go index 2e70b475ee2..5b9fe6690ef 100644 --- a/pkg/scheduler/backend/cache/snapshot_test.go +++ b/pkg/scheduler/backend/cache/snapshot_test.go @@ -695,37 +695,6 @@ func TestSnapshot_Placement(t *testing.T) { } }, }, - { - name: "When placement contains nodes from outside the snapshot, AssumePlacement returns error and placement is not set", - initialNodes: []string{"n1", "n2", "n3"}, - placementNodes: []string{"n2", "n3", "n4"}, - testFn: func(t *testing.T, snapshot *Snapshot, placement *fwk.Placement) { - err := snapshot.AssumePlacement(placement) - if err == nil { - t.Fatalf("expected AssumePlacement to return error due to placement using a node from outside the snapshot but got nil") - } - // ensure the placement is cleared - numNodes := snapshot.NumNodesInPlacement() - if numNodes != 3 { - t.Errorf("unexpected number of nodes from NumNodesInPlacement, want: %v, got: %v", 3, numNodes) - } - nodes, err := snapshot.ListNodesInPlacement() - if err != nil { - t.Fatalf("unexpected error from ListNodesInPlacement %v", err) - } - if len(nodes) != 3 { - t.Errorf("unexpected number of nodes from ListNodesInPlacement, want: %v, got: %v", 3, len(nodes)) - } - _, err = snapshot.GetNodeInPlacement("n1") - if err != nil { - t.Errorf("expected GetNodeInPlacement to find node but instead got unexpected error %v", err) - } - _, err = snapshot.GetNodeInPlacement("n4") - if err == nil { - t.Errorf("expected GetNodeInPlacement not to find node but instead got nil error") - } - }, - }, { name: "When placement uses nodes that point to a different instance than snapshot, AssumePlacement returns error and placement is not set", initialNodes: []string{"n1", "n2", "n3"},