github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-12-05 15:37:35 +00:00
Code Issues Projects Releases Wiki Activity

address reviews

Browse Source
This commit is contained in:
Kensei Nakada
2023-12-31 06:52:31 +00:00
parent 5ab2317947
commit 09abd6be5a
7 changed files with 62 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/scheduler/framework/runtime/framework_test.go
View File

@@ -1656,7 +1656,7 @@ func TestRunPreFilterPlugins(t *testing.T) {
wantStatusCode: framework.UnschedulableAndUnresolvable,
},
{
name: "all nodes are filtered out by prefilter result, but all other plugins are executed",
name: "all nodes are filtered out by prefilter result, but other plugins aren't executed because we consider all nodes are filtered out by UnschedulableAndUnresolvable",
plugins: []*TestPlugin{
{
name: "reject-all-nodes",
@@ -1669,8 +1669,8 @@ func TestRunPreFilterPlugins(t *testing.T) {
},
},
wantPreFilterResult: &framework.PreFilterResult{NodeNames: sets.New[string]()},
wantSkippedPlugins: sets.New("skip"),
wantStatusCode: framework.Unschedulable,
wantSkippedPlugins: sets.New[string](), // "skip" plugin isn't executed.
wantStatusCode: framework.UnschedulableAndUnresolvable,
},
}
for _, tt := range tests {