From 0a21157c96f5a06254f54416419e6abba93da7b3 Mon Sep 17 00:00:00 2001 From: Adhityaa Chandrasekar Date: Thu, 25 Mar 2021 06:31:35 +0000 Subject: [PATCH] job controller: don't mutate shared cache object Signed-off-by: Adhityaa Chandrasekar --- pkg/controller/job/job_controller.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/controller/job/job_controller.go b/pkg/controller/job/job_controller.go index df45826f745..cd50c5f2cdf 100644 --- a/pkg/controller/job/job_controller.go +++ b/pkg/controller/job/job_controller.go @@ -462,7 +462,8 @@ func (jm *Controller) syncJob(key string) (bool, error) { } return false, err } - job := *sharedJob + // make a copy so we don't mutate the shared cache + job := *sharedJob.DeepCopy() // if job was finished previously, we don't want to redo the termination if IsJobFinished(&job) {