From 0a301490f61bbddf426d9bb49356172b00a2e0eb Mon Sep 17 00:00:00 2001 From: Mark Rossetti Date: Fri, 14 Feb 2025 13:20:21 -0800 Subject: [PATCH] Fixing k8s.io/kubernetes/pkg/kubelet/kuberuntime unit tests on Windows Signed-off-by: Mark Rossetti --- pkg/kubelet/kuberuntime/kuberuntime_container_test.go | 3 +++ pkg/kubelet/kuberuntime/kuberuntime_manager_test.go | 3 +++ 2 files changed, 6 insertions(+) diff --git a/pkg/kubelet/kuberuntime/kuberuntime_container_test.go b/pkg/kubelet/kuberuntime/kuberuntime_container_test.go index b9fd964724f..9c67e5a17cb 100644 --- a/pkg/kubelet/kuberuntime/kuberuntime_container_test.go +++ b/pkg/kubelet/kuberuntime/kuberuntime_container_test.go @@ -246,6 +246,9 @@ func TestToKubeContainerStatus(t *testing.T) { // TestToKubeContainerStatusWithResources tests the converting the CRI container status to // the internal type (i.e., toKubeContainerStatus()) for containers that returns Resources. func TestToKubeContainerStatusWithResources(t *testing.T) { + if goruntime.GOOS == "windows" { + t.Skip("InPlacePodVerticalScaling is not currently supported on Windows.") + } featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true) tCtx := ktesting.Init(t) diff --git a/pkg/kubelet/kuberuntime/kuberuntime_manager_test.go b/pkg/kubelet/kuberuntime/kuberuntime_manager_test.go index 4ba6de785f4..3329213c870 100644 --- a/pkg/kubelet/kuberuntime/kuberuntime_manager_test.go +++ b/pkg/kubelet/kuberuntime/kuberuntime_manager_test.go @@ -2318,6 +2318,9 @@ func makeBasePodAndStatusWithInitAndEphemeralContainers() (*v1.Pod, *kubecontain } func TestComputePodActionsForPodResize(t *testing.T) { + if goruntime.GOOS == "windows" { + t.Skip("InPlacePodVerticalScaling is currently not supported on Windows") + } featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true) tCtx := ktesting.Init(t) _, _, m, err := createTestRuntimeManager(tCtx)