From 0a7b89cc00b2713a38613d5187fb4e6bb3d157bf Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Sat, 7 Feb 2015 14:01:54 -0800 Subject: [PATCH] keep hyperkube noise in one place --- cmd/hyperkube/hyperkube.go | 3 +-- cmd/hyperkube/kube-proxy.go | 41 ++++++++++++++++++++++++++++++++++++ cmd/kube-proxy/app/server.go | 20 ------------------ 3 files changed, 42 insertions(+), 22 deletions(-) create mode 100644 cmd/hyperkube/kube-proxy.go diff --git a/cmd/hyperkube/hyperkube.go b/cmd/hyperkube/hyperkube.go index b0f2c1a3d1c..8c0d4f46b44 100644 --- a/cmd/hyperkube/hyperkube.go +++ b/cmd/hyperkube/hyperkube.go @@ -21,7 +21,6 @@ package main import ( "os" - proxy "github.com/GoogleCloudPlatform/kubernetes/cmd/kube-proxy/app" "github.com/GoogleCloudPlatform/kubernetes/pkg/controllermanager" "github.com/GoogleCloudPlatform/kubernetes/pkg/hyperkube" apiserver "github.com/GoogleCloudPlatform/kubernetes/pkg/master/server" @@ -38,7 +37,7 @@ func main() { hk.AddServer(controllermanager.NewHyperkubeServer()) hk.AddServer(sched.NewHyperkubeServer()) hk.AddServer(NewKubelet()) - hk.AddServer(proxy.NewHyperkubeServer()) + hk.AddServer(NewKubeProxy()) hk.RunToExit(os.Args) } diff --git a/cmd/hyperkube/kube-proxy.go b/cmd/hyperkube/kube-proxy.go new file mode 100644 index 00000000000..088f25368b8 --- /dev/null +++ b/cmd/hyperkube/kube-proxy.go @@ -0,0 +1,41 @@ +/* +Copyright 2015 Google Inc. All rights reserved. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package main + +import ( + kubeproxy "github.com/GoogleCloudPlatform/kubernetes/cmd/kube-proxy/app" + "github.com/GoogleCloudPlatform/kubernetes/pkg/hyperkube" +) + +// NewKubeProxy creates a new hyperkube Server object that includes the +// description and flags. +func NewKubeProxy() *hyperkube.Server { + s := kubeproxy.NewProxyServer() + + hks := hyperkube.Server{ + SimpleUsage: "proxy", + Long: `The Kubernetes proxy server is responsible for taking traffic directed at + services and forwarding it to the appropriate pods. It generally runs on + nodes next to the Kubelet and proxies traffic from local pods to remote pods. + It is also used when handling incoming external traffic.`, + Run: func(_ *hyperkube.Server, args []string) error { + return s.Run(args) + }, + } + s.AddFlags(hks.Flags()) + return &hks +} diff --git a/cmd/kube-proxy/app/server.go b/cmd/kube-proxy/app/server.go index 0ad82534af4..65cb21487a3 100644 --- a/cmd/kube-proxy/app/server.go +++ b/cmd/kube-proxy/app/server.go @@ -27,7 +27,6 @@ import ( "github.com/GoogleCloudPlatform/kubernetes/pkg/api" "github.com/GoogleCloudPlatform/kubernetes/pkg/client" _ "github.com/GoogleCloudPlatform/kubernetes/pkg/healthz" - "github.com/GoogleCloudPlatform/kubernetes/pkg/hyperkube" "github.com/GoogleCloudPlatform/kubernetes/pkg/proxy" "github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config" "github.com/GoogleCloudPlatform/kubernetes/pkg/util" @@ -58,25 +57,6 @@ func NewProxyServer() *ProxyServer { } } -// NewHyperkubeServer creates a new hyperkube Server object that includes the -// description and flags. -func NewHyperkubeServer() *hyperkube.Server { - s := NewProxyServer() - - hks := hyperkube.Server{ - SimpleUsage: "proxy", - Long: `The Kubernetes proxy server is responsible for taking traffic directed at -services and forwarding it to the appropriate pods. It generally runs on -nodes next to the Kubelet and proxies traffic from local pods to remote pods. -It is also used when handling incoming external traffic.`, - Run: func(_ *hyperkube.Server, args []string) error { - return s.Run(args) - }, - } - s.AddFlags(hks.Flags()) - return &hks -} - // AddFlags adds flags for a specific ProxyServer to the specified FlagSet func (s *ProxyServer) AddFlags(fs *pflag.FlagSet) { fs.StringVar(&s.EtcdConfigFile, "etcd_config", s.EtcdConfigFile, "The config file for the etcd client. Mutually exclusive with -etcd_servers")