From 0a954cc10d06c57fdda1f45d566241693a944d0a Mon Sep 17 00:00:00 2001 From: Jiahui Feng Date: Wed, 8 Mar 2023 15:17:58 -0800 Subject: [PATCH] always get fresh object before updating. --- .../cel/validatingadmissionpolicy_test.go | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/test/integration/apiserver/cel/validatingadmissionpolicy_test.go b/test/integration/apiserver/cel/validatingadmissionpolicy_test.go index d7613809150..f3e884b01ed 100644 --- a/test/integration/apiserver/cel/validatingadmissionpolicy_test.go +++ b/test/integration/apiserver/cel/validatingadmissionpolicy_test.go @@ -751,10 +751,13 @@ func Test_PolicyExemption(t *testing.T) { } // validate that operations to ValidatingAdmissionPolicy are exempt from an existing policy that catches all resources - policyCopy := policy.DeepCopy() + policy, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Get(context.TODO(), policy.Name, metav1.GetOptions{}) + if err != nil { + t.Fatal(err) + } ignoreFailurePolicy := admissionregistrationv1alpha1.Ignore - policyCopy.Spec.FailurePolicy = &ignoreFailurePolicy - _, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Update(context.TODO(), policyCopy, metav1.UpdateOptions{}) + policy.Spec.FailurePolicy = &ignoreFailurePolicy + _, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Update(context.TODO(), policy, metav1.UpdateOptions{}) if err != nil { t.Error(err) } @@ -866,9 +869,12 @@ func Test_ValidatingAdmissionPolicy_UpdateParamKind(t *testing.T) { APIVersion: "v1", Kind: "Secret", } - policyCopy := policy.DeepCopy() - policyCopy.Spec.ParamKind = paramKind - _, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Update(context.TODO(), policyCopy, metav1.UpdateOptions{}) + policy, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Get(context.TODO(), policy.Name, metav1.GetOptions{}) + if err != nil { + t.Error(err) + } + policy.Spec.ParamKind = paramKind + _, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Update(context.TODO(), policy, metav1.UpdateOptions{}) if err != nil { t.Error(err) }